From 41dbf8e7bc02e42065da70844c0b50ff69222377 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sat, 12 Oct 2013 20:45:07 +0200 Subject: [PATCH] Rename SpecialRecentChanges::addRecentChangesJS() to addModules() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit …and make it protected. It makes no sense to include class name in the function name, especially since subclasses might want to customize it. Change-Id: Ic0d23f4400b88596fdb11f6c0d8aefc9aea589ba --- RELEASE-NOTES-1.22 | 2 ++ includes/specials/SpecialRecentchanges.php | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES-1.22 b/RELEASE-NOTES-1.22 index a365da6159..32c185499b 100644 --- a/RELEASE-NOTES-1.22 +++ b/RELEASE-NOTES-1.22 @@ -489,6 +489,8 @@ changes to languages because of Bugzilla reports. of media handler overriding MediaHandler::parseParamString. * (bug 46512) The collapsibleNav feature from the Vector extension has been moved to the Vector skin in core. +* SpecialRecentChanges::addRecentChangesJS() function has been renamed + to addModules() and made protected. == Compatibility == diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index b144d7b783..a42a217142 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -155,7 +155,7 @@ class SpecialRecentChanges extends IncludableSpecialPage { $opts = $this->getOptions(); $this->setHeaders(); $this->outputHeader(); - $this->addRecentChangesJS(); + $this->addModules(); // Fetch results, prepare a batch link existence check query $conds = $this->buildMainQueryConds( $opts ); @@ -912,9 +912,9 @@ class SpecialRecentChanges extends IncludableSpecialPage { } /** - * Add JavaScript to the page + * Add page-specific modules. */ - function addRecentChangesJS() { + protected function addModules() { $this->getOutput()->addModules( array( 'mediawiki.special.recentchanges', ) ); -- 2.20.1