Tim Starling [Thu, 6 Jan 2011 09:41:24 +0000 (09:41 +0000)]
Fix for bug 20281. Determining the function of this code is left as an exercise to the reader.
Sam Reed [Thu, 6 Jan 2011 03:27:01 +0000 (03:27 +0000)]
Fixup FIXME on r65818
Sam Reed [Thu, 6 Jan 2011 03:24:35 +0000 (03:24 +0000)]
Fixup fixme on r67819
Sam Reed [Thu, 6 Jan 2011 03:21:01 +0000 (03:21 +0000)]
Fixup minor FIXME on r66724
Sam Reed [Thu, 6 Jan 2011 02:51:32 +0000 (02:51 +0000)]
Fixup raw sql building
Brian Wolff [Thu, 6 Jan 2011 02:42:51 +0000 (02:42 +0000)]
(Bug 25254) cl_timestamp gets updated on null edit where it shouldn't.
Caused by two things:
*after the new category collation stuff, the if this category has changed
code was comparing the user supplied sortkey, with the collation sortable
sortkey, which didn't work. (See also CR for r70415) This is new issue in 1.17
*If the sortkey was too long (long enough to get truncated by DB), then the
did this sortkey change code also failed since it was comparing the
non-truncated sortkey to the truncated sortkey. This issue is present
in older (all previous?) versions of mediawiki. This issue especially affects
non-latin wikis that use 3-byte characters.
This bug primarily is an issue for people using DPL type extension.
I wasn't sure if i should add RELEASE-NOTES, since i'm tagging this 1.17
Sam Reed [Thu, 6 Jan 2011 02:30:02 +0000 (02:30 +0000)]
Fix fixme on r71071, if passed type is not in the array returned by getExtensionTypes(), return the other message by default
Sam Reed [Thu, 6 Jan 2011 02:15:53 +0000 (02:15 +0000)]
Per fixme on r66822, change index to CREATE INDEX /*i*/ar_page_revid ON /*_*/archive (ar_rev_id);
Sam Reed [Thu, 6 Jan 2011 01:23:05 +0000 (01:23 +0000)]
Fixup nasty way of listing tables and left joining in other tables. Use better join_conds syntax
Sam Reed [Thu, 6 Jan 2011 00:31:23 +0000 (00:31 +0000)]
Minor followup to r79649. Rename variables
Benjamin Lees [Thu, 6 Jan 2011 00:12:49 +0000 (00:12 +0000)]
Follow-up to r78285: remove blacklisted file types from $wgFileExtensions in Setup.php, rather than in specials/SpecialUpload.php.
Platonides [Wed, 5 Jan 2011 23:59:04 +0000 (23:59 +0000)]
Unused global
Platonides [Wed, 5 Jan 2011 23:56:10 +0000 (23:56 +0000)]
Unused global
Platonides [Wed, 5 Jan 2011 23:54:07 +0000 (23:54 +0000)]
$messageMemc is used as local variable in line 63, function setUp
$messageMemc is used as local variable in line 74, function setUp
Krinkle [Wed, 5 Jan 2011 23:24:07 +0000 (23:24 +0000)]
Wrote jquery.colorUtil plugin.
* Introduces rgbToHsl and hslToRgb functions
* Introdoces a simple way to get a brigher or darker color
* Moved getRGB() function and colors-array from jquery.color to it so they are publically available.
* Applied fixed from JSLint to all of this
* Made jquery.color use these instead to avoid duplication and added dependency for it
Platonides [Wed, 5 Jan 2011 23:20:54 +0000 (23:20 +0000)]
Remove the createaccount error check, failing since r79377.
The * group have createaccount right, so this seems an error.
Chad Horohoe [Wed, 5 Jan 2011 23:20:12 +0000 (23:20 +0000)]
Move pass/fail message out of doEnvironmentChecks(), return a Status and let callers do it instead. Also moves the <span> out of the message.
Happy-melon [Wed, 5 Jan 2011 23:08:13 +0000 (23:08 +0000)]
Documentation format
Platonides [Wed, 5 Jan 2011 22:44:56 +0000 (22:44 +0000)]
Failing test for bug 11748
Chad Horohoe [Wed, 5 Jan 2011 22:37:14 +0000 (22:37 +0000)]
* Validate e-mail address if provided
* Actually setEmail() on the sysop account we're creating
* Reinstate "subscribe to mediawiki-announce" feature (reverts r79089) which actually works
Sam Reed [Wed, 5 Jan 2011 22:11:39 +0000 (22:11 +0000)]
* (bug 26480) add a pppageprops param to prop=pageprops
Sam Reed [Wed, 5 Jan 2011 21:59:05 +0000 (21:59 +0000)]
Minor code order tweaks in ApiQueryPageProps.
Remove getPossibleErrors, as it adds an error that this module doesn't through
Sam Reed [Wed, 5 Jan 2011 21:51:12 +0000 (21:51 +0000)]
* (bug 26484) add a lltitles param to prop=langlinks
Raimond Spekking [Wed, 5 Jan 2011 21:32:10 +0000 (21:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-05 21:11:00 UTC)
Sam Reed [Wed, 5 Jan 2011 21:28:18 +0000 (21:28 +0000)]
* (bug 26483) add a iwtitles param to prop=iwlinks
Happy-melon [Wed, 5 Jan 2011 21:25:04 +0000 (21:25 +0000)]
Add IDs to various revdel notices for skinning.
Bryan Tong Minh [Wed, 5 Jan 2011 19:58:09 +0000 (19:58 +0000)]
Follow-up r79655: array_diff makes in_array unnecessary
Sam Reed [Wed, 5 Jan 2011 19:45:19 +0000 (19:45 +0000)]
* (bug 26485) add a elextlinks param to prop=extlinks
Refactored some code out of ApiQueryExtLinksUsage
Had to duplicate some code into ApiQueryExternalLinks (Boo). Marked with a TODO to fix it up
Platonides [Wed, 5 Jan 2011 19:35:58 +0000 (19:35 +0000)]
Follow up r79532. Do not setup a user needlessly.
Sam Reed [Wed, 5 Jan 2011 19:28:00 +0000 (19:28 +0000)]
Refactor out protocol preperation to ApiQueryExtLinksUsage::prepareProtocols()
Bryan Tong Minh [Wed, 5 Jan 2011 19:17:36 +0000 (19:17 +0000)]
(bug 26574) Added 'upload' to $wgRestrictionTypes, allowing upload protected pages to be queried via the API and Special:ProtectedPages, and allowing disabling upload protection by removing it from $wgRestrictionTypes.
Sam Reed [Wed, 5 Jan 2011 17:57:12 +0000 (17:57 +0000)]
Followup r79638
If we're ping limited, add a warning as such, and don't bother trying to linkupdate any of the other articles in the output.
Philip Tzou [Wed, 5 Jan 2011 16:44:11 +0000 (16:44 +0000)]
follow r78679, correct the comment line
Alexandre Emsenhuber [Wed, 5 Jan 2011 16:42:32 +0000 (16:42 +0000)]
Bump version
Philip Tzou [Wed, 5 Jan 2011 16:37:36 +0000 (16:37 +0000)]
Follow r79649 and r79650. Errrr, remove the redundant minus
Philip Tzou [Wed, 5 Jan 2011 16:30:10 +0000 (16:30 +0000)]
follow r79649, move the in-block assignment outside.
Philip Tzou [Wed, 5 Jan 2011 16:21:01 +0000 (16:21 +0000)]
Add fallback languages support for ApiOpenSearch.
Alexandre Emsenhuber [Wed, 5 Jan 2011 15:50:34 +0000 (15:50 +0000)]
Easier method (and to check existence in correct language)
Chad Horohoe [Wed, 5 Jan 2011 13:43:13 +0000 (13:43 +0000)]
Followup r73348, r70608: move 'infinity' stuff to DB classes
Chad Horohoe [Wed, 5 Jan 2011 13:20:39 +0000 (13:20 +0000)]
Followup r68129: rename UndeleteForm to SpecialUndelete per CR. Not used in any extensions
Alexandre Emsenhuber [Wed, 5 Jan 2011 12:24:39 +0000 (12:24 +0000)]
Allow OutputPage::parse() to parse in any langauge, modified wfMsgExt() and wfMessage() accordingly
Krinkle [Wed, 5 Jan 2011 12:21:26 +0000 (12:21 +0000)]
Removing Makefile from /skins/common (only used for minifiying jquery, which isn't in here anymore).
* jquery.js removed in r65962
* jquery.min.js removed in r72349
Follow-up: r61557, r61558, r65962, r66270, r72349.
Daniel Friesen [Wed, 5 Jan 2011 06:16:13 +0000 (06:16 +0000)]
Allow filenames to be specified in a <gallery> with the File:, Image: or media: omitted by defaulting to NS_FILE.
Sam Reed [Wed, 5 Jan 2011 03:31:51 +0000 (03:31 +0000)]
* (bug 26498) allow LinksUpdate with API
Original patch by Umherirrender. Tweaked to take account of User->pingLimiter() (ie only update links if not limited)
Possible TODO: Error if we are limited? $this->dieUsageMsg( array( 'actionthrottledtext' ) ); seems a bit harsh
Maybe just have a linkupdate="$this->parseMsg( array( 'actionthrottledtext' ) )" in the result? Or something. Definately notification of error to some respect is needed. Just dieing and stopping the whole process is OTT?
Sam Reed [Wed, 5 Jan 2011 02:52:04 +0000 (02:52 +0000)]
* (bug 26482) add a imimages param to prop=images
Sam Reed [Tue, 4 Jan 2011 23:59:39 +0000 (23:59 +0000)]
* (bug 26460) Add support for listing category members by category pageid
Ilmari Karonen [Tue, 4 Jan 2011 22:05:40 +0000 (22:05 +0000)]
Update math_image_error message, texvc has been using svipng by default since r16460.
Sam Reed [Tue, 4 Jan 2011 21:37:18 +0000 (21:37 +0000)]
* (bug 25135) add "normalized" to action=parse
Mov addition of $oldid earlier
Raimond Spekking [Tue, 4 Jan 2011 21:15:16 +0000 (21:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-04 20:46:00 UTC)
Sam Reed [Tue, 4 Jan 2011 19:54:30 +0000 (19:54 +0000)]
Remove another setting of failFunction in phase3 in a database constructor
Sam Reed [Tue, 4 Jan 2011 19:33:13 +0000 (19:33 +0000)]
Simplest possible fix for *(bug 26552) ForeignDBRepo broken?
Going to see what other uses I can find of stuff constructing their own Database Instances...
Alexandre Emsenhuber [Tue, 4 Jan 2011 19:08:44 +0000 (19:08 +0000)]
Run preSaveTransform() with the user that did the edit, not unconditionally $wgUser
Alexandre Emsenhuber [Tue, 4 Jan 2011 15:02:54 +0000 (15:02 +0000)]
Use $this->mTitle instead of $wgArticle->getTitle()
Alexandre Emsenhuber [Tue, 4 Jan 2011 14:49:08 +0000 (14:49 +0000)]
Use isArticleRelated() instead of checking if $wgArticle is set
Roan Kattouw [Tue, 4 Jan 2011 14:28:31 +0000 (14:28 +0000)]
Remove two useless CSS rules that would cause one image to be embedded thrice
Roan Kattouw [Tue, 4 Jan 2011 14:25:35 +0000 (14:25 +0000)]
Add /* @embed */ comments for URLs in all RL-ified CSS files, except in jQuery UI's default theme. This'll reduce the number of images loaded, especially for jQuery UI.
Alexandre Emsenhuber [Tue, 4 Jan 2011 13:23:18 +0000 (13:23 +0000)]
svn:eol-style native
Roan Kattouw [Tue, 4 Jan 2011 12:58:15 +0000 (12:58 +0000)]
Fix jQuery UI dialog CSS for close-x.png -> close.png rename in Vector theme
X! [Tue, 4 Jan 2011 11:58:17 +0000 (11:58 +0000)]
Fix r79532: Strct standards
Platonides [Tue, 4 Jan 2011 11:31:06 +0000 (11:31 +0000)]
Partial revert of r79520, follow up to r79558. Unconditionally use the new format.
For environments post r70783, they will need to rerender pages with __NOEDITSECTION__ or no headings (hopefully those will be simple pages).
There will be no extra parser cache misses for environments pre r70783.
Rotem Liss [Tue, 4 Jan 2011 09:40:33 +0000 (09:40 +0000)]
Localization update for he.
Tim Starling [Tue, 4 Jan 2011 06:12:33 +0000 (06:12 +0000)]
Fix for bug 26561: clickjacking attacks. See the bug report for full documentation.
Daniel Friesen [Tue, 4 Jan 2011 04:23:01 +0000 (04:23 +0000)]
*sigh* I was looking at parser tests, but not notices in a site this time... Followup r79558 fix a small php notice.
Daniel Friesen [Tue, 4 Jan 2011 04:20:09 +0000 (04:20 +0000)]
Followup r79520 and r79528, one of the args was missing when calling doEditSectionLink. Additionally the LanguageConverter was screwing up editsection markers really badly. Switched to <editsection> pesudo-xml style markers for best compatibility with the language converter. (tags are already escaped so we don't need to worry about similar user input)
Sam Reed [Tue, 4 Jan 2011 04:05:32 +0000 (04:05 +0000)]
* (bug 26560) On allusers if limit < total number of users, last user gets duplicate
If $lastUserData is set to null, it won't get added again!
Sam Reed [Tue, 4 Jan 2011 03:36:39 +0000 (03:36 +0000)]
* (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights
X! [Tue, 4 Jan 2011 03:22:40 +0000 (03:22 +0000)]
Add API query test
Sam Reed [Tue, 4 Jan 2011 02:48:02 +0000 (02:48 +0000)]
* (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of
Sam Reed [Tue, 4 Jan 2011 02:18:03 +0000 (02:18 +0000)]
Followup r79545, we don't really care for duplicate userrights
Sam Reed [Tue, 4 Jan 2011 02:13:51 +0000 (02:13 +0000)]
Add rights to array. Grrr
Sam Reed [Tue, 4 Jan 2011 02:08:38 +0000 (02:08 +0000)]
Crappy spaces from r79549
Sam Reed [Tue, 4 Jan 2011 02:06:55 +0000 (02:06 +0000)]
Rest of * (bug 25767) Add userrights properties to allusers and users query lists
Add missing parameter from r79545
X! [Tue, 4 Jan 2011 01:51:48 +0000 (01:51 +0000)]
Forcing array breaks MWFunction with <2 parameters
X! [Tue, 4 Jan 2011 01:44:11 +0000 (01:44 +0000)]
Fix r79494: Don't prefix functions now that they're in their own class
Sam Reed [Tue, 4 Jan 2011 01:39:02 +0000 (01:39 +0000)]
* (bug 25767) Add userrights properties to allusers and users query lists
First part of this bug. Listing of all rights that users have
X! [Tue, 4 Jan 2011 01:35:01 +0000 (01:35 +0000)]
Followup to r79532: Did I really need to implement a parameter? No, I did not.
X! [Tue, 4 Jan 2011 01:33:57 +0000 (01:33 +0000)]
Update to use the PHPUnit autoloader, define $IP
Chad Horohoe [Tue, 4 Jan 2011 00:42:48 +0000 (00:42 +0000)]
Remove nasty ancient global $title (at least $wgTitle is easier to grep for), its no longer set since r78512. Afaict, this generic-named global is no longer in core.
It's not a title object, it's a string of what title= in the URL. If you want that, use WebRequest::getText() or something. Using this string is *wrong* and any extensions should be fixed (I didn't check because $title is a PITA to grep for). Don't backport to 1.17 because this is trivial, harmless, and may Break Something.
(Also made fileCachedPage private since it has no outside callers and I can't see any reason why you should)
Chad Horohoe [Mon, 3 Jan 2011 23:56:49 +0000 (23:56 +0000)]
Add new addExtensionTable() wrapper for adding new tables for extensions: way easier than remembering array syntax for addExtensionUpdate()
Ilmari Karonen [Mon, 3 Jan 2011 23:20:13 +0000 (23:20 +0000)]
make action=parse return a missingtitle error if the page param refers to a missing (rather than just invalid) title
X! [Mon, 3 Jan 2011 21:36:49 +0000 (21:36 +0000)]
Add API format testing
X! [Mon, 3 Jan 2011 21:14:51 +0000 (21:14 +0000)]
Add JSON test case
X! [Mon, 3 Jan 2011 21:14:22 +0000 (21:14 +0000)]
Followup r79523: Test that calling self:: and parent:: throws exception
Daniel Friesen [Mon, 3 Jan 2011 21:04:05 +0000 (21:04 +0000)]
Followup r79520, some characters inside the encoded data were being modified by the parser causing it to break. Switching to a encoding scheme without that issue and adding a test to throw a less fatal error.
Raimond Spekking [Mon, 3 Jan 2011 20:52:23 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-03 20:25:00 UTC)
Sam Reed [Mon, 3 Jan 2011 20:41:22 +0000 (20:41 +0000)]
Move comment about groups potentially returning less results from server.
Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)
Ilmari Karonen [Mon, 3 Jan 2011 20:32:04 +0000 (20:32 +0000)]
merge the nearly identical Title::moveToNewTitle() and Title::moveOverExistingRedirect() to a single Title::moveToInternal() method
X! [Mon, 3 Jan 2011 20:19:51 +0000 (20:19 +0000)]
Throw an exception if calling parent or self on MWFunction.
Daniel Friesen [Mon, 3 Jan 2011 20:17:20 +0000 (20:17 +0000)]
Try to output editsection markers instead of rendered editsection links and defer the rendering to a point where the markup does not need to be stored in the cache.
Doing this allows skins to override doEditSectionLinks without poluting the parser cache or fragmenting the parser cache more.
As a side effect it eliminates the primary cause of user language based parser cache fragmentation.
Because this makes most old parser cache entries invalid $wgUseEditSectionTokens is provided so that large installations like Wikipedia can keep their old parser cache entries.
X! [Mon, 3 Jan 2011 19:55:44 +0000 (19:55 +0000)]
Run is_callable, just to make sure the autoloader gets called.
Alexandre Emsenhuber [Mon, 3 Jan 2011 19:50:01 +0000 (19:50 +0000)]
* Modified Article::loadPageData() to use a slave database connection and pageDataFromTitle() instead of pageDataFromId() in the default case, as in Wiki.php (this also saves a query since the ID will be fetched with other fileds)
* Removed the loadPageData() call for the initial article in Wiki.php, will be triggered by the isRedirect() call 7 lines below if needed (this was not needed if $target is set by the InitializeArticleMaybeRedirect hook), but kept the second one (same as above, Article::exists() triggers Title::getArticleId() that would use one query to get id and a second one is needed to get the complete page data)
* Modified Article::fetchContent() to use common code (loadPageData()) and to only call it if really needed
Alexandre Emsenhuber [Mon, 3 Jan 2011 18:15:44 +0000 (18:15 +0000)]
Just call loadPageData() if not already done to get the $mIsRedirect flag in Article::isRedirect() instead of doing a lot of useless stuff
Alexandre Emsenhuber [Mon, 3 Jan 2011 17:12:27 +0000 (17:12 +0000)]
no need to set $this->mOldId, this is already done in getOldID()
nadeesha [Mon, 3 Jan 2011 09:18:21 +0000 (09:18 +0000)]
Change the xpath of the 'You can now Folder/index.php start using your wiki' text.
nadeesha [Mon, 3 Jan 2011 09:07:55 +0000 (09:07 +0000)]
Changed 'enter your wiki' link, environment ok text and remove 'Subscribe to the release announcements mailing list' check box verification section
nadeesha [Mon, 3 Jan 2011 09:06:53 +0000 (09:06 +0000)]
Change the xpath of the 'Upgrade complete' text
nadeesha [Mon, 3 Jan 2011 09:05:58 +0000 (09:05 +0000)]
Remove verification for help field hint for 'Subscribe to the release announcements mailing list' as per the code review comment(MediaWiki r79089)
nadeesha [Mon, 3 Jan 2011 09:05:18 +0000 (09:05 +0000)]
Remove testOnlyBackButtonAvailability() function as per the code review comment (MediaWiki r78165 )
Sam Reed [Mon, 3 Jan 2011 03:40:26 +0000 (03:40 +0000)]
Remove unreachable return;
Add missing global $IP;
X! [Mon, 3 Jan 2011 02:49:52 +0000 (02:49 +0000)]
Mark broken parser tests as broken