jenkins-bot [Tue, 30 Jan 2018 19:44:06 +0000 (19:44 +0000)]
Merge "postEdit: Show a different success messsage on publish vs. save wikis"
jenkins-bot [Tue, 30 Jan 2018 19:35:13 +0000 (19:35 +0000)]
Merge "objectcache: add some WANObjectCache comments to set() and delete()"
James D. Forrester [Tue, 18 Apr 2017 15:59:08 +0000 (08:59 -0700)]
postEdit: Show a different success messsage on publish vs. save wikis
Bug: T183901
Change-Id: I065f733bd8b27bda68023cd1b718e257fd135aa2
Bartosz Dziewoński [Tue, 30 Jan 2018 11:12:46 +0000 (12:12 +0100)]
resourceloader: Move FILTER_NOMIN annotation to the beginning of output
This allows ResourceLoader::filter() to handle this case slightly
faster, since it searches for this annotation from the beginning.
In practice this is a negligible performance optimization, but let's
set a good example for the future.
Also tweak the comments and whitespace:
* Move comment about the FILTER_NOMIN from doc comment to code comment,
it's an implementation detail and not meant for public documentation
* Remove duplicated documentation from the parent class
* Change whitespace to be identical in both cases
Change-Id: I624914ff28d903027ba58710708ccc3c66af9e24
jenkins-bot [Tue, 30 Jan 2018 17:43:13 +0000 (17:43 +0000)]
Merge "SpecialExpandTemplates: Remove leftover 'mw-ui-input-inline' class"
jenkins-bot [Tue, 30 Jan 2018 16:24:55 +0000 (16:24 +0000)]
Merge "Remove unused method parameters from TestBagOStuff"
Thiemo Mättig [Wed, 10 Jan 2018 13:32:56 +0000 (14:32 +0100)]
Remove unused method parameters from TestBagOStuff
This is a test mock exclusively used in tests. All code I'm removing here
is unused and neither needed nor covered by any test.
Change-Id: Ifd010c49973460f6fbb2cd83f8fd63488f5fd291
Bartosz Dziewoński [Tue, 30 Jan 2018 14:29:44 +0000 (15:29 +0100)]
SpecialExpandTemplates: Remove leftover 'mw-ui-input-inline' class
mediawiki.ui is not loaded on this page anymore after the OOUI
conversion. However, if some extension etc. were to load it, this
field (page title) would have the styles applies unexpectedly,
and it looks rather silly with them (very narrow).
Change-Id: I5cfe71897f435a514c6971b3a0ff7521e422324c
Bartosz Dziewoński [Tue, 30 Jan 2018 09:26:15 +0000 (10:26 +0100)]
jquery.textSelection: Remove outdated FIXME comments
These are from 2010 or earlier; they blame to
32377424b94 / rSVN72349,
which is a huge SVN branch merge and I'm not going to dig past that.
To be honest I don't really understand them (perhaps some context has
been lost over the years), but their main point is "we may not need
these functions", to which I say we definitely need them because
they've been a public API for over 7 years now.
Change-Id: I43a5453003e8d64d00323eb973629a96b6b386ab
jenkins-bot [Tue, 30 Jan 2018 05:55:38 +0000 (05:55 +0000)]
Merge "Remove workaround for comparing database domain IDs."
daniel [Tue, 30 Jan 2018 03:43:11 +0000 (19:43 -0800)]
Remove workaround for comparing database domain IDs.
Change-Id: I240d68eddec871794ed98b7ce67773114ee73ff7
jenkins-bot [Tue, 30 Jan 2018 02:21:49 +0000 (02:21 +0000)]
Merge "cleanupTitles: Don't add 'Broken/' prefix if the title is valid without it"
jenkins-bot [Tue, 30 Jan 2018 02:16:28 +0000 (02:16 +0000)]
Merge "Use ::class to resolve class names in includes files"
jenkins-bot [Tue, 30 Jan 2018 02:09:02 +0000 (02:09 +0000)]
Merge ".mailmap: Fix my name to use the form used elsewhere"
jenkins-bot [Tue, 30 Jan 2018 01:57:26 +0000 (01:57 +0000)]
Merge "Make DatabaseMysqlBase::insertSelect() safer to use"
jenkins-bot [Tue, 30 Jan 2018 01:57:21 +0000 (01:57 +0000)]
Merge "Hide link to ApiSandbox in ApiSandbox"
Aaron Schulz [Tue, 30 Jan 2018 01:29:20 +0000 (17:29 -0800)]
objectcache: add some WANObjectCache comments to set() and delete()
Change-Id: I527f1244c5c7cece888ace25e7a01653cf2b9542
Timo Tijhof [Mon, 29 Jan 2018 23:14:19 +0000 (15:14 -0800)]
resourceloader: Disable minify for embedded 'user.options' module
Follows-up
6fa489392815 (T84960), which disabled minification
for 'user.tokens'.
In 2014 'user.tokens' module was changed to change tokens on every page view,
even for the same user within a short period of time. This led to a huge
minify-cache growth, and we subsequently disabled caching for its minification
result.
Since then, we have also done:
* Disable minification for 'user.tokens' more generally, given
that it's just a simple JSON blob and we already pass down the 'debug' mode
flag down to the creation of that blob, so there's virtually nothing to left
to minify.
* Disable minification for mw.config.set(). Config values are exported by
ResourceLoaderClientHtml and not part of any module. Given that since 2015
we minify per-module and not per-response (
b7eb243d92) that means config
data naturally doesn't go through minification, which is good, because
just like for 'user.tokens', the config data is JSON which is already created
without whitespace. Minification would be pointless.
However, 'user.options' is still being minified and cached, and makes up about
25% of the 'resourceloader:minify-js.*' keys in APC on Wikimedia servers.
Unlike 'user.tokens', the minify cache for 'user.options' does actually get
used by subsequent page views from the same user (unless preferences changed).
However, it isn't useful because it's plain JSON and already compressed enough.
Besides, the blob is so small that it's not worth the overhead of cache-checking.
If we would want to minify it, I'd recommend we re-minify each view without cache.
Change-Id: Ic0ffb0e23df9b40e2c1283c89bd876a5c0555951
jenkins-bot [Mon, 29 Jan 2018 20:55:23 +0000 (20:55 +0000)]
Merge "Revert "selenium: add new message banner test to user spec""
Translation updater bot [Mon, 29 Jan 2018 20:54:35 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia30ac7ea1fbab5248058c09f793c583f73dc27c7
Jdlrobson [Mon, 29 Jan 2018 19:47:07 +0000 (19:47 +0000)]
Revert "selenium: add new message banner test to user spec"
This reverts commit
6ca3e221d1b907f55462394f910f283bb3627cc9.
This is breaking CI for the Minerva skin and Echo as Echo changes how
this interaction works. When the browser test tries to locate the
div.usermessage it has moved so fails.
This test needs to be rewritten to take this into account.
On a side note, given usermessage is generated by all skins (and not
in core) there is a big argument to be made that this shouldn't be in
core but in the individual skins. MinervaNeue the mobile skin notably
does not use this class so this test would always fail on a mediawiki
instance which only uses the Minerva skin.
Bug: T185928
Change-Id: I43b6cf328aaf4a4fded0bb9746716c4cc9d8f364
jenkins-bot [Mon, 29 Jan 2018 19:14:10 +0000 (19:14 +0000)]
Merge "benchmarks: Add benchmarkSanitizer.php"
jenkins-bot [Mon, 29 Jan 2018 19:14:07 +0000 (19:14 +0000)]
Merge "benchmarks: Add rate per second and standard deviation to output"
Stephane Bisson [Mon, 29 Jan 2018 16:59:55 +0000 (11:59 -0500)]
RCFilters: replace usages of deprecated getSelectedItem
Use findSelectedItem instead.
Change-Id: Id13a1a94a2808910f3a2f2e434551229016ac865
James D. Forrester [Mon, 29 Jan 2018 15:57:02 +0000 (07:57 -0800)]
.mailmap: Fix my name to use the form used elsewhere
Change-Id: I0468a185d19cade3f2c51947190111a66cccc129
jenkins-bot [Mon, 29 Jan 2018 15:31:43 +0000 (15:31 +0000)]
Merge "API: Allow to pass whitespaces in MultiValue"
Brad Jorsch [Mon, 29 Jan 2018 14:31:16 +0000 (09:31 -0500)]
Hide link to ApiSandbox in ApiSandbox
It's a bit redundant. Wrap the paragraph with the link in an appropriate
CSS class, and add a rule to mediawiki.special.apisandbox.css to hide it
when inside ApiSandbox.
Bug: T185855
Change-Id: I118e535420e3395268fe99aa0f69f2b032340d53
jenkins-bot [Mon, 29 Jan 2018 12:53:22 +0000 (12:53 +0000)]
Merge "benchmarks: Simplify benchmarkLruHash.php by using a --method option"
jenkins-bot [Mon, 29 Jan 2018 11:53:46 +0000 (11:53 +0000)]
Merge "selenium: add new message banner test to user spec"
Timo Tijhof [Sat, 27 Jan 2018 17:46:12 +0000 (09:46 -0800)]
benchmarks: Add benchmarkSanitizer.php
Covering the following common methods:
* validateEmail (input=valid, input=invalid)
* encodeAttribute (input=simple, input=special)
* safeEncodeAttribute (input=simple, input=special)
* removeHTMLtags (input=small, input=large)
* stripAllTags (input=small, input=large)
Change-Id: I3c645e960607ab247bd30324a2e70eb5fbcc5d6e
Timo Tijhof [Sun, 28 Jan 2018 21:46:32 +0000 (13:46 -0800)]
benchmarks: Add rate per second and standard deviation to output
* Convert to using RunningStat to ensure mostly constant memory
usage, instead of storing each result.
* Remove 'median' (no longer possible with this setup).
* Remove 'min' from output.
Change-Id: I6efbc500181eb502c1800165870eee81dbc418a7
Timo Tijhof [Sat, 27 Jan 2018 17:06:12 +0000 (09:06 -0800)]
benchmarks: Simplify benchmarkLruHash.php by using a --method option
Easier to extend.
Change-Id: Ib9c6b3d10caad7de138d8bafd2f0e6e9bbe6a8cc
Fomafix [Sun, 21 Jan 2018 20:58:59 +0000 (21:58 +0100)]
API: Allow to pass whitespaces in MultiValue
This allows to response with an invalidreason instead silently ignore
the parameter.
Example request: api.php?format=json&action=query&titles=%20
Response before this change:
{
"batchcomplete": ""
}
Response with this change:
{
"batchcomplete": "",
"query": {
"pages": {
"-1": {
"title": " ",
"invalidreason": "The requested page title is empty or contains only the name of a namespace.",
"invalid": ""
}
}
}
}
Bug: T185846
Change-Id: I6fdaf32792a0e6e37b08176f975c10607093351b
Zoranzoki21 [Sun, 28 Jan 2018 13:56:02 +0000 (13:56 +0000)]
Improve MediaWiki's lock file error message when uploading files
Bug: T181453
Change-Id: I1e78d5eadd19c5cf203b8f4bbc8ab6d533307a15
Alangi Derick [Fri, 19 Jan 2018 12:33:36 +0000 (13:33 +0100)]
Update CREDITS file to include new contributors
Ran the updateCredits.php script to include new contributors of
MW and its extensions into the CREDITS file after a while. Keeping
the contributor list updated is useful.
Change-Id: I491c35285b562e1792715b83c674b8f1173add77
Translation updater bot [Sat, 27 Jan 2018 21:04:00 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2839c3d3bdb2b229e2cb8226af32964cfc2669ab
Umherirrender [Sat, 13 Jan 2018 00:02:09 +0000 (01:02 +0100)]
Use ::class to resolve class names in includes files
This helps to find renamed or misspelled classes earlier.
Phan will check the class names
Change-Id: I07a925c2a9404b0865e8a8703864ded9d14aa769
jenkins-bot [Sat, 27 Jan 2018 13:20:47 +0000 (13:20 +0000)]
Merge "benchmarks: Improve readme and convert to Markdown"
addshore [Sat, 27 Jan 2018 00:57:13 +0000 (16:57 -0800)]
Remove deprecated PreparedEdit properties
The following properties of PreparedEdit were deprecated in
1.21 and have been removed:
* PreparedEdit->newText
* PreparedEdit->oldText
* PreparedEdit->pst
These have no use left in core or extensions.
Change-Id: Ic48c817aaf3fbb6d5f33678fcb4843180f0bc9fb
Timo Tijhof [Sat, 27 Jan 2018 00:31:54 +0000 (16:31 -0800)]
benchmarks: Improve readme and convert to Markdown
* Add sections.
* Rename to *.md.
* Document that taskset is Linux-specific.
Change-Id: If6c5e54eda4dd1d6ea02445efa73e356dbc49016
Umherirrender [Fri, 12 Jan 2018 21:03:53 +0000 (22:03 +0100)]
Remove "Created on" from file header comments
It is the job of git and svn to provide this information/metadata.
The form was different, some with short, some with long month name
some with leading zero at the day, some without.
The year is also present in the Copyright clause
Change-Id: If006907b82b9e45f13cfa2e45d41107a95570e1a
Umherirrender [Sat, 13 Jan 2018 00:02:09 +0000 (01:02 +0100)]
Use ::class to resolve class names in tests
This helps to find renamed or misspelled classes earlier.
Phan will check the class names
Change-Id: Ie541a7baae10ab6f5c13f95ac2ff6598b8f8950c
Translation updater bot [Fri, 26 Jan 2018 21:15:50 +0000 (22:15 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3c040bc4add0a8c325afa5d8403e8ce3f5842060
jenkins-bot [Fri, 26 Jan 2018 19:38:07 +0000 (19:38 +0000)]
Merge "rdbms: Simplify Database::factory()"
jenkins-bot [Fri, 26 Jan 2018 18:17:55 +0000 (18:17 +0000)]
Merge "Gallery: Use Parser::parseWidthParam() for gallery dimensions"
jenkins-bot [Fri, 26 Jan 2018 18:01:45 +0000 (18:01 +0000)]
Merge "Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"""
jenkins-bot [Fri, 26 Jan 2018 17:49:40 +0000 (17:49 +0000)]
Merge "Improve 1-letter variable names in MutableContext and implementations"
Brad Jorsch [Fri, 26 Jan 2018 17:12:28 +0000 (09:12 -0800)]
Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox""
Instead of making a one-line fix to fix the issue in T149473, the change
was reverted.
This reverts commit
022f26e9fd3ae865331f3bb1b3eec63e212240c9.
This reverts commit
12f170502cfef525344ae69caef6240eaafbf63f.
Bug: T149473
Bug: T185638
Change-Id: Ib44ba2a6d2405309ad91bcc4d6440d05b67379da
Brad Jorsch [Fri, 26 Jan 2018 06:02:22 +0000 (22:02 -0800)]
Make DatabaseMysqlBase::insertSelect() safer to use
Certain server configurations, including the current MariaDB defaults,
make INSERT SELECT unsafe for replication in MySQL/MariaDB. When the
server configuration is not known to be safe, force the use of the
non-native implementation. Note this only has effect in CLI mode, as
non-CLI mode already forces the non-native implementation since
I2dba6024.
Also, native INSERT SELECT won't be safe with any statement-based
replication method if the order of rows in the SELECT is not
deterministic. Add a warning to the method's documentation pointing this
out.
Change-Id: I9173f6559809bd01830bd0a9f443c7269cc58ce2
jenkins-bot [Fri, 26 Jan 2018 14:12:46 +0000 (14:12 +0000)]
Merge "Don’t write to stderr when testing"
jenkins-bot [Fri, 26 Jan 2018 10:58:17 +0000 (10:58 +0000)]
Merge "thumb.php: Set ENT_NOQUOTES for htmlspecialchars"
jenkins-bot [Fri, 26 Jan 2018 08:45:01 +0000 (08:45 +0000)]
Merge "Remove misleading comment for $wgLegalTitleChars"
Bartosz Dziewoński [Fri, 26 Jan 2018 08:28:35 +0000 (00:28 -0800)]
Remove misleading comment for $wgLegalTitleChars
This comment originates from rSVN1420 (
9d51f616), dated 2 July 2003,
where it was written as "ISO 8859-* don't allow 0x80-0x9F... But that
breaks interlanguage links at the moment". It was rephrased to the
current form in rSVN2621 (
840dee3a).
It is incorrect for two reasons:
* "Theoretically 0x80-0x9F of ISO 8859-1 should be disallowed..."
We cannot disallow 0x80-0x9F here; this config variable actually
specifies the valid ranges of *bytes* rather than characters, and
0x80 to 0x9F can happily appear in valid UTF-8 encodings of other
characters.
In case we wanted to disallow the Unicode characters U+0080 to U+009F
(encoded in UTF-8 as 0xC2 0x80 to 0xC2 0x9F), it would probably have
to be done explicitly in MediaWikiTitleCodec::splitTitleString().
(The task for this is T7732.)
* "...but this breaks interlanguage links"
Back then, most wikis were using single-byte ISO encodings rather
than UTF-8, and that is the only configuration this comment applies
to: disallowing the bytes 0x80-0x9F in page titles on wikis using
single-byte ISO encodings would indeed have broken interlanguage
links from them to wikis using UTF-8. However, disallowing the
Unicode characters U+0080 to U+009F today definitely would not break
interlanguage links.
Change-Id: Ic5ba502ccfbb9cf3ff56cc47eb7fe463e7d45959
jenkins-bot [Fri, 26 Jan 2018 06:54:37 +0000 (06:54 +0000)]
Merge "Convert the sha1 value from base-36 to base-16"
Bartosz Dziewoński [Fri, 26 Jan 2018 03:17:01 +0000 (19:17 -0800)]
cleanupTitles: Don't add 'Broken/' prefix if the title is valid without it
In some cases, e.g. changes in Unicode normalization rules or
MediaWiki banning some invisible characters that were previously
allowed in titles, it's enough to just run the title through
normalization and update the database entry.
Change-Id: I786f31510bbd58c2ec02fc91918de5241c9050d6
Prateek Saxena [Sun, 19 Jun 2016 06:41:43 +0000 (12:11 +0530)]
Gallery: Use Parser::parseWidthParam() for gallery dimensions
Used by the `setWidths` and `setHeights` methods to make sure we are
using correct values.
Makes `parseWidthParam` static to be used in the gallery class.
Bug: T129372
Change-Id: I38b9ef0ea26e3748ad5d5458fadd2545f677ef93
Translation updater bot [Thu, 25 Jan 2018 20:54:23 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I10962812b862c1949ee0d196d6d70fd1c33445d1
jenkins-bot [Thu, 25 Jan 2018 20:48:44 +0000 (20:48 +0000)]
Merge "SpecialPage: Fix typo in comment"
Bartosz Dziewoński [Thu, 25 Jan 2018 20:38:51 +0000 (12:38 -0800)]
SpecialPage: Fix typo in comment
Change-Id: I03f30b978e5dc7736d24873a04e91f5bb0171a86
RazeSoldier [Thu, 25 Jan 2018 04:58:06 +0000 (12:58 +0800)]
Convert the sha1 value from base-36 to base-16
Convert the sha1 value displayed on the file info page from base-36 to
base-16
Bug: T181651
Change-Id: I39d6d5d68973c9e67959b2bbbe77937f4ccca76a
Fomafix [Thu, 25 Jan 2018 18:30:55 +0000 (19:30 +0100)]
LivePreview: Add uselang parameter to API diff request
Some elements like the line numbers of a diff depends on the user
interface language. This change ensures that the language of the user
interface is used of live preview diffs, too.
Bug: T185683
Change-Id: I438e19028700fb2d5bcd57d214e1134d656fb7b2
Timo Tijhof [Wed, 24 Jan 2018 19:33:37 +0000 (11:33 -0800)]
rdbms: Simplify Database::factory()
Follows-up
0ff2b7a776 (T120333) which removed support for the
deprecated php 'mysql' extension.
It surprised me that the 'DatabaseMysql' entry could safely be removed
from $classAliases. This was because the key is not direct input,
but based on $canonicalDBTypes, which maps mysql to mysqli.
Take this further by removing the indirection between type, driver
and class name.
* Map built-in db types directly to their class and driver.
* Change fallback to assign $class directly from $dbType, without
indirection of a $driver variable.
* Remove unused $classAliases.
Change-Id: I1200b07f66f23624410d848b6f382cb2dafa5c59
jenkins-bot [Thu, 25 Jan 2018 17:01:54 +0000 (17:01 +0000)]
Merge "Remove very, very old disabled test cases and todos"
jenkins-bot [Thu, 25 Jan 2018 10:34:02 +0000 (10:34 +0000)]
Merge "widget: Fix changes of copyright year"
jenkins-bot [Wed, 24 Jan 2018 22:55:50 +0000 (22:55 +0000)]
Merge "Load preferences js/css in mobile"
jenkins-bot [Wed, 24 Jan 2018 22:51:44 +0000 (22:51 +0000)]
Merge "Use RevisionLookup and RevisionFactory interfaces in Revision"
addshore [Tue, 9 Jan 2018 08:53:38 +0000 (08:53 +0000)]
Use RevisionLookup and RevisionFactory interfaces in Revision
Lets not depend on the big blob that is RevisionStore.
Try to bind to the nice interfaces that we have where possible.
In the future RevisionStore should be split up further into
it's individual interfaces.
It looks like there are some more methods which should be moved
to both RevisionLookup and RevisionFactory.
See draft:
I214c5952d4a0fad55ff4116e90eab9ac3ba54fd3
Change-Id: I8df61374e24abcf4a7e38e53647489b8ecc1fd77
addshore [Thu, 11 Jan 2018 20:55:37 +0000 (20:55 +0000)]
Extra tests for SqlBlobStore with 'windows-1252' legacy encoding
Bug: T184749
Change-Id: Ida717dbe6ae742b3b61f0f09dc60712307c53a96
addshore [Sat, 13 Jan 2018 14:25:09 +0000 (14:25 +0000)]
selenium: add new message banner test to user spec
Change-Id: I92dc612d215d1d3eb8dff02c2ff4d57da0105d69
Translation updater bot [Wed, 24 Jan 2018 20:55:30 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I31c3b81ae100f17d7fecb607b2a0a1ab4a9b60b1
Kunal Mehta [Wed, 24 Jan 2018 19:59:05 +0000 (11:59 -0800)]
widget: Fix changes of copyright year
Fixes up
e8b10f68049c19a.
Change-Id: I474e508a2bd4d783272eda87c1cc91f5597bc1b1
jenkins-bot [Wed, 24 Jan 2018 19:14:56 +0000 (19:14 +0000)]
Merge "Simplify documentation headers of includes/widgets/…Widget.php files"
jdlrobson [Wed, 24 Jan 2018 18:54:05 +0000 (10:54 -0800)]
Load preferences js/css in mobile
Change-Id: Idbf62486c787179ee67deb22e4644f4fc742d9db
jenkins-bot [Wed, 24 Jan 2018 18:53:19 +0000 (18:53 +0000)]
Merge "poolcounter: Fix type hint for PoolWorkArticleView::getParserOutput"
Thiemo Mättig [Wed, 24 Jan 2018 14:22:12 +0000 (15:22 +0100)]
poolcounter: Fix type hint for PoolWorkArticleView::getParserOutput
Change-Id: Ib6a71e198481cf2a0230b3f8721c019ef3c7288c
jenkins-bot [Wed, 24 Jan 2018 16:25:52 +0000 (16:25 +0000)]
Merge "Fix called function case in a bunch of places"
jenkins-bot [Wed, 24 Jan 2018 15:24:57 +0000 (15:24 +0000)]
Merge "Set $_SERVER['SERVER_NAME'] to the value set by --server"
Lucas Werkmeister [Wed, 24 Jan 2018 13:29:23 +0000 (14:29 +0100)]
Don’t write to stderr when testing
This change makes it possible to test error() messages with
expectOutputString() or expectOutputRegex().
Change-Id: I61970403f9c371d3798f34fd48c70bc72f0c7eda
Lucas Werkmeister [Wed, 24 Jan 2018 13:28:39 +0000 (14:28 +0100)]
Add missing Maintenance import
Without this import, the @var Maintenance comment on $maintenance
doesn’t refer to the right class.
Change-Id: I2b5efa422f3e9d50f2132658b04ea2814af61954
jenkins-bot [Tue, 23 Jan 2018 23:01:34 +0000 (23:01 +0000)]
Merge "Add a hook into LanguageConverter#getPreferredVariant() to allow extensions to pull the desired variant from cookies (or other such source)"
jenkins-bot [Tue, 23 Jan 2018 22:43:10 +0000 (22:43 +0000)]
Merge "Phan: resolve and reenable PhanAccessMethodProtected"
jenkins-bot [Tue, 23 Jan 2018 20:58:50 +0000 (20:58 +0000)]
Merge "Remove dot from summary used by fixDoubleRedirects.php"
Translation updater bot [Tue, 23 Jan 2018 20:55:21 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaa76ffaa796a221bb23a3aa411634744726285cc
jenkins-bot [Tue, 23 Jan 2018 19:49:25 +0000 (19:49 +0000)]
Merge "Create factory for MWHttpRequest"
Stanislav Malyshev [Tue, 16 Jan 2018 23:11:08 +0000 (15:11 -0800)]
Create factory for MWHttpRequest
This will allow classes that need MWHttpRequest to inject HttpRequestFactory
and thus make it overridable and testable.
Also made MWHttpRequest abstract class since it doesn't implement
execute anyway. Maybe a good idea to move execute to an abstract
method?
Change-Id: I5c0e035542ff5f791a21a95ed13bed4cea6906d0
Marius Hoch [Tue, 23 Jan 2018 18:44:28 +0000 (10:44 -0800)]
ExtensionRegistry: Properly detect if a global is already set
$foo = null; isset( $foo ); will yield false.
Sometimes we want to explicitly set a config to null, but ExtensionRegistry
is then overriding this variable with the default value.
This is no consistent with the old workflow:
require_once the extension and then override the setting with null.
Bug: T128661
Change-Id: I0654c9369a596e84591fcaa9643703e6b4ccf57e
jenkins-bot [Tue, 23 Jan 2018 18:42:29 +0000 (18:42 +0000)]
Merge "Add collation for Abkhaz (ab)"
MarcoAurelio [Tue, 23 Jan 2018 18:32:57 +0000 (19:32 +0100)]
Remove dot from summary used by fixDoubleRedirects.php
Bug: T185592
Change-Id: Iae6ab7787fcf8150f738cf361c545c796ce84f16
Umherirrender [Sat, 13 Jan 2018 00:02:09 +0000 (01:02 +0100)]
Use ::class to resolve class names in maintenance scripts
This helps to find renamed or misspelled classes earlier.
Phan will check the class names
Change-Id: I1d4567f47f93eb1436cb98558388e48d35258666
Max Semenik [Tue, 23 Jan 2018 17:31:13 +0000 (09:31 -0800)]
Phan: resolve and reenable PhanAccessMethodProtected
Change-Id: I2bd7c787012f4f54600f3289d9d0d725f87788bc
jenkins-bot [Tue, 23 Jan 2018 17:26:12 +0000 (17:26 +0000)]
Merge "rdbms: make LoadBalancer::waitForAll() better respect the timeout"
jenkins-bot [Tue, 23 Jan 2018 16:00:20 +0000 (16:00 +0000)]
Merge "Use getSize since SearchSuggestionSet does not implement Countable"
Brian Wolff [Sun, 17 Dec 2017 22:12:06 +0000 (22:12 +0000)]
Make Gender normalize usernames
This ensures that if GENDER is fed wfEscapeWikitext()'d version
of a username, it will normalize it.
See discussion on T182800.
Note, we do not need to worry about the case of a user named
"Project:*foo" as such namespace prefixes are illegal in
usernames.
Change-Id: Ic5a8fc76c28dca43ce8e334ef1874c2673433f00
jenkins-bot [Mon, 22 Jan 2018 21:03:03 +0000 (21:03 +0000)]
Merge "Use MediaWiki\restoreWarnings in deprecated wfRestoreWarnings"
Translation updater bot [Mon, 22 Jan 2018 20:55:34 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I89efc6e7a8f23ef71268502cda5542338ee892fe
jenkins-bot [Mon, 22 Jan 2018 20:35:26 +0000 (20:35 +0000)]
Merge "Widgets: Allow titles with name of Object.prototypes"
jenkins-bot [Mon, 22 Jan 2018 20:24:58 +0000 (20:24 +0000)]
Merge "mediawiki.special.upload: Use ES5 .forEach() instead of jQuery"
Stanislav Malyshev [Mon, 22 Jan 2018 20:13:34 +0000 (12:13 -0800)]
Use getSize since SearchSuggestionSet does not implement Countable
Bug: T184934
Change-Id: I39459352399e2023149b715b049084826df22935
Fomafix [Fri, 19 Jan 2018 10:16:19 +0000 (11:16 +0100)]
mediawiki.special.upload: Use ES5 .forEach() instead of jQuery
Replace
* $.each( array, function ( index, value ) { ... } ) by
array.forEach( function ( value ) { ... } )
Change-Id: I0574f130e93b53895e2c76363285084a6df05649
jenkins-bot [Mon, 22 Jan 2018 19:37:15 +0000 (19:37 +0000)]
Merge "Use native ES5 Array prototype methods instead of jQuery"