brendajerop [Wed, 13 Mar 2019 07:59:19 +0000 (10:59 +0300)]
Correct API documentation for action=parse&prop=headhtml
The documentation stated that action=parse&prop=headhtml gives the
<head> element of the page, yet it returns the doctype, opening <html>,
<head> element, and opening <body> tag.
Bug: T139567
Change-Id: I864d53239c8f00a7e524d8ffb659f02dae957b03
Arlo Breault [Wed, 6 Mar 2019 21:49:07 +0000 (16:49 -0500)]
parser: closeParagraph already resets the lastSection
Change-Id: Ic24c9aa25852cc786a5ca438c2c1e9031f9e7c17
jenkins-bot [Wed, 13 Mar 2019 00:27:11 +0000 (00:27 +0000)]
Merge "Replace sorting classes with better naming convention"
Translation updater bot [Tue, 12 Mar 2019 21:09:11 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2887536cb78f5b4780550b67a2fde8aaf7530a97
jenkins-bot [Tue, 12 Mar 2019 17:55:18 +0000 (17:55 +0000)]
Merge "LogEntry: Restore logic to add change tags on udp-only publish"
Ottomata [Tue, 12 Mar 2019 17:23:12 +0000 (17:23 +0000)]
Merge "ApiMain.php api/request logging event changes"
jenkins-bot [Tue, 12 Mar 2019 16:35:00 +0000 (16:35 +0000)]
Merge "Add password policy setting `suggestChangeOnLogin`"
Andrew Otto [Fri, 8 Mar 2019 21:50:34 +0000 (16:50 -0500)]
ApiMain.php api/request logging event changes
- Use 'Z' UTC timezone on dt
- Don't provide empty arrays if no data entries
- No need to set X-Request-Id in http.request_headers, it is meta.request_id
Bug: T214080
Bug: T212529
Change-Id: I37aa41a46ce74b372070e88a2f4da746fcbe2449
Brad Jorsch [Tue, 12 Mar 2019 14:55:27 +0000 (10:55 -0400)]
LogEntry: Restore logic to add change tags on udp-only publish
This was unintentionally removed in I8df2fd98.
Bug: T218110
Change-Id: Ie8678b4207032d6eb877d596eb8f115798c80a1e
jenkins-bot [Tue, 12 Mar 2019 08:35:09 +0000 (08:35 +0000)]
Merge "Remove deprecated ParserOutput::legacyOptions"
jenkins-bot [Tue, 12 Mar 2019 07:33:57 +0000 (07:33 +0000)]
Merge "Improve documentation of the PageContentLanguage hook"
Volker E [Sat, 19 Jan 2019 02:24:21 +0000 (18:24 -0800)]
Replace sorting classes with better naming convention
Improving CSS structure by removing code duplications.
Bug: T214218
Change-Id: I0501e1ab934aef3af289fee618b99578a1f0285c
Niklas Laxström [Wed, 6 Mar 2019 12:23:06 +0000 (13:23 +0100)]
Improve documentation of the PageContentLanguage hook
Clarify that the type of second parameter that is being passed
to the hooks can be anything because one hook can change it and
then it is passed to another hook without the hook caller having
possibility to check or modify the value.
Clarify that hooks should only return Language objects.
Rename $wgLang to $userLang in the hook parameter documentation to
avoid false posivite matches for the global.
Fix some typos, use Title::inNamespace and add a test assertion.
Also, the $content parameter is unused by all implementations of
this method, and on quick look never passed by any caller. I kept
it for now, however.
Bug: T214358
Change-Id: Iae49d2998c2b762565d232c0337d84d43a4a900c
Aaron Schulz [Fri, 8 Mar 2019 22:31:01 +0000 (14:31 -0800)]
Remove deprecated ParserOutput::legacyOptions
Change-Id: I5f32dd741f3ee795ec599aacb687d5cee2c52835
jenkins-bot [Tue, 12 Mar 2019 04:25:50 +0000 (04:25 +0000)]
Merge "jobqueue: allow direct server configuration arrays to JobQueueDB"
jenkins-bot [Tue, 12 Mar 2019 04:22:19 +0000 (04:22 +0000)]
Merge "Add sanity check to notifyUpdatesForRevision() for $oldRev"
jenkins-bot [Tue, 12 Mar 2019 04:20:02 +0000 (04:20 +0000)]
Merge "resourceloader: Reword and expand doc comment about FileModule "packageFiles""
Aaron Schulz [Sun, 10 Mar 2019 19:56:34 +0000 (12:56 -0700)]
resourceloader: Reword and expand doc comment about FileModule "packageFiles"
Change-Id: Id9d68205504ecbddea6ca248e108f368fdcac2d2
jenkins-bot [Tue, 12 Mar 2019 02:14:39 +0000 (02:14 +0000)]
Merge "logging: Start using LinkTarget & UserIdentity in ManualLogEntry"
Translation updater bot [Mon, 11 Mar 2019 20:55:59 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I7ee423c084fbe33d4731e43ce5506f6a6f0c40be
jenkins-bot [Mon, 11 Mar 2019 20:28:07 +0000 (20:28 +0000)]
Merge "Fix the order of the parameters for htmlform-title-badnamespace"
jenkins-bot [Mon, 11 Mar 2019 20:27:59 +0000 (20:27 +0000)]
Merge "Bump minimum SQLite version to 3.8.0"
jenkins-bot [Mon, 11 Mar 2019 18:34:01 +0000 (18:34 +0000)]
Merge "Fix small typos"
jenkins-bot [Mon, 11 Mar 2019 18:30:56 +0000 (18:30 +0000)]
Merge "Linker: Use RequestContext::getMain()->getLanguage() instead of $wgLang"
Fomafix [Mon, 11 Mar 2019 16:50:46 +0000 (17:50 +0100)]
OutputPage: Use $this->getUser()
Use $this->getUser() instead of $this->getContext()->getUser().
ContextSource::getUser is a shortcut for $this->getContext()->getUser().
Change-Id: I7d19116b634500cd1a435bebe235c7562889f7bb
jenkins-bot [Mon, 11 Mar 2019 14:37:48 +0000 (14:37 +0000)]
Merge "Avoid using stale data for revision visibility and actor data"
jenkins-bot [Mon, 11 Mar 2019 12:39:04 +0000 (12:39 +0000)]
Merge "Streamline code involving .= string concatenations"
Thiemo Kreuz [Thu, 7 Mar 2019 09:55:31 +0000 (10:55 +0100)]
Streamline code involving .= string concatenations
This was inspired by Idbbdb31. Originally, I did a regex search for
code that did string concatenations like `$str = $str . …` and replaced
them all with the .= operator. A duplicate patch was uploaded by another
author. I rebeased this patch on top of the other, which leaves all
the manual optimizations I did.
Change-Id: Iaeb73d9c63302c9409bd1051b91e0d2bd77788a7
Max Semenik [Sat, 29 Sep 2018 02:44:45 +0000 (19:44 -0700)]
Bump minimum SQLite version to 3.8.0
3.3.7 is 12 years old, no chance in hell you will find it somewhere
that supports modern MediaWiki. Since Ubuntu 14.04 LTS has 3.8.2, this
seems like a reasonable conservative version.
Change-Id: I5fbb35bd2d4c0993889b79f463a3c35ce6765d3b
jenkins-bot [Sun, 10 Mar 2019 23:37:07 +0000 (23:37 +0000)]
Merge "ProtectionForm: Add type hint to ::showLogExtract() header"
Translation updater bot [Sun, 10 Mar 2019 20:56:09 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibf7f5a6cc435b330df709d40f8ea0687c65832c5
Bill Pirkle [Wed, 27 Feb 2019 21:26:17 +0000 (15:26 -0600)]
Avoid using stale data for revision visibility and actor data
Created class RevisionStoreCacheRecord to avoid returning stale
cached revision visibility and actor data when changes were
made after the cache was populated for that revision.
Bug: T216159
Change-Id: Iabed80e06a08ff0793dfe64db881cbcd535cb13f
jenkins-bot [Sun, 10 Mar 2019 20:14:52 +0000 (20:14 +0000)]
Merge "mediawiki.cookie: Export config via packageFiles"
Derick Alangi [Sun, 10 Mar 2019 18:12:48 +0000 (19:12 +0100)]
ProtectionForm: Add type hint to ::showLogExtract() header
https://codesearch.wmflabs.org/core/?q=showLogExtract%5C(&i=nope&files=&repos=
according to codesearch shows that this method takes as first argument an output
page object and also, objects are passed by reference by default so removed &.
Change-Id: I167ae6300b37d4e9292bd8ad14351f1ca35184d2
Max Semenik [Sun, 10 Mar 2019 08:08:44 +0000 (00:08 -0800)]
Remove a few method_exists() checks
These functions are present in every PHP version we support now.
Change-Id: I11add0fc9f6c3c3caff859db9c0475c4d2818577
jenkins-bot [Sun, 10 Mar 2019 05:33:59 +0000 (05:33 +0000)]
Merge "installer: Code augmentation in wfInstallerMain function"
jenkins-bot [Sun, 10 Mar 2019 03:34:17 +0000 (03:34 +0000)]
Merge "Add @var to class properties to clarify types"
jenkins-bot [Sun, 10 Mar 2019 03:25:36 +0000 (03:25 +0000)]
Merge "Move class HistoryPager to own file"
jenkins-bot [Sun, 10 Mar 2019 03:20:09 +0000 (03:20 +0000)]
Merge "Move class RangeDifference to own file"
jenkins-bot [Sun, 10 Mar 2019 03:15:24 +0000 (03:15 +0000)]
Merge "Remove suppress of PhanRedefineFunctionInternal"
Timo Tijhof [Sat, 9 Mar 2019 02:46:38 +0000 (02:46 +0000)]
mediawiki.cookie: Export config via packageFiles
* Add a private setDefaults() method to allow mocking from
unit tests.
* Use matching keys between the data export and the API.
* Reduce duplication in the code.
* Access the Sinon stub explicitly instead of via the public path.
* Remove use of the now-redundant QUnit.newMwEnvironment().
Change-Id: I600332cdb738f0b443549948b9f070f3ccfa12aa
jenkins-bot [Sat, 9 Mar 2019 23:56:19 +0000 (23:56 +0000)]
Merge "maintenance: Replace deprecated global $wgParser with getParser() service"
Derick Alangi [Sat, 9 Mar 2019 22:37:49 +0000 (23:37 +0100)]
maintenance: Replace deprecated global $wgParser with getParser() service
$wgParser is deprecated and using globals should also be avoid. So, replacing
the use of global $wgParser by a mediawiki service.
Change-Id: I34b61338e500567773249c71da0a7125cfd50d02
jenkins-bot [Sat, 9 Mar 2019 22:38:59 +0000 (22:38 +0000)]
Merge "installer: Remove redundant $key variable"
Timo Tijhof [Sat, 9 Mar 2019 22:15:20 +0000 (22:15 +0000)]
installer: Remove redundant $key variable
Change-Id: Ie6d59a1fd94ccfb2a3b5248f1f98ae640a4d5c2c
jenkins-bot [Sat, 9 Mar 2019 20:59:51 +0000 (20:59 +0000)]
Merge "NamespaceMultiselectWidget: Allow filtering by namespace ID or label"
Aaron Schulz [Sat, 9 Mar 2019 20:27:29 +0000 (12:27 -0800)]
Add sanity check to notifyUpdatesForRevision() for $oldRev
Change-Id: Ibd8975efb33d061ab16dc1a59899b6f78976ec5d
jenkins-bot [Sat, 9 Mar 2019 20:08:22 +0000 (20:08 +0000)]
Merge "Block: Explicit convert Message to string"
Dayllan Maza [Wed, 20 Feb 2019 06:02:33 +0000 (01:02 -0500)]
Add password policy setting `suggestChangeOnLogin`
Password policy checks that fail and have `suggestChangeOnLogin` set to true will
prompt for a password change on login.
Below are some rules that apply to this setting in different scenarios:
- If only one policy fails and has `suggestChangeOnLogin = false`, a password change will
not be requested
- If more than one policy fails and one or more have `suggestChangeOnLogin` set to true`,
a password change will be requested
- If `forceChange` is present in any of the failing policies, `suggestChangeOnLogin` value
will be ignored and password change will be enforced
- if $wgInvalidPasswordReset is set to false `suggestChangeOnLogin` is ignored
IMPORTANT**
Before this patch, suggesting a password change was the default behavior (depending on
$wgInvalidPasswordReset), which means that the necessary changes to $wgPasswordPolicy
need to be in place before this patch is merged and gets to production.
Bug: T211621
Change-Id: I7a4a0a06273fa4e8bd0da3dac54cf5a1b78bb3fd
Derick Alangi [Sat, 9 Mar 2019 13:22:30 +0000 (14:22 +0100)]
installer: Code augmentation in wfInstallerMain function
Cleanup null checks and string literals in wfInstallerMain function.
Change-Id: Ib117e05faf899b0c46820d337f1bd3ebd4272419
mainframe98 [Sat, 9 Mar 2019 16:00:26 +0000 (17:00 +0100)]
Fix the order of the parameters for htmlform-title-badnamespace
The name of the page is the first parameter, and the namespace is
the second parameter.
Change-Id: I738cdd920d0ce641837c5dc1da391602a15df794
Derick Alangi [Sat, 9 Mar 2019 13:29:03 +0000 (14:29 +0100)]
installer: Get WebRequest in mw-config via RequestContext
Change-Id: I535a91d09cc74ab08b782973a946dcf3fc3e6b46
Umherirrender [Sat, 9 Mar 2019 12:29:40 +0000 (12:29 +0000)]
Remove suppress of PhanRedefineFunctionInternal
There is no longer an override
Change-Id: Ie7c99228135689d20ab6ffb287c978642851f3ee
jenkins-bot [Sat, 9 Mar 2019 05:06:20 +0000 (05:06 +0000)]
Merge "mediawiki.cookie: Move file to its own directory"
jenkins-bot [Sat, 9 Mar 2019 03:43:48 +0000 (03:43 +0000)]
Merge "SVGMetadataExtractorTest: remove method existence test"
jenkins-bot [Sat, 9 Mar 2019 03:43:43 +0000 (03:43 +0000)]
Merge "Installer: Fix an obsolete comment"
jenkins-bot [Sat, 9 Mar 2019 03:42:21 +0000 (03:42 +0000)]
Merge "Remove $wgMediaInTargetLanguage"
Aaron Schulz [Sat, 9 Mar 2019 01:01:30 +0000 (17:01 -0800)]
jobqueue: allow direct server configuration arrays to JobQueueDB
This is useful for using a separate sqlite DB.
Change-Id: I6a7bb1d4bddedca34d68b0d8460c96c6ef5bbcf6
Max Semenik [Sat, 9 Mar 2019 03:12:49 +0000 (19:12 -0800)]
Installer: Fix an obsolete comment
Change-Id: I0ae459b016f491ff3bc2c702e55be29fdcfec5eb
Timo Tijhof [Sat, 9 Mar 2019 02:48:26 +0000 (02:48 +0000)]
mediawiki.cookie: Move file to its own directory
In preparation for using RL packageFiles functionality, and
to make sure git can track the file, which it seems to be unable
to otherwise.
Change-Id: I966718db2028a45c3dce1c2c10218e5137e23c7d
jenkins-bot [Sat, 9 Mar 2019 02:25:26 +0000 (02:25 +0000)]
Merge "Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason"
Aaron Schulz [Sat, 9 Mar 2019 01:36:21 +0000 (17:36 -0800)]
Make HTMLCacheUpdateJob avoid waiting on replication for no reason
Change-Id: Ica381dad0bdb0555add1c7925e0e48991e7e0964
Aaron Schulz [Sat, 9 Mar 2019 01:33:16 +0000 (17:33 -0800)]
Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason
Change-Id: I9ea4e4034ffc30a14b138279515447f990807e07
Max Semenik [Sat, 9 Mar 2019 01:48:55 +0000 (17:48 -0800)]
SVGMetadataExtractorTest: remove method existence test
It should be present in everything we support, as the earliest libxml
version would be 2.9.1 while >2.6.20 is required.
See https://3v4l.org/LdTIr
Change-Id: Ibc7152e9224ef8d5803d0e0ff8314cdf9eb8eac4
jenkins-bot [Sat, 9 Mar 2019 00:41:04 +0000 (00:41 +0000)]
Merge "Make addIdentifierQuotes part of IDatabase"
Brian Wolff [Sun, 17 Feb 2019 11:02:34 +0000 (11:02 +0000)]
Make addIdentifierQuotes part of IDatabase
This is so it can be used in places that typehint an IDatabase,
ultimately so that I can make phan-taint-check happy.
Bug: T216348
Change-Id: Iabf3e9a6add380322a12cdbb6a337bad690f1370
jenkins-bot [Sat, 9 Mar 2019 00:15:00 +0000 (00:15 +0000)]
Merge "objectcache: Use constant for $ttl param default in WANObjectCache::set()"
Andrew Green [Mon, 17 Oct 2016 15:21:08 +0000 (10:21 -0500)]
objectcache: Use constant for $ttl param default in WANObjectCache::set()
Change-Id: I3f936088cd63af4d535d7f46fe5619e8bb866999
jenkins-bot [Fri, 8 Mar 2019 23:37:14 +0000 (23:37 +0000)]
Merge "rdbms: optimize Database::selectDomain() to avoid extra queries"
jenkins-bot [Fri, 8 Mar 2019 23:37:08 +0000 (23:37 +0000)]
Merge "Remove `list-style-type` declaration from elements.css"
Max Semenik [Fri, 8 Mar 2019 23:23:10 +0000 (15:23 -0800)]
Remove $wgMediaInTargetLanguage
It's a temporary feature flag not included in any release, just
removing it outright. The functonality will now be always enabled.
Bug: T205040
Change-Id: Ia9da82e6f6b2d270f1790a99fc8c35ad5e6aee5e
jenkins-bot [Fri, 8 Mar 2019 23:12:31 +0000 (23:12 +0000)]
Merge "resourceloader: Omit default 'debug=false' from load.php urls"
jenkins-bot [Fri, 8 Mar 2019 23:12:26 +0000 (23:12 +0000)]
Merge "resourceloader: Separate context from extraQuery in ClientHtmlTest"
jenkins-bot [Fri, 8 Mar 2019 23:12:20 +0000 (23:12 +0000)]
Merge "ApiQueryLogEvents: Add IGNORE INDEX to avoid MariaDB optimizer bug"
jenkins-bot [Fri, 8 Mar 2019 23:05:29 +0000 (23:05 +0000)]
Merge "resourceloader: Replace ResourceLoaderDebug config use with context"
Umherirrender [Fri, 8 Mar 2019 22:29:14 +0000 (23:29 +0100)]
Move class RangeDifference to own file
Change-Id: I5262c7484017a0d920cc24297515d5946f614ee6
Volker E [Fri, 8 Mar 2019 22:24:53 +0000 (14:24 -0800)]
Remove `list-style-type` declaration from elements.css
This doesn't make any sense here, as
a) we should apply `disc` in alignment to Design Style Guide
b) it's overwritten anyways in both, Vector and MonoBook, with
different styles
Bug: T151100
Change-Id: Ied6810a78d8fbe5371838921cda468e6873d2e57
Aaron Schulz [Fri, 8 Mar 2019 22:04:54 +0000 (14:04 -0800)]
rdbms: optimize Database::selectDomain() to avoid extra queries
Also clean up and align the mysql subclass versions of the method.
Enforce that raw "USE" queries are not passed in, since they would
break the tracking (even before this change).
Change-Id: I11c9145c6c0525f27a4ec8d94c500a22a712b320
jenkins-bot [Fri, 8 Mar 2019 21:45:58 +0000 (21:45 +0000)]
Merge "jquery.tablesorter: Optimise getElementSortKey() code"
jenkins-bot [Fri, 8 Mar 2019 21:45:31 +0000 (21:45 +0000)]
Merge "Move CacheDependency classes to own files"
jenkins-bot [Fri, 8 Mar 2019 21:40:12 +0000 (21:40 +0000)]
Merge "objectcache: add metrics for WAN cache deletes and check key touches/resets"
jenkins-bot [Fri, 8 Mar 2019 21:40:04 +0000 (21:40 +0000)]
Merge "objectcache: move ERR_* constants to IExpiringStore"
Timo Tijhof [Fri, 8 Mar 2019 20:37:12 +0000 (20:37 +0000)]
resourceloader: Omit default 'debug=false' from load.php urls
Change-Id: I2a2f92b0f0438420105e6a4e4d97eb5f8c480917
Timo Tijhof [Fri, 8 Mar 2019 20:58:16 +0000 (20:58 +0000)]
resourceloader: Separate context from extraQuery in ClientHtmlTest
The test was dual-purposing the same array both to create
a ResourceLoaderContext object, and to pass further down as
$extraQuery parameter.
This meant that ResourceLoaderClientHtml::makeLoad, and indirectly
ResourceLoader::makeLoaderQuery, did not have any control over
the formatting of the query string, due to it forcing the key/value
pairs regardless (in addition to being redundant).
This is needed in order to omit debug=false by default, which is
the next commit.
Change-Id: I3c098a9a5055ec8f2b64319c6cadd13c030ba76a
Umherirrender [Fri, 8 Mar 2019 21:27:29 +0000 (22:27 +0100)]
Move CacheDependency classes to own files
Change-Id: Icacf36674f10fa19a09499d68d596d5e2cc235f0
Aaron Schulz [Thu, 7 Mar 2019 23:12:33 +0000 (15:12 -0800)]
objectcache: remove BagOStuff::modifySimpleRelayEvent()
This was only there as part of EventRelayer use by WAN cache, which
has since been removed. No other usage really makes sense.
Change-Id: I201425bb88739dd8febbfbc3d24a15e6d3d88d9c
Aaron Schulz [Fri, 8 Mar 2019 21:11:54 +0000 (13:11 -0800)]
objectcache: move ERR_* constants to IExpiringStore
Also removed unused ERR_* constant from WANObjectCache and fixed
comment in the constructor.
Change-Id: I4377fc3f533113a459b648fad084ba097ff51762
Timo Tijhof [Fri, 8 Mar 2019 16:02:44 +0000 (16:02 +0000)]
jquery.tablesorter: Optimise getElementSortKey() code
* Document why this uses $().data() instead of $.data(),
as the rest of this file does.
* Move single-use $() to where it is needed.
* Use native Image.alt directly instead of going via jQuery
and attributes. This also obviates the need for a default,
as the DOM handles that already.
* Remove needless $.makeArray(), use $.map() directly which
supports the same array-like objects as $.makeArray().
* Use native elem.textContent directly for text nodes,
instead of $(elem).text().
Change-Id: I92da50e1c01f11585d2bac4f01dba1f671444a63
Translation updater bot [Fri, 8 Mar 2019 21:06:23 +0000 (22:06 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If38e8f3671ef5a53006836c5ac14bbadc6930098
Umherirrender [Fri, 8 Mar 2019 20:56:38 +0000 (21:56 +0100)]
Move class HistoryPager to own file
Change-Id: Ie12e79e6f32225442b5bd794826f8c760b2c02d6
jenkins-bot [Fri, 8 Mar 2019 20:52:52 +0000 (20:52 +0000)]
Merge "jquery.tablesorter: Remove dead node check in getElementSortKey()"
jenkins-bot [Fri, 8 Mar 2019 20:50:07 +0000 (20:50 +0000)]
Merge "Convert a few call_user_func*() calls to native PHP syntax"
Timo Tijhof [Fri, 8 Mar 2019 15:30:27 +0000 (15:30 +0000)]
jquery.tablesorter: Remove dead node check in getElementSortKey()
In 2012, commit
39d1f3967be9d added special handling image elements,
and for Cite references. This inadvertently broke handling of sorting
for tables with colspanned cells, which have node = undefined in the
cache.
In 2013, commit
e203fdfc74f18 restored handling of node = undefined.
In 2015, commit
7a5f4e46d10ea made colspan expanded in the cache
just as rowspan was already. Thus making this code dead.
It's odd to see $(node) before this check, and even a call within
this conditional. This worked, as long way to return ''.
Change-Id: Ia823a3ec29371be39fab3d626ed8647ee469951b
Timo Tijhof [Fri, 8 Mar 2019 20:33:04 +0000 (20:33 +0000)]
resourceloader: Replace ResourceLoaderDebug config use with context
Reduce our reliance on static state and configuration, and
propagate more state in explicit ways, through context, and
request parameters.
OutputPage creates ResourceLoaderContext and ResourceLoaderClientHtml
based on the configuration (via ResourceLoader::inDebugMode).
Everything within those classes should not need to check it
again.
* ResourceLoaderClientHtml:
Already doesn't check MW config, but it's test was still
mocking it. Removed now, and confirmed that it passes both
with true and false. The individual test cases set
debug=true/false as needed already.
It's sets were previously relying on the accidental behaviour
that within a unit test, we don't serialise over HTTP, which
meant that a pure PHP boolean would survive. With the new
raw `=== 'true'` check, this no longer works. Set it as a
string explicitly instead, which is the only thing we support
outside unit tests as well.
* ResourceLoaderContext:
Remove fallback to MW config when 'debug' is unset.
This is never unset in practice given that all load.php
urls have it set by OutputPage based on ResourceLoader::inDebugMode.
This change means that manually constructed ad-hoc load.php
urls that are missing 'debug=' parameter, will now always be
read as debug=false. This was the default already, but could
previously be changed through wgResourceLoaderDebug.
When changing wgResourceLoaderDebug, everything will still have
debug=true as before. The only change is when constructing load.php
urls manually and explicitly not set it.
Bug: T32956
Change-Id: Ie3424be46e2b8311968f3068ca08ba6a1139224a
Umherirrender [Fri, 8 Mar 2019 19:19:26 +0000 (20:19 +0100)]
Move class JobQueueAggregatorNull to own file
Change-Id: Icb76f25eb9c2a26c91ba564a78edd4c07b49b944
Umherirrender [Sat, 16 Feb 2019 20:21:03 +0000 (21:21 +0100)]
Add @var to class properties to clarify types
Change-Id: Ia6e9eb70c68b5922077c8e5940b436844fa36e25
Fomafix [Thu, 20 Sep 2018 13:16:11 +0000 (15:16 +0200)]
Block: Explicit convert Message to string
Without a converting method like ->parse(), ->escaped() or ->text() the
method __toString() is used which is a equivalent to ->parse().
This change switches from ->parse() to ->text() and let Html::element do
the HTML escaping, because the message 'autoblockid' is not needed to
parse.
Change-Id: I653906bdca0864989ffed5960505b96053456066
Fomafix [Sat, 2 Mar 2019 11:14:28 +0000 (12:14 +0100)]
Remove deprecated Language::markNoConversion
Language::markNoConversion was hard-deprecated in
7de2c566d included in
1.32.
Change-Id: I2cc200d7a814e73d9c6138860190f44232a6bd3c
jenkins-bot [Fri, 8 Mar 2019 08:15:51 +0000 (08:15 +0000)]
Merge "Check normalization rules of usernames during signup"
Max Semenik [Fri, 8 Mar 2019 03:25:40 +0000 (19:25 -0800)]
Convert a few call_user_func*() calls to native PHP syntax
Change-Id: I54d94f4369eb4fa0b0ebe892a1d6cc57b2bdb1f9