Merge "Doc: Document problem sorting inserted data"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 14 Nov 2014 00:36:45 +0000 (00:36 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 14 Nov 2014 00:36:45 +0000 (00:36 +0000)
includes/db/DatabaseSqlite.php

index dd2e813..9257ffe 100644 (file)
@@ -787,6 +787,10 @@ class DatabaseSqlite extends DatabaseBase {
                        // https://bugs.php.net/bug.php?id=63419
                        // There was already a similar report for SQLite3::escapeString, bug #62361:
                        // https://bugs.php.net/bug.php?id=62361
+                       // There is an additional bug regarding sorting this data after insert
+                       // on older versions of sqlite shipped with ubuntu 12.04
+                       // https://bugzilla.wikimedia.org/show_bug.cgi?id=72367
+                       wfDebugLog( __CLASS__, __FUNCTION__ . ': Quoting value containing null byte. For consistency all binary data should have been first processed with self::encodeBlob()' );
                        return "x'" . bin2hex( $s ) . "'";
                } else {
                        return $this->mConn->quote( $s );