Merge "Avoid calling Block::deleteIfExpired() when not needed"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 5 Jan 2016 23:22:11 +0000 (23:22 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 5 Jan 2016 23:22:11 +0000 (23:22 +0000)
includes/Block.php

index 4729f50..7b287dc 100644 (file)
@@ -296,7 +296,7 @@ class Block {
                        $block = self::newFromRow( $row );
 
                        # Don't use expired blocks
-                       if ( $block->deleteIfExpired() ) {
+                       if ( $block->isExpired() ) {
                                continue;
                        }
 
@@ -1140,7 +1140,7 @@ class Block {
                $blocks = array();
                foreach ( $rows as $row ) {
                        $block = self::newFromRow( $row );
-                       if ( !$block->deleteIfExpired() ) {
+                       if ( !$block->isExpired() ) {
                                $blocks[] = $block;
                        }
                }