[Core JS] More fixing of global config variable usage
authorKrinkle <krinkle@users.mediawiki.org>
Sat, 31 Dec 2011 21:25:00 +0000 (21:25 +0000)
committerKrinkle <krinkle@users.mediawiki.org>
Sat, 31 Dec 2011 21:25:00 +0000 (21:25 +0000)
commitbe12ebf1ab651d0b689c1bf0494c13d454cad833
tree9b5f883d724a7d398370f012f217517cdac74f44
parentf2c6e0afb62373e14b74509c8f691b1b5d9f63b7
[Core JS] More fixing of global config variable usage
* mw.config is the new way, and global config variable lookups are deprecated

* Based on two phase3-wide quick searches:
-- of " wg": http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=321&hash=81700bf7486e4fee3b7bc1f83eb9eba6
-- of "!wg": http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=327&hash=47c9d54a7a1d5d58a724dd834585f40d

Related changes:
* Changed some php comments mentioning "wg" variables to include the dollar sign, and a typo when the wf function prefix was meant.
* Removed TODO comment in wikibits.js and made it use the JS equivalent of wfUrlencode, which we have now, mw.util.wikiUrlencode
* SpecialUpload.php: use OutputPage::addJsConfigVars instead of creating a new script tag through OutputPage::addScript(Skin::makeVariablesScript(..))
* Renamed wgUploadSetup in upload.js and made it local. Not used anywhere in ./trunk/phase3 and ./trunk/extensions
* Fix OutputPage::addJsConfigVars so that it can actually be called with an array instead of two arguments for key/value
* Some minor whitespace/convention stuff around the same line
15 files changed:
docs/hooks.txt
includes/HTMLForm.php
includes/OutputPage.php
includes/logging/LogEventsList.php
includes/specials/SpecialUpload.php
maintenance/language/messages.inc
resources/Resources.php
skins/common/ajax.js
skins/common/mwsuggest.js
skins/common/protect.js
skins/common/upload.js
skins/common/wikibits.js
tests/phpunit/includes/MWNamespaceTest.php
tests/phpunit/includes/upload/UploadTest.php
tests/phpunit/skins/SideBarTest.php