From f2c3df36d0b0d5cc2388377e6a283d04eed96dd0 Mon Sep 17 00:00:00 2001 From: Alex Z Date: Tue, 28 Oct 2008 02:38:59 +0000 Subject: [PATCH] partial revert of r42695, don't trim the comment --- RELEASE-NOTES | 3 +-- includes/RecentChange.php | 13 ------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 88a32366f7..3c7a093ab9 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -287,8 +287,7 @@ The following extensions are migrated into MediaWiki 1.14: * (bug 12764) Special:LonelyPages shows transcluded pages * (bug 16073) Enhanced RecentChanges uses onclick handler with better fallback if JavaScript is disabled. -* (bug 4253) Recentchanges IRC messages no longer include title in diff URLs and - the comment is trimmed if necessary to maintain proper message length. +* (bug 4253) Recentchanges IRC messages no longer include title in diff URLs * Allow '0' to be an accesskey. === API changes in 1.14 === diff --git a/includes/RecentChange.php b/includes/RecentChange.php index 31cdc0fe62..6b47df7651 100644 --- a/includes/RecentChange.php +++ b/includes/RecentChange.php @@ -645,19 +645,6 @@ class RecentChange # no colour (\003) switches back to the term default $fullString = "\00314[[\00307$title\00314]]\0034 $flag\00310 " . "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n"; - # RFC 2812 sets the limit for IRC message length at 512 bytes - # If the message is longer than that, trim the comment as much as necessary - # It might still be too long, but there's not much else we can trim without losing anything important - if ( strlen($fullString) > 512 ) { - $extra = strlen($fullString) - 512; - if ( strlen($comment) > $extra ) { - $comment = substr($comment, 0, strlen($comment) - $extra); - } else { - $comment = ''; - } - $fullString = "\00314[[\00307$title\00314]]\0034 $flag\00310 " . - "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n"; - } return $fullString; } -- 2.20.1