From e6a275409ccdb15feabac24cd4649cfdb57e1be4 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Wed, 30 Sep 2009 17:50:58 +0000 Subject: [PATCH] Revert r57053 for now "bug 20860 [[Special:Allmessages]] to have direct (edit) link" While a direct link is nice, the current implementation looks pretty bad the way the lines break in the giant table --- RELEASE-NOTES | 1 - includes/specials/SpecialAllmessages.php | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 56057d5ea8..0d46156603 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -538,7 +538,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN now links to the file rather than the file description page * Password fields built with HTMLForm now still have the type="password" attribute if $wgHtml5=false. -* (bug 20860) Entries on Special:Allmessages now have direct "edit" link * (bug 20836) Preload now works for MediaWiki namespace == API changes in 1.16 == diff --git a/includes/specials/SpecialAllmessages.php b/includes/specials/SpecialAllmessages.php index 7fc9192f0a..b88b6a6317 100644 --- a/includes/specials/SpecialAllmessages.php +++ b/includes/specials/SpecialAllmessages.php @@ -299,8 +299,7 @@ class AllmessagesTablePager extends TablePager { $title = Title::makeTitle( NS_MEDIAWIKI, $value . $this->suffix ); $talk = Title::makeTitle( NS_MEDIAWIKI_TALK, $value . $this->suffix ); - $edit = $this->mSkin->link( $title, wfMsg( 'edit' ), array(), 'action=edit' ); - + if( $this->mCurrentRow->am_customised ){ $title = $this->mSkin->linkKnown( $title, $wgLang->lcfirst( $value ) ); } else { @@ -323,7 +322,7 @@ class AllmessagesTablePager extends TablePager { array( 'broken' ) ); } - return $title . ' (' . $wgLang->pipeList( array( $edit, $talk ) ) . ')'; + return $title . ' (' . $talk . ')'; case 'am_default' : return Sanitizer::escapeHtmlAllowEntities( $value, ENT_QUOTES ); -- 2.20.1