From df28a0043daa83ad741fc9864fb600c3f6b284b6 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Tue, 19 Nov 2013 13:29:45 +0100 Subject: [PATCH] Various fixes for RecentChange * Do not return the value of a function that returns void * Update documentation Change-Id: I2b25bf34f578be516a19c84d45860ab6c7f93e0e --- includes/changes/RecentChange.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/includes/changes/RecentChange.php b/includes/changes/RecentChange.php index a6920f64ef..7deae5c8ee 100644 --- a/includes/changes/RecentChange.php +++ b/includes/changes/RecentChange.php @@ -105,6 +105,7 @@ class RecentChange { } /** + * No uses left in Gerrit on 2013-11-19. * @deprecated in 1.22 * @param $row * @return RecentChange @@ -324,7 +325,7 @@ class RecentChange { 'add_interwiki_prefix' => $wgRC2UDPInterwikiPrefix, ); - return $engine->send( $feed, $line ); + $engine->send( $feed, $line ); } /** @@ -351,6 +352,7 @@ class RecentChange { continue; } + /** @var $formatter RCFeedFormatter */ $formatter = new $feed['formatter'](); $line = $formatter->getLine( $feed, $this, $actionComment ); @@ -361,7 +363,8 @@ class RecentChange { /** * Gets the stream engine object for a given URI from $wgRCEngines * - * @param $uri string URI to get the engine object for + * @param string $uri URI to get the engine object for + * @throws MWException * @return object The engine object */ private static function getEngine( $uri ) { -- 2.20.1