From dcc9d4a3c81bfd06a5bec0ea59e7cb5ca2ab4c6a Mon Sep 17 00:00:00 2001 From: Reedy Date: Sun, 1 Jun 2014 01:08:37 +0100 Subject: [PATCH] Remove 'SpecialVersionExtensionTypes' hook, deprecated in 1.17. Change-Id: I98d15e2bbbec2ba754c4754c97a46f32e714398a --- RELEASE-NOTES-1.24 | 1 + docs/hooks.txt | 5 ----- includes/specials/SpecialVersion.php | 6 +----- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index c42e1357d2..c670dea424 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -124,6 +124,7 @@ changes to languages because of Bugzilla reports. the "headelement" template key are no longer supported. Setting $useHeadElement = false; is no longer supported and will not cause old keys like "headlinks", "skinnameclass", etc. to be defined. +* The deprecated 'SpecialVersionExtensionTypes' hook was removed. ==== Renamed classes ==== * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression diff --git a/docs/hooks.txt b/docs/hooks.txt index e91f43721b..cb76341c4a 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -2516,11 +2516,6 @@ $term: string of search term Special:Upload. $form: The SpecialUpload object -'SpecialVersionExtensionTypes': Called when generating the extensions credits, -use this to change the tables headers. Deprecated since MediaWiki 1.17, use the -ExtensionTypes hook instead. -$extTypes: associative array of extensions types - 'SpecialVersionVersionUrl': Called when building the URL for Special:Version. $wgVersion: Current $wgVersion for you to use &$versionUrl: Raw url to link to (eg: release notes) diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index 41847dc8ad..657999c05a 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -377,9 +377,7 @@ class SpecialVersion extends SpecialPage { * Returns an array with the base extension types. * Type is stored as array key, the message as array value. * - * TODO: ideally this would return all extension types, including - * those added by SpecialVersionExtensionTypes. This is not possible - * since this hook is passing along $this though. + * TODO: ideally this would return all extension types. * * @since 1.17 * @@ -433,8 +431,6 @@ class SpecialVersion extends SpecialPage { $extensionTypes = self::getExtensionTypes(); - wfRunHooks( 'SpecialVersionExtensionTypes', array( &$this, &$extensionTypes ), '1.17' ); - $out = Xml::element( 'h2', array( 'id' => 'mw-version-ext' ), -- 2.20.1