From be4fe9a52afd6a4fbaeb987813ac02b63b227c5f Mon Sep 17 00:00:00 2001 From: Florian Date: Sat, 24 Oct 2015 20:34:53 +0200 Subject: [PATCH] Make sure, that a tags and input tags with mw-ui-button has the same height Line-height inherited from another element behave different for input and a tags. While a-tags correctly inherit the line-height from a parent element, input tags doesn't. Fix that by adding the correct line-height (normal) to a tags with mw-ui-button. Bug: T116427 Change-Id: I4822754157b95094605209111e72bce11d34b077 --- resources/src/mediawiki.ui/components/buttons.less | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/resources/src/mediawiki.ui/components/buttons.less b/resources/src/mediawiki.ui/components/buttons.less index 77b3f9d882..d66973a8ea 100644 --- a/resources/src/mediawiki.ui/components/buttons.less +++ b/resources/src/mediawiki.ui/components/buttons.less @@ -243,6 +243,12 @@ a.mw-ui-button { &:focus { text-decoration: none; } + + // a-tags behave different to inputs if the line-height attribute is inherited + // from another element (e.g. mw-body-content). They appear bigger as input + // tags. See Bug T116427. To fix that, apply the correct line-height (used + // for inputs) to a-tags, too. + line-height: normal; } // Button groups -- 2.20.1