From 52eee0cfa9e86fedf7d414ae2a538e5d0c889dce Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Fri, 14 Aug 2009 00:36:42 +0000 Subject: [PATCH] Fixed double-escaping bug in ConfEditor's handling of double-quoted strings. For some reason it was *re-escaping* single-quoted strings; this would lead to corruption in LocalisationUpdate. --- includes/ConfEditor.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/ConfEditor.php b/includes/ConfEditor.php index 5ac1d7f02c..9c8ebb6c5f 100644 --- a/includes/ConfEditor.php +++ b/includes/ConfEditor.php @@ -310,8 +310,7 @@ class ConfEditor { array( '\\\'' => '\'', '\\\\' => '\\' ) ); if ( $str !== '' && @$str[0] == '"' ) // Double-quoted string - return strtr( stripcslashes( substr( $str, 1, -1 ) ), - array( '\'' => '\\\'' ) ); + return stripcslashes( substr( $str, 1, -1 ) ); if ( substr( $str, 0, 4 ) == 'true' ) return true; if ( substr( $str, 0, 5 ) == 'false' ) -- 2.20.1