From 25a6a8669037b617a25c36ca43d52b383538e3a2 Mon Sep 17 00:00:00 2001
From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Thu, 30 Oct 2014 13:23:09 -0400
Subject: [PATCH] API: Add doc warning to ApiPageSet::populateFromQueryResult

The cause of bug 72764 was an extension misusing
ApiPageSet::populateFromQueryResult(). Add a warning in the docs for
that method about proper usage.

Bug: 72764
Change-Id: I5b0a069d796f7f41ab0b16048d7b3d6600207383
---
 includes/api/ApiPageSet.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php
index ab705b2de4..db5eb52f23 100644
--- a/includes/api/ApiPageSet.php
+++ b/includes/api/ApiPageSet.php
@@ -669,6 +669,10 @@ class ApiPageSet extends ApiBase {
 
 	/**
 	 * Populate this PageSet from a rowset returned from the database
+	 *
+	 * Note that the query result must include the columns returned by
+	 * $this->getPageTableFields().
+	 *
 	 * @param DatabaseBase $db
 	 * @param ResultWrapper $queryResult Query result object
 	 */
-- 
2.20.1