From 1001bac41c50befcd5832c5b52c9cadf2f6b0ef4 Mon Sep 17 00:00:00 2001 From: "This, that and the other" Date: Sun, 3 May 2015 13:28:55 +1000 Subject: [PATCH] Fixed some IDE warnings in ChangeTags Change-Id: Ie7af687e543756988618be21a464f43ad03052d5 --- includes/changetags/ChangeTags.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/changetags/ChangeTags.php b/includes/changetags/ChangeTags.php index 564feb6509..a0c3cf2669 100644 --- a/includes/changetags/ChangeTags.php +++ b/includes/changetags/ChangeTags.php @@ -518,7 +518,6 @@ class ChangeTags { if ( $rev_id ) { $rev = Revision::newFromId( $rev_id ); if ( $rev ) { - $title = $rev->getTitle(); $logEntry->setTarget( $rev->getTitle() ); } } elseif ( $log_id ) { @@ -707,6 +706,7 @@ class ChangeTags { * @param User $user Who to attribute the action to * @param int $tagCount For deletion only, how many usages the tag had before * it was deleted. + * @return int ID of the inserted log entry * @since 1.25 */ protected static function logTagManagementAction( $action, $tag, $reason, -- 2.20.1