From 0072e0efeb8591a7761b3d573f8b71ef97fb96ec Mon Sep 17 00:00:00 2001 From: Brent Garber Date: Sat, 19 Jan 2013 03:43:03 +0000 Subject: [PATCH] (bug 44024) ObjectCache changes break XCache 3.x support Changes in the 1.20.x branch altered the add method to check for the return value of get against false. Xcache 3.x returns NULL for unset values and so this check was erroneously determining that all values are set when they were not. This was causing basic ObjectCache usage to fail. Change-Id: I0975e5c6a60c2813dc2d02aca84245807b8fb828 --- includes/objectcache/XCacheBagOStuff.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/objectcache/XCacheBagOStuff.php b/includes/objectcache/XCacheBagOStuff.php index f740ae804f..2722e9c81a 100644 --- a/includes/objectcache/XCacheBagOStuff.php +++ b/includes/objectcache/XCacheBagOStuff.php @@ -44,6 +44,8 @@ class XCacheBagOStuff extends BagOStuff { } else { $val = unserialize( $val ); } + } elseif ( is_null( $val ) ) { + return false; } return $val; -- 2.20.1