From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 30 Sep 2009 17:50:58 +0000 (+0000)
Subject: Revert r57053 for now "bug 20860 [[Special:Allmessages]] to have direct (edit) link"
X-Git-Tag: 1.31.0-rc.0~39458
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=e6a275409ccdb15feabac24cd4649cfdb57e1be4;p=lhc%2Fweb%2Fwiklou.git

Revert r57053 for now "bug 20860 [[Special:Allmessages]] to have direct (edit) link"
While a direct link is nice, the current implementation looks pretty bad the way the lines break in the giant table
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 56057d5ea8..0d46156603 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -538,7 +538,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   now links to the file rather than the file description page
 * Password fields built with HTMLForm now still have the type="password" attribute
   if $wgHtml5=false.
-* (bug 20860) Entries on Special:Allmessages now have direct "edit" link
 * (bug 20836) Preload now works for MediaWiki namespace
 
 == API changes in 1.16 ==
diff --git a/includes/specials/SpecialAllmessages.php b/includes/specials/SpecialAllmessages.php
index 7fc9192f0a..b88b6a6317 100644
--- a/includes/specials/SpecialAllmessages.php
+++ b/includes/specials/SpecialAllmessages.php
@@ -299,8 +299,7 @@ class AllmessagesTablePager extends TablePager {
 
 				$title = Title::makeTitle( NS_MEDIAWIKI, $value . $this->suffix );
 				$talk  = Title::makeTitle( NS_MEDIAWIKI_TALK, $value . $this->suffix );
-				$edit  = $this->mSkin->link( $title, wfMsg( 'edit' ), array(), 'action=edit' );
-				
+
 				if( $this->mCurrentRow->am_customised ){
 					$title = $this->mSkin->linkKnown( $title, $wgLang->lcfirst( $value ) );
 				} else {
@@ -323,7 +322,7 @@ class AllmessagesTablePager extends TablePager {
 						array( 'broken' )
 					);
 				}
-				return $title . ' (' . $wgLang->pipeList( array( $edit, $talk ) ) . ')';
+				return $title . ' (' . $talk . ')';
 
 			case 'am_default' :
 				return Sanitizer::escapeHtmlAllowEntities( $value, ENT_QUOTES );