From: Ed Sanders <esanders@wikimedia.org>
Date: Tue, 6 Nov 2018 13:31:47 +0000 (+0000)
Subject: SpecialPreferences: Make save button bar sticky
X-Git-Tag: 1.34.0-rc.0~3418^2
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=cd150ad0f1ca925a0904fb24b6585a9f34655ff4;p=lhc%2Fweb%2Fwiklou.git

SpecialPreferences: Make save button bar sticky

Enable `position: sticky` on preferences buttons and degrade
gracefully in unsupported browsers, where this results in no
change.

Bug: T205866
Change-Id: Ic98a9d94d3136a4003370cf0e2a8efb7ae1a3f38
---

diff --git a/resources/src/mediawiki.special.preferences.styles.ooui.less b/resources/src/mediawiki.special.preferences.styles.ooui.less
index 6f91ad26f3..b1931f486a 100644
--- a/resources/src/mediawiki.special.preferences.styles.ooui.less
+++ b/resources/src/mediawiki.special.preferences.styles.ooui.less
@@ -13,16 +13,26 @@
 .mw-email-authenticated .oo-ui-labelWidget { }
 */
 
+/*
+ * Use `position: sticky` on supported browsers, degrades gracefully in
+ * all others, therefore no `@supports` feature query to reduce code complexity.
+ */
+.mw-prefs-buttons {
+	background-color: #fff;
+	position: -webkit-sticky;
+	position: sticky;
+	bottom: 0;
+	margin-top: -1px;
+	border-top: 1px solid #c8ccd1;
+	padding: 1em 0;
+}
+
 /* This is needed because add extra buttons in a weird way */
 .mw-prefs-buttons .mw-htmlform-submit-buttons {
 	display: inline;
 	margin: 0;
 }
 
-.mw-prefs-buttons {
-	margin-top: 1em;
-}
-
 #prefcontrol {
 	margin-right: 0.5em;
 }