From: Amir Sarabadani Date: Mon, 10 Oct 2016 18:37:36 +0000 (+0330) Subject: TemplatesOnThisPage: The second paramter in rawElement is attributes, not content X-Git-Tag: 1.31.0-rc.0~5158^2 X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=8660cbacf2b7107fa35a71e96e7689895cd89f9f;p=lhc%2Fweb%2Fwiklou.git TemplatesOnThisPage: The second paramter in rawElement is attributes, not content With proper typehinting this wouldn't have happened Bug: T147789 Change-Id: I19ef9388acfd9159304b8141c54ce1ead27d0791 --- diff --git a/includes/TemplatesOnThisPageFormatter.php b/includes/TemplatesOnThisPageFormatter.php index c0ae374a05..494c7bfc86 100644 --- a/includes/TemplatesOnThisPageFormatter.php +++ b/includes/TemplatesOnThisPageFormatter.php @@ -93,11 +93,11 @@ class TemplatesOnThisPageFormatter { } if ( $more instanceof LinkTarget ) { - $outText .= Html::rawElement( 'li', $this->linkRenderer->makeLink( + $outText .= Html::rawElement( 'li', [], $this->linkRenderer->makeLink( $more, $this->context->msg( 'moredotdotdot' )->text() ) ); } elseif ( $more ) { // Documented as should already be escaped - $outText .= Html::rawElement( 'li', $more ); + $outText .= Html::rawElement( 'li', [], $more ); } $outText .= '';