From: Rohan <rohan1395@yahoo.com>
Date: Wed, 25 Jun 2014 16:39:04 +0000 (+0530)
Subject: Disables upload by url option for users without the necessary permissions
X-Git-Tag: 1.31.0-rc.0~15083
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=54a48ef1b296dca9b1810fda53b33556b1ccd5f2;p=lhc%2Fweb%2Fwiklou.git

Disables upload by url option for users without the necessary permissions

Does an explicit check for a true value in SpecialUpload::getSourceSection

Bug: 39507
Change-Id: I00297494230d07081dd85a810321446badc3ecb0
---

diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php
index 01c0aaf6f6..976294bb1a 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -827,7 +827,7 @@ class UploadForm extends HTMLForm {
 		}
 
 		$canUploadByUrl = UploadFromUrl::isEnabled()
-			&& UploadFromUrl::isAllowed( $this->getUser() )
+			&& ( UploadFromUrl::isAllowed( $this->getUser() ) === true )
 			&& $wgCopyUploadsFromSpecialUpload;
 		$radio = $canUploadByUrl;
 		$selectedSourceType = strtolower( $this->getRequest()->getText( 'wpSourceType', 'File' ) );