Revert r43804 'This should probably be in Response, not Request, as we're setting...

Session id is used by client request to specify its login data from cookie, so the session data, by extensions, is like a sort of request parameter. Also, WebResponse.php seems to be used for data actually sent to the client, like requested cookies.

diff --git a/includes/WebRequest.php b/includes/WebRequest.php
index c3c1d89..4674712 100644 (file)
--- a/includes/WebRequest.php
+++ b/includes/WebRequest.php
@@ -658,6 +658,9 @@ class WebRequest {
                        return null;
                return $_SESSION[$key];
        }
+       function setSessionData( $key, $data ) {
+               $_SESSION[$key] = $data;
+       }
 }
 
 /**
@@ -722,5 +725,8 @@ class FauxRequest extends WebRequest {
                        return null;
                return $this->session[$key];
        }
+       function setSessionData( $key, $data ) {
+               $this->notImplemented( __METHOD__ );
+       }
 
 }

diff --git a/includes/WebResponse.php b/includes/WebResponse.php
index 19feadd..09d3738 100644 (file)
--- a/includes/WebResponse.php
+++ b/includes/WebResponse.php
@@ -57,8 +57,4 @@ class WebResponse {
                                $wgCookieSecure );
                }
        }
-
-       public function setSessionData( $key, $data ) {
-               $_SESSION[$key] = $data;
-       }
 }