This seems to disable PST for <includeonly>...</includeonly> in addition to the <includeonly><nowiki>...</nowiki></includeonly> that the bug is about.
This was caught by a parser test case, but the test case was changed to match... seems like the wrong change?
Also failed to update Preprocessor_HipHop.hphp to match the other two preprocessor classes.
* (bug 29101) Special:FileDuplicateSearch shows silly message
* (bug 29048) jQuery.tabIndex: firstTabIndex() should not output the same
as lastTabIndex().
-* (bug 93) tilde signatures inside nowiki tags sometimes get expanded
- (<includeonly><nowiki>~~~~</nowiki></includeonly>)
=== API changes in 1.19 ===
* BREAKING CHANGE: action=watch now requires POST and token.
# OT_WIKI will only respect <ignore> in substed templates.
# The other output types respect it unless NO_IGNORE is set.
# extractSections() sets NO_IGNORE and so never respects it.
- if ( $flags & PPFrame::NO_IGNORE ) {
+ if ( ( !isset( $this->parent ) && $this->parser->ot['wiki'] ) || ( $flags & PPFrame::NO_IGNORE ) ) {
$out .= $contextNode->textContent;
- # Add a strip marker in PST mode so that pstPass2() can run some old-fashioned regexes on the result
- } elseif ( !isset( $this->parent ) && $this->parser->ot['wiki'] ) {
- $out .= $this->parser->insertStripItem( $contextNode->textContent );
} else {
$out .= '';
}
# OT_WIKI will only respect <ignore> in substed templates.
# The other output types respect it unless NO_IGNORE is set.
# extractSections() sets NO_IGNORE and so never respects it.
- if ( $flags & PPFrame::NO_IGNORE ) {
+ if ( ( !isset( $this->parent ) && $this->parser->ot['wiki'] ) || ( $flags & PPFrame::NO_IGNORE ) ) {
$out .= $contextNode->firstChild->value;
- # Add a strip marker in PST mode so that pstPass2() can run some old-fashioned regexes on the result
- } elseif ( !isset( $this->parent ) && $this->parser->ot['wiki'] ) {
- $out .= $this->parser->insertStripItem( $contextNode->firstChild->value );
} else {
//$out .= '';
}
!! result
* [[Special:Contributions/127.0.0.1|127.0.0.1]]
* <noinclude>[[Special:Contributions/127.0.0.1|127.0.0.1]]</noinclude>
-* <includeonly>~~~</includeonly>
+* <includeonly>[[Special:Contributions/127.0.0.1|127.0.0.1]]</includeonly>
* <onlyinclude>[[Special:Contributions/127.0.0.1|127.0.0.1]]</onlyinclude>
!! end
!! test
pre-save transform: Signature expansion in nowiki tags (bug 93)
!! options
-pst
+pst disabled
!! input
Shall not expand: