Merge "Remove unused $entryPoint from Preferences::tryFormSubmit"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Thu, 6 Feb 2014 16:51:49 +0000 (16:51 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Thu, 6 Feb 2014 16:51:49 +0000 (16:51 +0000)
1  2 
includes/Preferences.php

diff --combined includes/Preferences.php
@@@ -62,13 -62,6 +62,13 @@@ class Preferences 
                'emailaddress',
        );
  
 +      /**
 +       * @return array
 +       */
 +      static function getSaveBlacklist() {
 +              return self::$saveBlacklist;
 +      }
 +
        /**
         * @throws MWException
         * @param $user User
         *
         * @param $formData
         * @param $form PreferencesForm
-        * @param $entryPoint string
         * @return bool|Status|string
         */
-       static function tryFormSubmit( $formData, $form, $entryPoint = 'internal' ) {
+       static function tryFormSubmit( $formData, $form ) {
                global $wgHiddenPrefs, $wgAuth;
  
                $user = $form->getModifiedUser();
                                $user->setOption( $key, $value );
                        }
  
 +                      wfRunHooks( 'PreferencesFormPreSave', array( $formData, $form, $user, &$result ) );
                        $user->saveSettings();
                }
  
         * @return Status
         */
        public static function tryUISubmit( $formData, $form ) {
-               $res = self::tryFormSubmit( $formData, $form, 'ui' );
+               $res = self::tryFormSubmit( $formData, $form );
  
                if ( $res ) {
                        $urlOptions = array( 'success' => 1 );