Replace broken nested terneries (causing a nasty bug where all admins could view...
authorAndrew Garrett <werdna@users.mediawiki.org>
Thu, 8 Oct 2009 19:40:53 +0000 (19:40 +0000)
committerAndrew Garrett <werdna@users.mediawiki.org>
Thu, 8 Oct 2009 19:40:53 +0000 (19:40 +0000)
includes/Revision.php

index fc43989..eee97cb 100644 (file)
@@ -979,9 +979,16 @@ class Revision {
        public function userCan( $field ) {
                if( $this->mDeleted & $field ) {
                        global $wgUser;
-                       $permission = ( $this->mDeleted & self::DELETED_RESTRICTED )
-                               ? 'suppressrevision'
-                               : ( $field & self::DELETED_TEXT ) ? 'deletedtext' : 'deletedhistory';
+                       
+                       $permission = '';
+                       if ( $this->mDeleted & self::DELETED_RESTRICTED ) {
+                               $permission = 'suppressrevision';
+                       } elseif ( $field & self::DELETED_TEXT ) {
+                               $permission = 'deletedtext';
+                       } else {
+                               $permission = 'deletedhistory';
+                       }
+                       
                        wfDebug( "Checking for $permission due to $field match on $this->mDeleted\n" );
                        return $wgUser->isAllowed( $permission );
                } else {