Merge "Add anchor "mw-oldid" for beginning of page content in diff view"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 4 Mar 2015 10:22:58 +0000 (10:22 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 4 Mar 2015 10:22:58 +0000 (10:22 +0000)
1  2 
includes/diff/DifferenceEngine.php

@@@ -94,10 -94,6 +94,10 @@@ class DifferenceEngine extends ContextS
  
        /** @var bool Show rev_deleted content if allowed */
        protected $unhide = false;
 +
 +      /** @var bool Refresh the diff cache */
 +      protected $mRefreshCache = false;
 +
        /**#@-*/
  
        /**
                $out = $this->getOutput();
                $revHeader = $this->getRevisionHeader( $this->mNewRev );
                # Add "current version as of X" title
-               $out->addHTML( "<hr class='diff-hr' />
+               $out->addHTML( "<hr class='diff-hr' id='mw-oldid' />
                <h2 class='diff-currentversion-title'>{$revHeader}</h2>\n" );
                # Page content may be handled by a hooked call instead...
                # @codingStandardsIgnoreStart Ignoring long lines.
        protected function getParserOutput( WikiPage $page, Revision $rev ) {
                $parserOptions = $page->makeParserOptions( $this->getContext() );
  
 -              if ( !$rev->isCurrent() || !$rev->getTitle()->quickUserCan( "edit" ) ) {
 +              if ( !$rev->isCurrent() || !$rev->getTitle()->quickUserCan( 'edit', $this->getUser() ) ) {
                        $parserOptions->setEditSection( false );
                }
  
                        $users = $this->mNewPage->getAuthorsBetween( $oldRev, $newRev, $limit );
                        $numUsers = count( $users );
  
 -                      if ( $numUsers == 1 && $users[0] == $newRev->getRawUserText() ) {
 +                      if ( $numUsers == 1 && $users[0] == $newRev->getUserText( Revision::RAW ) ) {
                                $numUsers = 0; // special case to say "by the same user" instead of "by one other user"
                        }