dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3631901) | patch
Remove unused exception in SpecialPage::getTitleFor and add tests
authoraude <aude.wiki@gmail.com>
Sat, 16 Nov 2013 14:24:02 +0000 (15:24 +0100)
committeraude <aude.wiki@gmail.com>
Sat, 16 Nov 2013 19:48:47 +0000 (20:48 +0100)
commitd093453e7eb3117babbe704169b0b4feae157457
treecd78e7ea47c9bd7caa1ebf84d5eb29dba6dc4e34tree | snapshot
parent3631901139f6d4f78811030f97c2ca2f55151ba0commit | diff
Remove unused exception in SpecialPage::getTitleFor and add tests

The way the existing code was, it seems the exception condition
was never hit, as one could enter a bogus special page title in
SpecialPage::getTitleFor and it returns a Title object anyway.

Some tests are also added for SpecialPage::getTitleFor(),
although more refactoring my be required to truly unit test this,
vs. indirectly testing other stuff via static methods.

Change-Id: I6e427d047a2f8e58677eb65b50866f767078c255
includes/SpecialPage.php diff | blob | history
tests/phpunit/includes/SpecialPageTest.php [new file with mode: 0644] blob
Wiklou, le Wiki du Wiklou