From: Umherirrender <umherirrender_de.wp@web.de>
Date: Tue, 7 Aug 2018 10:39:46 +0000 (+0200)
Subject: Whitelist phpcs Squiz.Scope.MemberVarScope in PHPVersionCheck
X-Git-Tag: 1.34.0-rc.0~4543^2
X-Git-Url: http://git.cyclocoop.org//%27http:/code.google.com/p/ie7-js//%27?a=commitdiff_plain;h=9e7ca073ea1f6cf1c20268a326c64469adf66f91;p=lhc%2Fweb%2Fwiklou.git

Whitelist phpcs Squiz.Scope.MemberVarScope in PHPVersionCheck

The class supports php4 and the visibility private does not work there.

Change-Id: I9cbffe437a1d1f4243f0b70bd881cdc8b8257537
---

diff --git a/.phpcs.xml b/.phpcs.xml
index 2a34154689..944c3e20e1 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -22,7 +22,6 @@
 		<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
 		<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment" />
 		<exclude name="Squiz.Scope.MethodScope.Missing" />
-		<exclude name="Squiz.Scope.MemberVarScope.Missing" />
 	</rule>
 	<rule ref="MediaWiki.NamingConventions.PrefixedGlobalFunctions">
 		<properties>
diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index 8eda14ad99..70ad0b29b1 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -19,6 +19,7 @@
  */
 
 // phpcs:disable Generic.Arrays.DisallowLongArraySyntax,PSR2.Classes.PropertyDeclaration,MediaWiki.Usage.DirUsage
+// phpcs:disable Squiz.Scope.MemberVarScope.Missing,Squiz.Scope.MethodScope.Missing
 /**
  * Check PHP Version, as well as for composer dependencies in entry points,
  * and display something vaguely comprehensible in the event of a totally