From 9eb25dc032c7408c96af78253ac512fd3ceb2231 Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Wed, 11 Apr 2012 14:37:27 +0200 Subject: [PATCH] Check for namespace existence in Title::makeTitleSafe(). Namespace existence has to be checked before calling Title::makeName() because otherwise it will fallback to a page with the same name, but in the main namespace which is not what we want here. Change-Id: I8c087390044c54dd0502c1b8bb9321dfaec6b5f7 --- includes/Title.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/includes/Title.php b/includes/Title.php index 769adb91f6..1876d75caa 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -317,6 +317,10 @@ class Title { * @return Title the new object, or NULL on an error */ public static function makeTitleSafe( $ns, $title, $fragment = '', $interwiki = '' ) { + if ( !MWNamespace::exists( $ns ) ) { + return null; + } + $t = new Title(); $t->mDbkeyform = Title::makeName( $ns, $title, $fragment, $interwiki ); if ( $t->secureAndSplit() ) { -- 2.20.1