From 0ceb2f8d4cc22011fffc1ff4a25fb9f0c81f41ac Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 21 Sep 2016 00:58:14 -0700 Subject: [PATCH] Use getConnectionRef() in ExternalStoreDB to avoid connection leaks Change-Id: I3df270241653841a4fb2f65e240aae9d2e0b650f --- includes/externalstore/ExternalStoreDB.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/externalstore/ExternalStoreDB.php b/includes/externalstore/ExternalStoreDB.php index 2eae279be5..7e932994e6 100644 --- a/includes/externalstore/ExternalStoreDB.php +++ b/includes/externalstore/ExternalStoreDB.php @@ -130,7 +130,7 @@ class ExternalStoreDB extends ExternalStoreMedium { wfDebug( "writable external store\n" ); } - $db = $lb->getConnection( DB_REPLICA, [], $wiki ); + $db = $lb->getConnectionRef( DB_REPLICA, [], $wiki ); $db->clearFlag( DBO_TRX ); // sanity return $db; @@ -146,7 +146,7 @@ class ExternalStoreDB extends ExternalStoreMedium { $wiki = isset( $this->params['wiki'] ) ? $this->params['wiki'] : false; $lb = $this->getLoadBalancer( $cluster ); - $db = $lb->getConnection( DB_MASTER, [], $wiki ); + $db = $lb->getConnectionRef( DB_MASTER, [], $wiki ); $db->clearFlag( DBO_TRX ); // sanity return $db; -- 2.20.1