From 0a7c0a67978c68a059264842800128b83da63c51 Mon Sep 17 00:00:00 2001 From: Kosta Harlan Date: Wed, 3 Oct 2018 16:42:55 -0400 Subject: [PATCH] Move test assertion to mirror parameter order Follow up from I2df0551c5837adc578b27082ab6ba2ac95d937f8 Bug: T206130 Change-Id: Ib669c77fdb709846d0182cb28796cf53914114c4 --- tests/phpunit/includes/TitlePermissionTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/includes/TitlePermissionTest.php b/tests/phpunit/includes/TitlePermissionTest.php index f53b0596c1..baf824352b 100644 --- a/tests/phpunit/includes/TitlePermissionTest.php +++ b/tests/phpunit/includes/TitlePermissionTest.php @@ -660,10 +660,6 @@ class TitlePermissionTest extends MediaWikiLangTestCase { $result = $this->title->getUserPermissionsErrors( 'bogus', $this->user ); $this->assertEquals( $resultNone, $result ); - $this->setUserPerm( '' ); - $result = $this->title->getUserPermissionsErrors( 'patrol', $this->user ); - $this->assertEquals( $resultPatrol, $result ); - $this->setUserPerm( 'editmyusercss' ); $result = $this->title->getUserPermissionsErrors( 'bogus', $this->user ); $this->assertEquals( $resultMyCss, $result ); @@ -688,6 +684,10 @@ class TitlePermissionTest extends MediaWikiLangTestCase { $result = $this->title->getUserPermissionsErrors( 'bogus', $this->user ); $this->assertEquals( $resultUserJs, $result ); + $this->setUserPerm( '' ); + $result = $this->title->getUserPermissionsErrors( 'patrol', $this->user ); + $this->assertEquals( $resultPatrol, $result ); + $this->setUserPerm( [ 'edituserjs', 'edituserjson', 'editusercss' ] ); $result = $this->title->getUserPermissionsErrors( 'bogus', $this->user ); $this->assertEquals( [ [ 'badaccess-group0' ] ], $result ); -- 2.20.1