From: Umherirrender <umherirrender_de.wp@web.de>
Date: Wed, 2 May 2018 19:42:56 +0000 (+0200)
Subject: Remove deprecated SqlDataUpdate class
X-Git-Tag: 1.34.0-rc.0~5514^2
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=fc871584ec955d81409024f08d3df244e111f612;p=lhc%2Fweb%2Fwiklou.git

Remove deprecated SqlDataUpdate class

Deprecated since 1.28

Change-Id: I4dcbc8fcfdb99caa0469e7cf63745b94e19cd21d
---

diff --git a/RELEASE-NOTES-1.32 b/RELEASE-NOTES-1.32
index 72f877fc06..ec2597fdba 100644
--- a/RELEASE-NOTES-1.32
+++ b/RELEASE-NOTES-1.32
@@ -70,6 +70,7 @@ changes to languages because of Phabricator reports.
   * Revision::getRawComment()
 * window.gM() from mediawiki.jqueryMsg was removed (deprecated in 1.23).
   Use mw.msg() or mw.message() instead.
+* The SqlDataUpdate class, deprecated in 1.28, has been removed.
 
 === Deprecations in 1.32 ===
 * Use of a StartProfiler.php file is deprecated in favour of placing
diff --git a/autoload.php b/autoload.php
index b832863564..e316bb521d 100644
--- a/autoload.php
+++ b/autoload.php
@@ -1482,7 +1482,6 @@ $wgAutoloadLocalClasses = [
 	'SpecialWatchlist' => __DIR__ . '/includes/specials/SpecialWatchlist.php',
 	'SpecialWhatLinksHere' => __DIR__ . '/includes/specials/SpecialWhatlinkshere.php',
 	'SqlBagOStuff' => __DIR__ . '/includes/objectcache/SqlBagOStuff.php',
-	'SqlDataUpdate' => __DIR__ . '/includes/deferred/SqlDataUpdate.php',
 	'SqlSearchResultSet' => __DIR__ . '/includes/search/SqlSearchResultSet.php',
 	'Sqlite' => __DIR__ . '/maintenance/sqlite.inc',
 	'SqliteInstaller' => __DIR__ . '/includes/installer/SqliteInstaller.php',
diff --git a/includes/deferred/SqlDataUpdate.php b/includes/deferred/SqlDataUpdate.php
deleted file mode 100644
index 2411beff89..0000000000
--- a/includes/deferred/SqlDataUpdate.php
+++ /dev/null
@@ -1,40 +0,0 @@
-<?php
-/**
- * Base code for update jobs that put some secondary data extracted
- * from article content into the database.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-use Wikimedia\Rdbms\IDatabase;
-
-/**
- * @deprecated Since 1.28 Use DataUpdate directly, injecting the database
- */
-abstract class SqlDataUpdate extends DataUpdate {
-	/** @var IDatabase Database connection reference */
-	protected $mDb;
-	/** @var array SELECT options to be used (array) */
-	protected $mOptions = [];
-
-	public function __construct() {
-		parent::__construct();
-
-		$this->mDb = wfGetLB()->getLazyConnectionRef( DB_MASTER );
-	}
-}