From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 16 Jul 2014 02:10:57 +0000 (+0200)
Subject: mw.loader: Optimise away duplicate else branches in getMarker()
X-Git-Tag: 1.31.0-rc.0~14873
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=fb10a65d1286ae5455a5a2ddf202e05d87757ae6;p=lhc%2Fweb%2Fwiklou.git

mw.loader: Optimise away duplicate else branches in getMarker()

Change-Id: I2ea541c16befd3ea7ff2d23c6e059ac66d8ebb88
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index 9061acdf4f..b22e24019e 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -652,18 +652,14 @@
 			/* Private methods */
 
 			function getMarker() {
-				// Cached ?
-				if ( $marker ) {
-					return $marker;
-				}
-
-				$marker = $( 'meta[name="ResourceLoaderDynamicStyles"]' );
-				if ( $marker.length ) {
-					return $marker;
+				// Cached
+				if ( !$marker ) {
+					$marker = $( 'meta[name="ResourceLoaderDynamicStyles"]' );
+					if ( !$marker.length ) {
+						mw.log( 'No <meta name="ResourceLoaderDynamicStyles"> found, inserting dynamically' );
+						$marker = $( '<meta>' ).attr( 'name', 'ResourceLoaderDynamicStyles' ).appendTo( 'head' );
+					}
 				}
-				mw.log( 'getMarker> No <meta name="ResourceLoaderDynamicStyles"> found, inserting dynamically.' );
-				$marker = $( '<meta>' ).attr( 'name', 'ResourceLoaderDynamicStyles' ).appendTo( 'head' );
-
 				return $marker;
 			}