From: Kaldari <rkaldari@wikimedia.org>
Date: Fri, 28 Apr 2017 20:45:25 +0000 (-0700)
Subject: Adding explantation for why to use User::incEditCount()
X-Git-Tag: 1.31.0-rc.0~3380^2
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=d4863dea270c4d12d742991e48fc067c7890413d;p=lhc%2Fweb%2Fwiklou.git

Adding explantation for why to use User::incEditCount()

... rather than User::incEditCountImmediate() for most cases.

Change-Id: Ia16baabaeaca5c726e1dd1fc2506dc0b85500b6e
---

diff --git a/includes/user/User.php b/includes/user/User.php
index 3edd49f783..3d6cbe4401 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -5077,6 +5077,9 @@ class User implements IDBAccessObject {
 
 	/**
 	 * Deferred version of incEditCountImmediate()
+	 *
+	 * This function, rather than incEditCountImmediate(), should be used for
+	 * most cases as it avoids potential deadlocks caused by concurrent editing.
 	 */
 	public function incEditCount() {
 		wfGetDB( DB_MASTER )->onTransactionPreCommitOrIdle(