From: Alexandre Emsenhuber <ialex.wiki@gmail.com>
Date: Tue, 30 Apr 2013 18:51:26 +0000 (+0200)
Subject: Remove LocalisationCache::unloadAll() call from NewParserTest::addDBData()
X-Git-Tag: 1.31.0-rc.0~19800^2
X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=91a5ea4e5cadc4ffbdbf4fb47a143650921d9d59;p=lhc%2Fweb%2Fwiklou.git

Remove LocalisationCache::unloadAll() call from NewParserTest::addDBData()

- Localisation cache does not depend on the database, only on the
  localisation files themselves
- the backend is already set to LCStore_Null, so it will not interfere
  with other caches (CDB, database, etc.)

Unloading the whole cache before each test thus only adds overhead
without any benefit, and slows down the test suite (this changes allows
to win about 20 seconds on my local machine).

Change-Id: Ifa36a7135d9f8355e1a10dd49ece806d90f657a2
---

diff --git a/tests/phpunit/includes/parser/NewParserTest.php b/tests/phpunit/includes/parser/NewParserTest.php
index 994bc1cce6..3449cc73c0 100644
--- a/tests/phpunit/includes/parser/NewParserTest.php
+++ b/tests/phpunit/includes/parser/NewParserTest.php
@@ -190,9 +190,6 @@ class NewParserTest extends MediaWikiTestCase {
 			__METHOD__
 		);
 
-		# Reinitialise the LocalisationCache to match the database state
-		Language::getLocalisationCache()->unloadAll();
-
 		# Clear the message cache
 		MessageCache::singleton()->clear();