From: umherirrender Date: Sat, 27 Sep 2014 10:05:29 +0000 (+0200) Subject: Fix GitInfoTest::testValidJsonData on windows X-Git-Tag: 1.31.0-rc.0~13746 X-Git-Url: http://git.cyclocoop.org//%27%40script%40/%27?a=commitdiff_plain;h=748721a3347b7992ba44078c669d59bea5f6852c;p=lhc%2Fweb%2Fwiklou.git Fix GitInfoTest::testValidJsonData on windows GitInfo.php is replacing DIRECTORY_SEPARATOR by '-'. On windows this is \, which was not set in the tests. 1) GitInfoTest::testValidJsonData Failed asserting that false is true. Change-Id: I1871c342b61a335b59a98755d8b824cc58c1543e --- diff --git a/tests/phpunit/includes/GitInfoTest.php b/tests/phpunit/includes/GitInfoTest.php index e22f50507e..c3539d0e7d 100644 --- a/tests/phpunit/includes/GitInfoTest.php +++ b/tests/phpunit/includes/GitInfoTest.php @@ -10,7 +10,7 @@ class GitInfoTest extends MediaWikiTestCase { } public function testValidJsonData() { - $dir = $GLOBALS['IP'] . '/testValidJsonData'; + $dir = $GLOBALS['IP'] . DIRECTORY_SEPARATOR . 'testValidJsonData'; $fixture = new GitInfo( $dir ); $this->assertTrue( $fixture->cacheIsComplete() );