We check self::$pageCount, then assign it to another array, and return it from that...

Not ever caching stuff further

Follows up some ancient revisions

diff --git a/includes/SiteStats.php b/includes/SiteStats.php
index d66407b..f0abd82 100644 (file)
--- a/includes/SiteStats.php
+++ b/includes/SiteStats.php
@@ -179,7 +179,7 @@ class SiteStats {
                wfProfileIn( __METHOD__ );
                if( !isset( self::$pageCount[$ns] ) ) {
                        $dbr = wfGetDB( DB_SLAVE );
-                       $pageCount[$ns] = (int)$dbr->selectField(
+                       self::$pageCount[$ns] = (int)$dbr->selectField(
                                'page',
                                'COUNT(*)',
                                array( 'page_namespace' => $ns ),
@@ -187,7 +187,7 @@ class SiteStats {
                        );
                }
                wfProfileOut( __METHOD__ );
-               return $pageCount[$ns];
+               return self::$pageCount[$ns];
        }
 
        /**