Improved vague/incomplete $1 thumb.php error messages
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 8 Jan 2014 09:38:42 +0000 (01:38 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Sat, 18 Jan 2014 02:20:17 +0000 (18:20 -0800)
Change-Id: I64d05e25f82242e92abbcbf20252fc17d5790d8b

includes/media/Bitmap.php

index 1be04a7..7f108c8 100644 (file)
@@ -187,7 +187,9 @@ class BitmapHandler extends ImageHandler {
                                        wfHostname(), $image->getName() ) );
 
                        return new MediaTransformError( 'thumbnail_error',
-                               $scalerParams['clientWidth'], $scalerParams['clientHeight'] );
+                               $scalerParams['clientWidth'], $scalerParams['clientHeight'],
+                               wfMessage( 'filemissing' )->text()
+                       );
                }
 
                # Try a hook
@@ -227,7 +229,9 @@ class BitmapHandler extends ImageHandler {
                } elseif ( $removed ) {
                        # Thumbnail was zero-byte and had to be removed
                        return new MediaTransformError( 'thumbnail_error',
-                               $scalerParams['clientWidth'], $scalerParams['clientHeight'] );
+                               $scalerParams['clientWidth'], $scalerParams['clientHeight'],
+                               wfMessage( 'unknown-error' )->text()
+                       );
                } elseif ( $mto ) {
                        return $mto;
                } else {