jenkins-bot [Mon, 26 Mar 2018 17:25:13 +0000 (17:25 +0000)]
Merge "Stop test from randomly failing"
jenkins-bot [Mon, 26 Mar 2018 17:21:48 +0000 (17:21 +0000)]
Merge "ParserTest: clear Language namespaces cache"
jenkins-bot [Mon, 26 Mar 2018 17:16:55 +0000 (17:16 +0000)]
Merge "PostgresUpdater: Rename custom "dropIndex" to "dropPgIndex""
Aryeh Gregor [Mon, 26 Mar 2018 17:08:22 +0000 (20:08 +0300)]
Stop test from randomly failing
The difference between two integers is less than 1 only if it's 0, so
the test as-is will fail whenever the second changes between when '1
day' is evaluated when inserting the block, and when time() is called
for the assert.
Change-Id: Ic76ff05729129b74345696879a934253525213fa
jenkins-bot [Mon, 26 Mar 2018 16:42:04 +0000 (16:42 +0000)]
Merge "Improve test coverage for ApiBlock.php to 100%"
Brad Jorsch [Mon, 26 Mar 2018 16:14:50 +0000 (12:14 -0400)]
PostgresUpdater: Rename custom "dropIndex" to "dropPgIndex"
There doesn't seem to be any reason this shouldn't follow the naming
conventions of other PG-specific schema change functions, and Ie9dbda329
shows that difference can be confusing.
Change-Id: Ie3e0d5b130486aa9ab5eebd879dca846dfa99584
jenkins-bot [Mon, 26 Mar 2018 15:18:31 +0000 (15:18 +0000)]
Merge "Improve test coverage for ApiDelete.php"
Aryeh Gregor [Sun, 18 Mar 2018 18:48:51 +0000 (20:48 +0200)]
Improve test coverage for ApiBlock.php to 100%
The code coverage tool still reports that line 50 ("$status,") is not
covered, but this is just a parameter to a function that is in fact
called and does show up as covered, so I'm pretty sure it's a bug.
I replaced a couple of sanity checks that reported "incomplete" on
failure with actual assertions so that the test would fail properly if
the sanity check failed.
The testing could still probably be expanded considerably.
Change-Id: Ib6ba7227af23bcb50c7e3bafb0b51395e8acf03f
Aryeh Gregor [Sun, 18 Mar 2018 19:58:02 +0000 (21:58 +0200)]
Improve test coverage for ApiDelete.php
Still missing a test for file deletion, because I didn't figure out a
simple way to create a file page that I can test on.
Change-Id: I276e84b4f7777e5dd5be5520e572b9b9bb0c0633
Antoine Musso [Sun, 25 Mar 2018 13:34:05 +0000 (15:34 +0200)]
ParserTest: clear Language namespaces cache
The content language object has a cache for namespaces, it might then
not take in account $wgExtraNamespaces set by the parser test suite
which causes unknown namespaces errors.
Ensure the new language object has a clean cache.
Repro:
php phpunit.php --filter '(ParserMethodsTest::testValidCovers|T53680)'
Bug: T190554
Change-Id: I9c4104d7bb3a0c84b60d7e7b4154743cbe58348c
L10n-bot [Sat, 24 Mar 2018 21:50:04 +0000 (21:50 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 24 Mar 2018 20:58:12 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia630a3bdf2b4cffe2cf30f9c1342e39f03ecc8f2
jenkins-bot [Sat, 24 Mar 2018 19:11:32 +0000 (19:11 +0000)]
Merge "Fix typo in word visibility"
Ghybu [Wed, 21 Mar 2018 22:22:09 +0000 (22:22 +0000)]
Modify {{#language:ku}}: Kurdî should be written lower-case instead
Bug: T190205
Change-Id: Ieacc885a99d825403c65a2caa36f9011125ad9ce
jenkins-bot [Sat, 24 Mar 2018 00:22:10 +0000 (00:22 +0000)]
Merge "Update OOUI to v0.26.1"
James D. Forrester [Fri, 23 Mar 2018 23:55:39 +0000 (16:55 -0700)]
Update OOUI to v0.26.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.26.1
Depends-On: Ia4bd9eb5c3909fd1fa8b7ee41a0401c328eaecaa
Change-Id: Ia4bd9eb5c3909fd1fa8b7ee41a0401c328eaecab
L10n-bot [Fri, 23 Mar 2018 20:59:26 +0000 (20:59 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 23 Mar 2018 20:57:10 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8dece83a516a5d8a87144a2ffba23b0845ff6992
Umherirrender [Fri, 23 Mar 2018 20:18:27 +0000 (21:18 +0100)]
Fix typo in word visibility
Change-Id: Ife02b0a790bc72de0e01ddf89de457ccdd9a7deb
jenkins-bot [Fri, 23 Mar 2018 18:38:09 +0000 (18:38 +0000)]
Merge "resourceloader: Document 'target' query param in StartupModule"
jenkins-bot [Fri, 23 Mar 2018 17:34:10 +0000 (17:34 +0000)]
Merge "Improve test coverage for ApiLogin.php"
jenkins-bot [Fri, 23 Mar 2018 15:23:04 +0000 (15:23 +0000)]
Merge "SECURITY: Fix variable usage in ApiQueryUserContributions"
Brad Jorsch [Fri, 23 Mar 2018 13:31:31 +0000 (09:31 -0400)]
SECURITY: Fix variable usage in ApiQueryUserContributions
$from was being used instead of $fromName in the handling for
ucuserprefix, causing broken SQL.
Bug: T190507
Change-Id: I0759637ea5f35853271167ca0aaaabd3b7ab69f9
addshore [Thu, 22 Mar 2018 16:36:25 +0000 (16:36 +0000)]
Add missing ActorMigration use statement to MediaWikiServices
Change-Id: Iee26b383a56085b51455c79a829e75762b7ae78e
jenkins-bot [Fri, 23 Mar 2018 10:58:01 +0000 (10:58 +0000)]
Merge "Move most User::clearAllNotifications() logic to WatchedItemStore"
jenkins-bot [Fri, 23 Mar 2018 10:51:03 +0000 (10:51 +0000)]
Merge "Uncomment and fix a test"
jenkins-bot [Fri, 23 Mar 2018 10:34:37 +0000 (10:34 +0000)]
Merge "rdbms: remove Database::ignoreErrors()"
Aaron Schulz [Fri, 2 Mar 2018 20:42:57 +0000 (12:42 -0800)]
Move most User::clearAllNotifications() logic to WatchedItemStore
Change-Id: Ib1b0c40e408f6fad6fc8257c5073fa1c3c264c3a
jenkins-bot [Fri, 23 Mar 2018 10:07:46 +0000 (10:07 +0000)]
Merge "mediawiki.language: Implement non-digit-grouping of four-digit numbers"
Aaron Schulz [Fri, 23 Mar 2018 10:07:27 +0000 (03:07 -0700)]
rdbms: remove Database::ignoreErrors()
The only caller was reportQueryError(), which did not use it
as a mutator. Make that method use getFlag() directly.
Change-Id: I8e7991f7bd41cdd33a925a55269ce87764c30742
jenkins-bot [Fri, 23 Mar 2018 01:41:28 +0000 (01:41 +0000)]
Merge "Add missing return types to User::getOption()"
Sam Wilson [Fri, 23 Mar 2018 01:14:41 +0000 (09:14 +0800)]
Add missing return types to User::getOption()
String zeros are converted to ints, and email-blacklist returns
an array of integers.
Change-Id: I2ac2a4e8effd4816e9c1e835b86241c7fe850605
Ed Sanders [Fri, 23 Mar 2018 00:42:46 +0000 (00:42 +0000)]
Remove 0.8em default overlay hack
This fixes the font size on Special:ApiSandbox when expanded.
Change-Id: I72d825f0da014383f5b82272a816f09f41c6027b
jenkins-bot [Fri, 23 Mar 2018 00:03:20 +0000 (00:03 +0000)]
Merge "rdbms: make getMasterPos() ignore GTIDs outside of gtid_domain_id"
Aaron Schulz [Wed, 7 Feb 2018 10:15:54 +0000 (02:15 -0800)]
rdbms: make getMasterPos() ignore GTIDs outside of gtid_domain_id
* Filter out GTIDs with a domain that is not the one binlog
events would be written to if the Database handle was given
write queries. Likewise for the MariaDB server_id component.
* Also improve MySQL GTID support to better match that of MariaDB.
This covers position retrieval, replication waiting, and ranges
in GTIDs (which are almost always present).
* Make some MySQLMasterPos variables private by making use of
accesors instead.
* Store the gtids array keyed by domain ID for convenience.
* Clean up dynamic call to static method.
Change-Id: Ic6ab517bc8f200c968ff892ade69ad1b9394ab21
Ed Sanders [Thu, 22 Mar 2018 22:34:50 +0000 (22:34 +0000)]
Use OOUI's checkAll instead of doubleCheck from Echo
Not least because Echo might not be installed.
Change-Id: I44a439c6b924b8d88585ea7a2e613d505e16724f
jenkins-bot [Thu, 22 Mar 2018 21:40:07 +0000 (21:40 +0000)]
Merge "User: Fully clear instance variables when loading not-blocked status"
jenkins-bot [Thu, 22 Mar 2018 21:27:08 +0000 (21:27 +0000)]
Merge "rdbms: IDatabase interface cleanups"
jenkins-bot [Thu, 22 Mar 2018 21:16:12 +0000 (21:16 +0000)]
Merge "mediawiki.ui: Update mw-ui-input padding/line-height to match OOUI"
Translation updater bot [Thu, 22 Mar 2018 20:53:16 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib6ba336283368bb086c8f1225ac2b7a94b2ec338
jenkins-bot [Thu, 22 Mar 2018 19:34:02 +0000 (19:34 +0000)]
Merge "rdbms: Add ATOMIC_CANCELABLE flag for micro-optimization"
Brad Jorsch [Thu, 22 Mar 2018 16:52:59 +0000 (12:52 -0400)]
User: Fully clear instance variables when loading not-blocked status
If a block is deleted and ->clearInstanceCache() is called to try to
make an existing User object reflect that fact, some methods are still
reflecting the old block.
To fix this, User::getBlockedStatus() needs to clear all the relevant
instance variables if the user is found not to be blocked.
Change-Id: I6ad8d5555a4c8519336aded3067e5034831dadf3
Ed Sanders [Thu, 22 Mar 2018 18:50:27 +0000 (18:50 +0000)]
mediawiki.ui: Update mw-ui-input padding/line-height to match OOUI
Change-Id: Ic67973f994fd28b1e5f09ddf203a3217a705befb
Aaron Schulz [Thu, 22 Mar 2018 15:33:59 +0000 (08:33 -0700)]
rdbms: IDatabase interface cleanups
* Move schema-change related methods listTables(), indexUnique(),
and fieldInfo() to IMaintainableDatabase
* Deprecate doneWrites()
* Remove reportQueryError() and reportConnectionError(),
leaving them to Database
Bug: T190396
Change-Id: I96f298d5a6eca67f5a289f205406bf3135ece62d
Amir Sarabadani [Thu, 22 Mar 2018 12:57:28 +0000 (13:57 +0100)]
Do not assume rc_patrolled is binary in ChangesListSpecialPage
Bug: T184791
Change-Id: Idd9fc4b37da2d862f84d3aacd9966872958bc9eb
Brad Jorsch [Tue, 20 Mar 2018 15:57:04 +0000 (11:57 -0400)]
rdbms: Add ATOMIC_CANCELABLE flag for micro-optimization
Aaron is concerned about the extra time added to atomic sections within
an outer transaction if we do a SAVEPOINT and RELEASE. He wants a flag
so callers have to specifically opt-in to use of savepoints.
Change-Id: I64cf5033ced464863d28dd49d9173856a9c1e1c0
Brad Jorsch [Sat, 17 Mar 2018 21:59:56 +0000 (17:59 -0400)]
rdbms: Add IDatabase::cancelAtomic()
Atomic sections are currently useful if you want to wrap some SQL
statements in a transaction when you might be called from inside someone
else's transaction, and you expect the caller to roll back everything if
you fail.
But there are some cases where you want to allow the caller to recover
from errors, in which case you need to roll back just the atomic
section. Savepoints are supported by all our databases and can be used
for this purpose, so let's do so.
Bug: T188660
Change-Id: Iee548619df89fd7fbd581b01106b8b41d3df71cc
Timo Tijhof [Thu, 22 Mar 2018 03:34:40 +0000 (20:34 -0700)]
resourceloader: Document 'target' query param in StartupModule
Bug: T127268
Change-Id: I38150b2d82420f5058137d611c63e07cbd9c2f96
jenkins-bot [Thu, 22 Mar 2018 01:07:06 +0000 (01:07 +0000)]
Merge "rdbms: clean up DBO_TRX behavior for onTransactionPreCommitOrIdle()"
jenkins-bot [Thu, 22 Mar 2018 01:05:05 +0000 (01:05 +0000)]
Merge "rdbms: cleanup runMasterPostTrxCallbacks() transaction check"
Translation updater bot [Wed, 21 Mar 2018 21:16:38 +0000 (22:16 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaf3c46a2ead6b5cb3758c5c779b90c213aedfeee
jenkins-bot [Wed, 21 Mar 2018 20:56:22 +0000 (20:56 +0000)]
Merge "Convert OutputHandler functions to a class"
jenkins-bot [Wed, 21 Mar 2018 20:37:20 +0000 (20:37 +0000)]
Merge "Clarify -{ => {{ transition"
jenkins-bot [Wed, 21 Mar 2018 19:55:47 +0000 (19:55 +0000)]
Merge "Update OOUI to v0.26.0"
jenkins-bot [Wed, 21 Mar 2018 19:52:37 +0000 (19:52 +0000)]
Merge "exception: Improve formatting of fatal error log messages"
jenkins-bot [Wed, 21 Mar 2018 19:39:25 +0000 (19:39 +0000)]
Merge "rdbms: fix bogus $fname parameter in LoadMonitorMySQL"
Gergő Tisza [Fri, 16 Mar 2018 02:40:07 +0000 (19:40 -0700)]
exception: Improve formatting of fatal error log messages
Use human-readable stack trace instead of array dump,
try to display the URL and the request ID, use the same
message format as exceptions,
Bug: T189851
Change-Id: I3edf2dbd5639ceecc668719c065ecdce33157ff5
Krinkle [Wed, 21 Mar 2018 19:21:13 +0000 (19:21 +0000)]
Merge "parser: Update MWTidy::checkErrors() error message"
Volker E [Wed, 21 Mar 2018 00:36:37 +0000 (17:36 -0700)]
Update OOUI to v0.26.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.26.0
Depends-on: Ic1d39a0ea9d44638f8af174592cee070bad89cc7
Change-Id: Ib4789239c10c2c505af8a743cd6f4474fcabe446
jenkins-bot [Wed, 21 Mar 2018 19:11:31 +0000 (19:11 +0000)]
Merge "Update purtle to 1.0.7"
Stanislav Malyshev [Wed, 21 Mar 2018 18:39:55 +0000 (11:39 -0700)]
Update purtle to 1.0.7
Companion vendor change is https://gerrit.wikimedia.org/r/c/420911/
Bug: T185589
Change-Id: Ic3b4e902c212adbd25f7364259e3767d4e1dfb7a
Aryeh Gregor [Tue, 20 Mar 2018 15:43:01 +0000 (17:43 +0200)]
Improve test coverage for ApiLogin.php
I only made one small addition, because I don't understand login/session
code well enough to easily do more.
Change-Id: I36c5ea8e31fb00d75da24c38381f74ba8a15f31a
jenkins-bot [Wed, 21 Mar 2018 17:04:20 +0000 (17:04 +0000)]
Merge "Test ApiDisabled.php"
jenkins-bot [Wed, 21 Mar 2018 16:45:33 +0000 (16:45 +0000)]
Merge "rdbms: make selectRowCount() use $var argument to exclude NULLs"
jenkins-bot [Wed, 21 Mar 2018 15:17:06 +0000 (15:17 +0000)]
Merge "Selenium: Replace nodemw with mwbot"
jenkins-bot [Wed, 21 Mar 2018 14:42:37 +0000 (14:42 +0000)]
Merge "Selenium: Do not run CirrusSearch smoke tests in Jenkins"
jenkins-bot [Wed, 21 Mar 2018 14:37:30 +0000 (14:37 +0000)]
Merge "Selenium: Upgrade WebdriverIO to 4.12.0"
Željko Filipin [Fri, 9 Mar 2018 12:34:28 +0000 (13:34 +0100)]
Selenium: Replace nodemw with mwbot
Bug: T181284
Change-Id: I012a5cc6a7f30a8652cbad87293eb119fa2e405f
Depends-On: Ic69be92c2b0b7a08a9b8cc417a40ebb38f249ea3
Željko Filipin [Tue, 13 Mar 2018 13:30:43 +0000 (14:30 +0100)]
Selenium: Upgrade WebdriverIO to 4.12.0
Bug: T180144
Change-Id: I8d34e2240fe76798c99315a54ea5bab63b2409e9
Depends-On: Ic69be92c2b0b7a08a9b8cc417a40ebb38f249ea3
Željko Filipin [Tue, 20 Mar 2018 17:54:53 +0000 (18:54 +0100)]
Selenium: Do not run CirrusSearch smoke tests in Jenkins
Bug: T190039
Change-Id: I3b6ce071ce69ef3d6ea719d875428422f9ad7e6d
Depends-On: Ic69be92c2b0b7a08a9b8cc417a40ebb38f249ea3
Željko Filipin [Wed, 21 Mar 2018 12:15:01 +0000 (13:15 +0100)]
Lock postcss-less to v1.1.3 because v 1.1.4 breaks CI
mediawiki-core-npm-node-6-docker Jenkins job is failing with
`Warning: Task "stylelint:src" failed.`
Bug: T190269
Change-Id: Ic69be92c2b0b7a08a9b8cc417a40ebb38f249ea3
Timo Tijhof [Sun, 18 Mar 2018 04:03:42 +0000 (21:03 -0700)]
Convert OutputHandler functions to a class
* Convert OutputHandler.php from global functions to a class.
- wfOutputHandler → OutputHandler::handle
(no alias, no usage outside core)
- wfGzipHandler → OutputHandler::handleGzip
(private, no usage outside class)
- wfRequestExtension → OutputHandler::findUriExtension
(private, no usage outside class)
- wfMangleFlashPolicy → OutputHandler::mangleFlashPolicy
(private, no usage outside class)
- wfDoContentLength → OutputHandler::emitContentLength
(private, no usage outside class)
- wfHtmlValidationHandler → OutputHandler::validateAllHtml
(private, no usage outside class)
* Add the class to autoload.php for exposure outside WebStart.
Specifically, for use in ApiFormatPhpTest. This also removes the
need to manually load the class because this code runs after
Setup.php loads AutoLoader.php.
Bug: T189966
Change-Id: I27a41ec0ae0ee30aeb313a616323b967605c4055
Timo Tijhof [Sun, 18 Mar 2018 04:33:32 +0000 (21:33 -0700)]
parser: Update MWTidy::checkErrors() error message
When setting the following on PHP 7, the produced error message
did not make sense (references something about HHVM).
> $wgValidateAllHtml = true
> $wgTidyConfig = ['driver' => 'RemexHtml'];
Change-Id: I5f14505639a79aca66f570a9a00c38cdea0cc1ba
jenkins-bot [Wed, 21 Mar 2018 00:29:39 +0000 (00:29 +0000)]
Merge "HTMLSizeFilterField: Add OOUI version"
Timo Tijhof [Mon, 5 Mar 2018 23:15:24 +0000 (15:15 -0800)]
resourceloader: Remove redundant state assignment for styles in ClientHtml
The same variable index was set to the same value from two places,
one unconditionally, and two times within a conditional block after
the first one.
The second ones are a completely redundant remnant from a refactor
sometime last year.
Change-Id: Ia234d4aca398b1b365d457a439d9e449229f28fb
Translation updater bot [Tue, 20 Mar 2018 20:56:11 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie14e1f3bd7c920c93c0fb9d73619985125a5fc08
jenkins-bot [Tue, 20 Mar 2018 20:20:08 +0000 (20:20 +0000)]
Merge "rdbms: upgrade transaction misuse warnings to exceptions"
jenkins-bot [Tue, 20 Mar 2018 17:51:28 +0000 (17:51 +0000)]
Merge "phpunit: Add some @covers and @large/@medium to integration tests"
Aaron Schulz [Fri, 9 Mar 2018 00:58:48 +0000 (16:58 -0800)]
rdbms: upgrade transaction misuse warnings to exceptions
The last warnings in logstash for WMF have been cleaned up
Change-Id: I7d5bb624bc583191c3a0c95aa4e99322d6d5008c
Timo Tijhof [Tue, 20 Mar 2018 16:14:34 +0000 (09:14 -0700)]
phpunit: Add some @covers and @large/@medium to integration tests
- @small: single class, no I/O (unit test).
- @medium: multi-class (partial or no mocks), no I/O (unit/integration test).
- @large: multi-class, I/O allowed (integration test).
Change-Id: I09317e6dd9b0ee34b7467fbffdd07957ef55dc04
Subramanya Sastry [Tue, 20 Mar 2018 16:09:40 +0000 (11:09 -0500)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
3f79aa9fd48e68d32d1b9bdc3e29ec4536f297b8
Change-Id: I12249e39ddc6e3344a9dd8a1545b129ed469e184
Aryeh Gregor [Tue, 20 Mar 2018 16:01:07 +0000 (18:01 +0200)]
Test ApiDisabled.php
Locally this reports that everything is covered, although the get*()
functions are not registering at all (white backgrounds).
Change-Id: I73fabfb33b329dc3416368fda52d35f7ee6a4a18
jenkins-bot [Tue, 20 Mar 2018 15:26:06 +0000 (15:26 +0000)]
Merge "RFC T157418: Trim whitespace in table cells, list items, headings"
Aaron Schulz [Tue, 20 Mar 2018 14:46:16 +0000 (07:46 -0700)]
rdbms: fix bogus $fname parameter in LoadMonitorMySQL
Change-Id: Ib8862532362da148ddd6296646fba7483c6463d5
jenkins-bot [Tue, 20 Mar 2018 12:06:32 +0000 (12:06 +0000)]
Merge "MCR: replace slot_inherited with slot_origin"
jenkins-bot [Tue, 20 Mar 2018 11:19:51 +0000 (11:19 +0000)]
Merge "Revert "Selenium: configuration file for beta cluster""
Zfilipin [Tue, 20 Mar 2018 11:12:27 +0000 (11:12 +0000)]
Revert "Selenium: configuration file for beta cluster"
This reverts commit
3d2395a2af962b9bb941f3bbd819578f2b6b2d65.
Change-Id: I4ad8958df097a1ef011c0f9d99ea9f7a0030c032
jenkins-bot [Tue, 20 Mar 2018 04:21:12 +0000 (04:21 +0000)]
Merge "Set WebInstaller session variables as globals"
Brion Vibber [Fri, 9 Mar 2018 19:54:19 +0000 (11:54 -0800)]
Fix XMPReader/XMPValidator for PHP 7
Tripped up by old typos being caught in new warnings on
PHP 7.x: was checking a scalar's count when meant to
check its containing array's count, and was using a str
"\0" where a literal 0 should have been used (now considered
non-numeric).
Tested locally on 7.2
Bug: T182365
Change-Id: If79a73032d6b63cc41135ccafb6900aeb7787b02
jenkins-bot [Tue, 20 Mar 2018 02:41:28 +0000 (02:41 +0000)]
Merge "rdbms: add IDatabase::wasConnectionLoss() method"
Gergő Tisza [Tue, 20 Mar 2018 01:35:43 +0000 (18:35 -0700)]
Set WebInstaller session variables as globals
During the install process LocalSettings.php does not exist
yet so globals simply take their values from DefaultSettings.php.
The installer uses the correct settings directly for e.g. database
operations, but this blows up when something tries to use
MediaWikiServices which is hardcoded to work with globals.
Make the installer update the globals to work around this.
Bug: T187586
Change-Id: I042099c399bc58929e83178f61e6e6ca478a3ee6
Aaron Schulz [Mon, 19 Mar 2018 23:20:15 +0000 (16:20 -0700)]
rdbms: clean up DBO_TRX behavior for onTransactionPreCommitOrIdle()
* Make sure cancelled onTransactionPreCommitOrIdle() callbacks do not
run if a transaction round is rolled back and then a second round is
committed. LoadBalancer::rollbackMasterChanges() now always calls
rollback(), which in turn always cleans up such callbacks.
* Remove error logging for rollback() calls when trxLevel = 0; this is
harmless and is sometimes hard to avoid in error handling anyway.
* Add more related unit tests.
Change-Id: I6bdefe8bf8b6630fc252b5bbafe4808758ba1684
Aaron Schulz [Tue, 20 Mar 2018 00:26:49 +0000 (17:26 -0700)]
rdbms: add IDatabase::wasConnectionLoss() method
This takes the logic from wasErrorReissuable(), but puts it under
better name. The way that method was used, as well its comments,
were only about connection loss.
Make wasErrorReissuable() check if there was any error that
does not preclude the ability to retry. This matches the actual
name of the method.
Also improve some other related comments.
Change-Id: I68455d803afb2370897fecab0e79aadbb5d1a740
Aaron Schulz [Tue, 20 Mar 2018 01:08:37 +0000 (18:08 -0700)]
rdbms: define wasLockTimeout() for postgres
Change-Id: Ic54530f0b48fb3e3a42c1e6e95a5a75c6b5c061d
Aaron Schulz [Tue, 20 Mar 2018 00:17:24 +0000 (17:17 -0700)]
rdbms: cleanup runMasterPostTrxCallbacks() transaction check
This does not actually care about pending callbacks, and indeed there
are expected to likely be some (which it runs a few lines later).
Change-Id: If966a518893dedeb48bbeca87daedb417e5abd92
Translation updater bot [Mon, 19 Mar 2018 21:02:15 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I484a2f4f3606d6a6aab12011a8ce7ab7379ea3e6
daniel [Tue, 6 Mar 2018 14:42:43 +0000 (15:42 +0100)]
MCR: replace slot_inherited with slot_origin
Bug: T189004
Change-Id: Ie9dbda3296a71f584c82a5f275098adc225a53d5
jenkins-bot [Mon, 19 Mar 2018 20:45:19 +0000 (20:45 +0000)]
Merge "Rewrite passwordtoopopular message"
jenkins-bot [Mon, 19 Mar 2018 20:43:51 +0000 (20:43 +0000)]
Merge "Pass revision being reverted to edit code"
jenkins-bot [Mon, 19 Mar 2018 20:14:12 +0000 (20:14 +0000)]
Merge "Add default for revision.rev_text_id where missing"