From: Derk-Jan Hartman <hartman@videolan.org>
Date: Wed, 7 Aug 2013 15:29:18 +0000 (+0200)
Subject: Accessibility: Don't arbitrarily override role
X-Git-Tag: 1.31.0-rc.0~19010^2
X-Git-Url: http://git.cyclocoop.org//%22javascript:ModifierStyle%28%27%22.%24id.%22%27%29/%22?a=commitdiff_plain;h=4b560a20b5600fd12c4a040af6918cd287185346;p=lhc%2Fweb%2Fwiklou.git

Accessibility: Don't arbitrarily override role

Role overrides implicit role of an element. Since here we don't know
the original element type that we are overriding, we shouldn't just
set the role. It might break th, li etc items.

In the long term, we should add a jquery.accessibility lib that can
take into account things like this, without having to write a ton of
code.

Bug: 17616
Change-Id: Ie27df93acbc778396ad54abc5bde9abb3268a86d
Follow-up: If59590de159a2756bf5b859ce48a23e1af7650fa
---

diff --git a/resources/jquery/jquery.makeCollapsible.js b/resources/jquery/jquery.makeCollapsible.js
index 5ca0b12678..597aea117a 100644
--- a/resources/jquery/jquery.makeCollapsible.js
+++ b/resources/jquery/jquery.makeCollapsible.js
@@ -363,7 +363,7 @@
 
 			// Attributes for accessibility. This isn't necessary when the toggler is already
 			// an <a> or a <button> etc., but it doesn't hurt either, and it's consistent.
-			$toggleLink.prop( 'tabIndex', 0 ).attr( 'role', 'button' );
+			$toggleLink.prop( 'tabIndex', 0 );
 
 			// Initial state
 			if ( options.collapsed || $collapsible.hasClass( 'mw-collapsed' ) ) {