From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 25 Jul 2019 22:38:50 +0000 (+0100)
Subject: phpunit: Avoid get_class() in MediaWikiCoversValidator
X-Git-Tag: 1.34.0-rc.0~877^2
X-Git-Url: http://git.cyclocoop.org//%22javascript:ModifierStyle%28%27%22.%24id.%22%27%29/%22?a=commitdiff_plain;h=456f051c4495459aee6e143dfa851e29a6028170;p=lhc%2Fweb%2Fwiklou.git

phpunit: Avoid get_class() in MediaWikiCoversValidator

I notice that in CI, the inherited "testValidCovers" often shows
multiple times for test classes as being slow (50ms+).

E.g. from a quibble/php72 job:

> …
> 85ms to run ResourceLoaderWikiModuleTest:testValidCovers
> …

Bug: T225730
Change-Id: I524df134c52173c49ebb2b263a90bb5732255865
---

diff --git a/tests/phpunit/MediaWikiCoversValidator.php b/tests/phpunit/MediaWikiCoversValidator.php
index a79a139c8a..ce3f2e281d 100644
--- a/tests/phpunit/MediaWikiCoversValidator.php
+++ b/tests/phpunit/MediaWikiCoversValidator.php
@@ -33,7 +33,7 @@ trait MediaWikiCoversValidator {
 	 */
 	public function testValidCovers() {
 		$methods = get_class_methods( $this );
-		$class = get_class( $this );
+		$class = static::class;
 		$bad = '';
 		foreach ( $methods as $method ) {
 			if ( strpos( $method, 'test' ) === 0 ) {