From: Tobias Gritschacher <tobias.gritschacher@wikimedia.de>
Date: Mon, 18 Jun 2012 13:11:04 +0000 (+0200)
Subject: (bug 37458) permission errors running BaseDumpTest on Windows
X-Git-Tag: 1.31.0-rc.0~23277^2
X-Git-Url: http://git.cyclocoop.org//%22javascript:ModifierStyle%28%27%22.%24id.%22%27%29/%22?a=commitdiff_plain;h=066c4095e78dfdd31d847e834edf1d7b307f2bca;p=lhc%2Fweb%2Fwiklou.git

(bug 37458) permission errors running BaseDumpTest on Windows

Change-Id: I58264c5f516f8dcb124d753b43a80b0875b0e974
---

diff --git a/tests/phpunit/maintenance/backupPrefetchTest.php b/tests/phpunit/maintenance/backupPrefetchTest.php
index e92b289f0d..6ec802c772 100644
--- a/tests/phpunit/maintenance/backupPrefetchTest.php
+++ b/tests/phpunit/maintenance/backupPrefetchTest.php
@@ -17,11 +17,13 @@ class BaseDumpTest extends MediaWikiTestCase {
 	private $dump = null;
 
 	protected function tearDown() {
-		parent::tearDown();
-
 		if ( $this->dump !== null ) {
 			$this->dump->close();
 		}
+
+		// Bug 37458, parent teardown need to be done after closing the
+		// dump or it might cause some permissions errors.
+		parent::tearDown();
 	}
 
 	/**