Merge "Treat all time values on Special:Watchlist as floats"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 30 Jul 2018 12:27:38 +0000 (12:27 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 30 Jul 2018 12:27:38 +0000 (12:27 +0000)
includes/specials/SpecialWatchlist.php

index 41a059f..5b48f4e 100644 (file)
@@ -777,7 +777,7 @@ class SpecialWatchlist extends ChangesListSpecialPage {
                ] ) );
                asort( $hours );
 
-               $select = new XmlSelect( 'days', 'days', $selectedHours / 24 );
+               $select = new XmlSelect( 'days', 'days', (float)( $selectedHours / 24 ) );
 
                foreach ( $hours as $value ) {
                        if ( $value < 24 ) {
@@ -785,7 +785,7 @@ class SpecialWatchlist extends ChangesListSpecialPage {
                        } else {
                                $name = $this->msg( 'days' )->numParams( $value / 24 )->text();
                        }
-                       $select->addOption( $name, $value / 24 );
+                       $select->addOption( $name, (float)( $value / 24 ) );
                }
 
                return $select->getHTML() . "\n<br />\n";