From b7abfbc9f6b74efdee2efe671cc107dd54b5ecb9 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 3 Mar 2008 19:54:22 +0000 Subject: [PATCH] Revert r31505, r31510 (secureAndSplit hook). This hook doesn't seem well thought out; a hook isn't given clean access to the various possible fields it's likely to want to manipulate, and generally feels a bit rushed. --- docs/hooks.txt | 4 ---- includes/Title.php | 8 ++------ 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/docs/hooks.txt b/docs/hooks.txt index 979e8abb8b..a6f381b509 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -1029,10 +1029,6 @@ $user: user who did the move $pageid: database ID of the page that's been moved $redirid: database ID of the created redirect -'TitleSecureAndSplit': At the end of Title::secureAndSplit() -$title: The Title object -$dbkey: The DB key - 'UndeleteShowRevision': called when showing a revision in Special:Undelete $title: title object related to the revision $rev: revision (object) that will be viewed diff --git a/includes/Title.php b/includes/Title.php index 57d6fea3a5..ea2b197342 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -2102,17 +2102,13 @@ class Title { return false; } - # Hooks can reject titles by returning false - if(!wfRunHooks('TitleSecureAndSplit', array( $this, &$dbkey ))) - return false; - # Fill fields $this->mDbkeyform = $dbkey; $this->mUrlform = wfUrlencode( $dbkey ); $this->mTextform = str_replace( '_', ' ', $dbkey ); - - return true; + + return true; } /** -- 2.20.1