jenkins-bot [Sat, 1 Jun 2019 00:35:12 +0000 (00:35 +0000)]
Merge "Improve changePassword.php error handling"
jenkins-bot [Fri, 31 May 2019 22:00:28 +0000 (22:00 +0000)]
Merge "Allow $conds of IDatabase::selectRow to be a string"
jenkins-bot [Fri, 31 May 2019 20:33:29 +0000 (20:33 +0000)]
Merge "Fix typos in DefaultSettings"
jenkins-bot [Fri, 31 May 2019 20:33:21 +0000 (20:33 +0000)]
Merge "Inline trivial …_internal() methods in Title/UserArray classes"
Umherirrender [Fri, 31 May 2019 19:47:55 +0000 (21:47 +0200)]
Allow $conds of IDatabase::selectRow to be a string
When not having a condition you can pass a empty string or '*'
Change-Id: Id1bb6cf6e6bd89ad2df492e7441253d06fcf2a2d
jenkins-bot [Fri, 31 May 2019 15:51:16 +0000 (15:51 +0000)]
Merge "rdbms: cleanup code for read-only propagation for master connections"
jenkins-bot [Fri, 31 May 2019 10:05:52 +0000 (10:05 +0000)]
Merge "Add CirrusSearch dev dependency to require-dev"
Dayllan Maza [Fri, 31 May 2019 04:07:34 +0000 (00:07 -0400)]
Fix typo in docs
Change-Id: I69085afd4f3475ae6449a0e3683a28ccddf47445
jenkins-bot [Thu, 30 May 2019 23:12:33 +0000 (23:12 +0000)]
Merge "Make sure that each DataUpdate still has outer transaction scope"
jenkins-bot [Thu, 30 May 2019 23:06:52 +0000 (23:06 +0000)]
Merge "rdbms: make resolveDomainID() use more consistent in LoadBalancer"
Aaron Schulz [Wed, 8 May 2019 16:13:37 +0000 (09:13 -0700)]
rdbms: cleanup code for read-only propagation for master connections
Make "readOnlyReason" immediately propagate from LoadBalancer to the
DB handle even when getConnection() with DB_REPLICA yields a master
DB handle. This can happen when the master has a non-zero "load".
Previously, it would not be set until something later used DB_MASTER
with getConnection(). This didn't really effect anything but seemed
confusing.
Short-circuit getLaggedReplicaMode() when the reader index uses the
master DB since there is no chance of lag. Also simplify it to just
calling getReaderIndex(), which since nothing else is needed to set
the "laggedReplicaMode" field.
Also rename "readerIndex" field to "genericReadIndex" and "loads"
field to "genericLoads" for clarity.
Change-Id: I6dc28933d2f94f0de1e8f9c5b2b8d2cf8a1a9d08
jenkins-bot [Thu, 30 May 2019 22:45:20 +0000 (22:45 +0000)]
Merge "rdbms: clean up and refactor ResultWrapper classes"
jenkins-bot [Thu, 30 May 2019 22:11:49 +0000 (22:11 +0000)]
Merge "Consistently use spaces and stars in comments"
Aaron Schulz [Wed, 29 May 2019 21:07:03 +0000 (14:07 -0700)]
Make sure that each DataUpdate still has outer transaction scope
Bug: T221577
Change-Id: I620e461d791416ca37fa9ca4fca501e28d778cf5
Translation updater bot [Thu, 30 May 2019 20:22:58 +0000 (22:22 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib076d5736f1bea05df4c649cddd1b12ea6cc3af4
Erik Bernhardson [Thu, 30 May 2019 19:31:51 +0000 (12:31 -0700)]
Add CirrusSearch dev dependency to require-dev
Adds symfony/yaml for parsing event schemas used by EventBus
as part of the CirrusSearch test suite. The dependency needs to be
added to core to support CI testing extensions that depend on
CirrusSearch.
Bug: T220723
Change-Id: Iddbfb81fb667980470d6872c34a1e63897f1e4af
jenkins-bot [Thu, 30 May 2019 18:09:09 +0000 (18:09 +0000)]
Merge "Cleanup LinkerTest leakage between provider entries"
jenkins-bot [Thu, 30 May 2019 15:35:39 +0000 (15:35 +0000)]
Merge "Fix empty auto-summaries triggering a fatal error."
Fomafix [Thu, 30 May 2019 10:29:37 +0000 (12:29 +0200)]
Consistently use spaces and stars in comments
Change-Id: Ia8e005ec65b5a98b12fc1c079604db175b731a88
daniel [Tue, 21 May 2019 10:16:22 +0000 (12:16 +0200)]
Fix empty auto-summaries triggering a fatal error.
Aka: Streamline Linker::formatAutocomments() and add tests
This uses the "streamlining" for the code proposed by Thiemo
in I38edc1ad7720. I have squashed the two commits, so it now
has his code in Linker, but still has my tests as well as his.
Thiemo wrote on his patch:
This also changes the output in case there is no fragment to link to.
Before an empty `/* */` in a summary this would have created a link to
the page. I would like to argue this is not what a user expects.
Bug: T222628
Change-Id: I05408ede0e20dfd976f4057fc5baab461d2ef769
jenkins-bot [Thu, 30 May 2019 14:24:07 +0000 (14:24 +0000)]
Merge "Revert "Factors out permissions check from User into PermissionManager service""
Kosta Harlan [Thu, 30 May 2019 13:51:37 +0000 (13:51 +0000)]
Revert "Factors out permissions check from User into PermissionManager service"
This reverts commit
7faa7a7420866ec685863c1d6c530bd4999da643.
Reason for revert: T224607
Change-Id: I549810a4cd2e424cc4a438887d2f24614a24cc00
Aaron Schulz [Tue, 7 May 2019 17:57:09 +0000 (10:57 -0700)]
rdbms: make resolveDomainID() use more consistent in LoadBalancer
Use the method in getConnection()/openConnection() and make it
handle the local domain alias as well.
Also:
* Move some code to a new getConnectionIndex() method.
* Make the text of various index/domain exceptions more consistent.
* Improve some auto-commit flag code comments.
Change-Id: I7e0d4f2134ee91ad60b0d34bf01e05115193b04a
Aaron Schulz [Wed, 29 May 2019 21:05:10 +0000 (14:05 -0700)]
Cleanup LinkerTest leakage between provider entries
The problem was that new revisions were being added to the same page
since it is not deleted between each run.
Change-Id: I52e8db8e5ef3cde309c26f928fd44de4e6ec18e4
jenkins-bot [Wed, 29 May 2019 23:01:10 +0000 (23:01 +0000)]
Merge "jquery.suggestions: Do not show suggestions on prefilled values"
Fomafix [Wed, 29 May 2019 09:18:47 +0000 (11:18 +0200)]
jquery.suggestions: Do not show suggestions on prefilled values
Show the suggestions on load only if the current value differs to the
defaultValue from the HTML. This prevents suggestions if there is
already a prefilled value in the input field.
Also direct call $.suggestions.update() instead of trigger a keypress.
This change is a follow-up to
72f61f7a5930cf03d4e8ddde62c2ef627b05dd69.
Bug: T224524
Change-Id: I501596996a20c62d1497bf66e23c7858b58bf4ea
jenkins-bot [Wed, 29 May 2019 21:10:43 +0000 (21:10 +0000)]
Merge "Fix typo in comment about class name"
jenkins-bot [Wed, 29 May 2019 20:21:01 +0000 (20:21 +0000)]
Merge "Print chained exceptions when maintenance script fails."
jenkins-bot [Wed, 29 May 2019 19:36:04 +0000 (19:36 +0000)]
Merge "Add checkDependencies.php"
Thiemo Kreuz [Tue, 28 May 2019 14:07:50 +0000 (16:07 +0200)]
Inline trivial …_internal() methods in Title/UserArray classes
This code is quite old. I can't tell why it was written this way.
But I can see these methods are never used anywhere else. We can as
well inline them.
Change-Id: I252f4d2b2b2da822c8d43ffc1f088f5848034c5e
Umherirrender [Wed, 29 May 2019 19:17:12 +0000 (21:17 +0200)]
Fix typo in comment about class name
Change-Id: I52e2b9f6553f4d3977c609bc1e2bc86c24e0c9c7
jenkins-bot [Wed, 29 May 2019 19:11:38 +0000 (19:11 +0000)]
Merge "parser: list the vary-* flags in the NewPP report HTML comment"
Aaron Schulz [Wed, 29 May 2019 17:55:57 +0000 (10:55 -0700)]
parser: list the vary-* flags in the NewPP report HTML comment
Change-Id: I5a4afba2bfdb5b5b56ba0a01ed8ff444a67fbb1a
jenkins-bot [Wed, 29 May 2019 17:48:23 +0000 (17:48 +0000)]
Merge "WatchedItemStore: Remove deprecated Title param to getNextRevision()"
Vedmaka [Tue, 9 Apr 2019 06:58:04 +0000 (09:58 +0300)]
Factors out permissions check from User into PermissionManager service
The following methods should are factored out of the User class into PermissionManager, leaving only deprecated stubs:
- User::isAllowed -> PermissionManager::userHasRight
- User::getRights -> PermissionManager::getUserPermissions
- User::groupHasPermission -> PermissionManager::groupHasPermission
- User::getGroupPermissions -> PermissionManager::getGroupPermissions
-User::getGroupsWithPermission -> PermissionManager::getGroupsWithPermission
- User::groupHasPermission -> PermissionManager::groupHasPermission
- User::isEveryoneAllowed -> PermissionManager::isEveryoneAllowed
- User::getAllRights -> PermissionManager::getAllPermissions
Depends-On: I258f02e286b6ba0387e1bff540a744fafb03dc55
Depends-On: Ie4cedf457eaaa93ec3055c37539322855e02ce26
Depends-On: Id274f240d687efa61cb9f7a15033ae2a7a532083
Bug: T218558
Bug: T223294
Change-Id: Ia0d840b772ea5f20c9594ce151cc57adc270e48b
Aaron Schulz [Wed, 29 May 2019 03:01:17 +0000 (20:01 -0700)]
rdbms: clean up and refactor ResultWrapper classes
Change-Id: Ib1d71dbbd31e134cf89dca58f7aa77bdddc828c0
Volker E [Wed, 29 May 2019 00:57:59 +0000 (17:57 -0700)]
Update OOUI to v0.32.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.0
Bug: T141320
Bug: T163142
Bug: T169484
Bug: T178950
Bug: T180730
Bug: T203859
Bug: T212186
Bug: T213884
Bug: T215644
Bug: T219479
Bug: T220239
Depends-On: Ia65a8053082ac95bf89cb5484aa64668fb780735
Change-Id: I0a48885642b86950180d1fbe4c7a609d323fb87f
jenkins-bot [Tue, 28 May 2019 22:43:51 +0000 (22:43 +0000)]
Merge "Rename Block to MediaWiki\Block\DatabaseBlock"
Simon Legner [Tue, 28 May 2019 21:59:06 +0000 (23:59 +0200)]
Fix typos in DefaultSettings
Change-Id: I692286d68bdf5585694c8a65d9d9d512f813fb9e
jenkins-bot [Tue, 28 May 2019 21:46:27 +0000 (21:46 +0000)]
Merge "Fix typos in MessageCache"
jenkins-bot [Tue, 28 May 2019 21:39:21 +0000 (21:39 +0000)]
Merge "media: Fix $ext property name in BmpHandler::getThumbType()"
jenkins-bot [Tue, 28 May 2019 19:27:49 +0000 (19:27 +0000)]
Merge "EditPage: Remove unused deprecated method ::submit()"
Simon Legner [Tue, 28 May 2019 19:12:45 +0000 (21:12 +0200)]
Fix typos in MessageCache
Change-Id: I5ede5ad5687144535545248940ca6f676f514900
jenkins-bot [Tue, 28 May 2019 19:15:01 +0000 (19:15 +0000)]
Merge "Hard-deprecate Title::moveTo and friends"
jenkins-bot [Tue, 28 May 2019 19:12:49 +0000 (19:12 +0000)]
Merge "Finish sentence in MultiUsernameFilter documentation"
Derick Alangi [Tue, 28 May 2019 18:27:02 +0000 (19:27 +0100)]
EditPage: Remove unused deprecated method ::submit()
Was deprecated in 1.29 and EditPage::edit() was made available for
use and replacement of this ::submit().
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5C-%5C%3Esubmit%5C(%5C)&i=nope&files=&repos=
The usage of ->submit() in the search link above are not for EditPage
but for other classes.
Change-Id: Ibd65965c785f84e9bda65cfaa2c491310cda8166
Fomafix [Tue, 28 May 2019 18:10:48 +0000 (20:10 +0200)]
mediawiki.action.view.dblClickEdit: Move preventDefault()
Move the preventDefault() into the if-condition to trigger the
preventDefault() only together with the click() trigger.
Change-Id: Icde2187248b8b18cd4fd5085a92d840e1f77b00d
Thalia [Tue, 28 May 2019 17:50:19 +0000 (18:50 +0100)]
Finish sentence in MultiUsernameFilter documentation
Change-Id: I933f54f505e0680346f73293c98624e0f48e9292
jenkins-bot [Tue, 28 May 2019 17:49:08 +0000 (17:49 +0000)]
Merge "Fix doc for $item of ApiQueryBase::addPageSubItem"
Aryeh Gregor [Tue, 16 Apr 2019 13:51:04 +0000 (16:51 +0300)]
Hard-deprecate Title::moveTo and friends
moveSubpages wasn't officially deprecated at all before this release,
but there were no callers in codesearch outside core, so it should be
safe to hard-deprecate.
Bug: T208775
Change-Id: Icea9f1dc45d8bd8c96cc159d631f18c394aab4b7
Fomafix [Sun, 26 May 2019 10:36:26 +0000 (12:36 +0200)]
Remove deprecated mw.language.specialCharacters
mw.language.specialCharacters is deprecated since MediaWiki 1.33.
Change-Id: Idb949a37883e96689cabb734402f3d628851c119
Thiemo Kreuz [Tue, 28 May 2019 14:13:36 +0000 (16:13 +0200)]
media: Fix $ext property name in BmpHandler::getThumbType()
This is not "text", it's a file extension.
Change-Id: I92e3b70805df974e74e8aaa9e780dcb55ff584b9
Thalia [Mon, 13 May 2019 14:18:07 +0000 (15:18 +0100)]
Rename Block to MediaWiki\Block\DatabaseBlock
Keep Block as a deprecated class alias for DatabaseBlock.
Update calls to the Block constructor and Block static
methods from external classes.
Also update documentation in several places that refer to
blocks as Blocks.
Bug: T222737
Change-Id: I6d96b63ca0a84bee19486471e0a16a53a79d768a
Translation updater bot [Tue, 28 May 2019 06:26:07 +0000 (08:26 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I09b242d9bd17495e8b300432290a0af37ddc5fe1
jenkins-bot [Tue, 28 May 2019 02:14:43 +0000 (02:14 +0000)]
Merge "Make improvements to BlockManagerTest"
jenkins-bot [Tue, 28 May 2019 01:57:45 +0000 (01:57 +0000)]
Merge "Make config-outdated-sqlite parameter numbers consistent with config-*-old"
Reedy [Tue, 28 May 2019 01:15:14 +0000 (02:15 +0100)]
Partial revert I0d0ef26f59721039b2c24ab322fa3bf6ab16fea1
The parameter swap in meetsMinimumRequirement wasn't supposed to happen
Change-Id: Icf5b237f336084e7a8d11698cd5ea665305e7f3c
Thalia [Mon, 27 May 2019 21:53:23 +0000 (22:53 +0100)]
Make improvements to BlockManagerTest
Remove reliance on real domain and add more test cases.
Change-Id: Icd67fe8c1c9223a92a3775d34d0453328442d89e
jenkins-bot [Mon, 27 May 2019 21:48:20 +0000 (21:48 +0000)]
Merge "Remove deprecated 'jquery.byteLength' module"
Translation updater bot [Mon, 27 May 2019 19:55:47 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0c369e318495e5b68b64315ac311bde601cc08c2
Timo Tijhof [Mon, 27 May 2019 17:52:54 +0000 (18:52 +0100)]
Remove deprecated 'jquery.byteLength' module
Deprecated since MW 1.31 (
f19c9021a466f414). No longer used
anywhere in Wikimedia Gerrit, and no usage found through mwgrep
either.
Bug: T219342
Change-Id: Ia2fecd68ae01c82f323f6c266230ff3fb2bbe287
jenkins-bot [Mon, 27 May 2019 06:43:07 +0000 (06:43 +0000)]
Merge "Revert "change phabricator URL""
Nikerabbit [Mon, 27 May 2019 06:05:45 +0000 (06:05 +0000)]
Revert "change phabricator URL"
This reverts commit
8b61598b39b3ffe709764bd394d2f113d50aea81.
Reason for revert: phabricator.mediawiki.org doesn't work.
Change-Id: I13909393763f4f154b9119e3916fea52fff371f1
jenkins-bot [Sun, 26 May 2019 21:35:50 +0000 (21:35 +0000)]
Merge "Fix typo of Minimum in variable name"
jenkins-bot [Sun, 26 May 2019 21:33:10 +0000 (21:33 +0000)]
Merge "Update wikimedia/remex-html from 2.0.1 to 2.0.3"
Translation updater bot [Sun, 26 May 2019 19:57:17 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Icf713ed037b9895977bb5c908759ec379fd20fc1
Reedy [Sun, 26 May 2019 19:14:03 +0000 (20:14 +0100)]
Make config-outdated-sqlite parameter numbers consistent with config-*-old
Bug: T224374
Change-Id: Iebfb8299234cc9c66db0ecc4abd0c0a32af63602
Reedy [Sun, 26 May 2019 19:08:18 +0000 (20:08 +0100)]
Fix typo of Minimum in variable name
Change-Id: I0d0ef26f59721039b2c24ab322fa3bf6ab16fea1
Reedy [Sun, 26 May 2019 18:40:06 +0000 (19:40 +0100)]
Update wikimedia/remex-html from 2.0.1 to 2.0.3
https://github.com/wikimedia/remex-html/releases/tag/2.0.3
https://github.com/wikimedia/remex-html/compare/2.0.1...2.0.3
Change-Id: Iaa7212a362b120ca4d9c91f229ad4cabc39cc578
Depends-On: I6b6a45c2cf6dcc1fa03f59bf54d4c759111b3385
jenkins-bot [Sun, 26 May 2019 13:09:04 +0000 (13:09 +0000)]
Merge "Switch empty username logging from warning to debug."
Máté Szabó [Sun, 26 May 2019 12:22:45 +0000 (14:22 +0200)]
Job: Fix typo in exception message for invalid specification
The Job::factory method throws an InvalidArgumentException if a given
job specification is invalid. The error message for this exception was
worded in correctly. This patch improves the message to avoid confusion.
Change-Id: I6cab739263c1d3530c0650823db022dd5a4b60bc
Umherirrender [Fri, 17 May 2019 14:15:31 +0000 (16:15 +0200)]
Fix doc for $item of ApiQueryBase::addPageSubItem
ApiResult::addValue defines mixed for $value
Change-Id: I31881426ce7cb81f6430cccd4252881a154cd161
jenkins-bot [Sat, 25 May 2019 21:50:08 +0000 (21:50 +0000)]
Merge "Rename $search to $engine to match hook docs for SpecialSearchSetupEngine"
jenkins-bot [Sat, 25 May 2019 21:37:35 +0000 (21:37 +0000)]
Merge "Introduce TransactionRoundAwareUpdate interface"
jenkins-bot [Sat, 25 May 2019 21:36:36 +0000 (21:36 +0000)]
Merge "rdbms: fix ChronologyProtector client IDs to not be empty"
Reedy [Sat, 25 May 2019 21:12:45 +0000 (22:12 +0100)]
Rename $search to $engine to match hook docs for SpecialSearchSetupEngine
Bug: T224353
Change-Id: I9629840531183ffd53f2a1c568a8a72c91a30171
Aaron Schulz [Wed, 22 May 2019 18:00:55 +0000 (11:00 -0700)]
rdbms: fix ChronologyProtector client IDs to not be empty
Follow up to
8107fddd8fe3d5
Also improve debug logging and add some unit tests
Bug: T223310
Bug: T223978
Change-Id: I35484385e4da2912bc10f5e8d2fb07cb1097347e
Aaron Schulz [Tue, 21 May 2019 21:52:57 +0000 (14:52 -0700)]
Introduce TransactionRoundAwareUpdate interface
Refactor the deferred update transaction round handling code to use
a new TransactionRoundAwareUpdate interface. Also, rename a few
DeferredUpdates methods so they do not give the impression that
doUpdates() is always called.
Change-Id: Idc4c6d81c4e2ca0ce41bca1e7800f797fa7e37f6
Bill Pirkle [Sat, 25 May 2019 02:14:42 +0000 (21:14 -0500)]
Switch empty username logging from warning to debug.
Change
ddd1d4b9203a added logging when an empty username is
passed to various Linker.php functions. The logging revealed
this occuring on live, but it is occuring frequently and
causing distracting log noise. Switch the logging type from
warning to debug while the root cause is investigated.
Bug: T224050
Change-Id: I93826e486951e992afdf778f446792d3c209996a
jenkins-bot [Fri, 24 May 2019 22:16:07 +0000 (22:16 +0000)]
Merge "AllMessagesTablePager: Use $this->msg instead of wfMessage"
Fomafix [Sat, 9 Jun 2018 17:05:15 +0000 (19:05 +0200)]
AllMessagesTablePager: Use $this->msg instead of wfMessage
Change-Id: I20850e20b2749e4fe3391d5d3fbdb7dadbfced8d
jenkins-bot [Fri, 24 May 2019 21:56:57 +0000 (21:56 +0000)]
Merge "API: Add IGNORE INDEX to avoid bad plan in ApiQueryRevisions"
jenkins-bot [Fri, 24 May 2019 21:39:53 +0000 (21:39 +0000)]
Merge "Rename CDN config variables to be generic, deprecating the old names"
jenkins-bot [Fri, 24 May 2019 21:39:47 +0000 (21:39 +0000)]
Merge "changes: Remove unused FeedUtils::checkPurge method"
James D. Forrester [Wed, 1 Nov 2017 20:55:24 +0000 (13:55 -0700)]
Rename CDN config variables to be generic, deprecating the old names
Hook, methods, classes still to rename where appropriate.
Bug: T104148
Depends-On: Id34339dff88bc6d1863378ac94b96b2d590b891d
Depends-On: I4e2938395bcbf7956b83fff00978f09c61dcfa36
Change-Id: I7a725dae551c867a4fa7c213838d52c7fb862756
Aaron Schulz [Fri, 24 May 2019 21:05:12 +0000 (14:05 -0700)]
Make MediaWiki::preOutputCommit() handle PRESEND deferred updates with the "run" parameter
This means that enqueuable updates (LinksUpdate, LinksDeletionUpdate) will run immediately
at this point rather than be enqueued as jobs. This only affects ApiPurge since the other
callers use either POSTSEND or "false".
Change-Id: I8b6ff6c9a68730374e6d83682e774e4f4bfbf52f
Aaron Schulz [Fri, 24 May 2019 21:01:17 +0000 (14:01 -0700)]
Cleanup DerivedPageDataUpdater::doSecondaryDataUpdates and remove redundant caller option
Change-Id: I8bbc6cd76d035635d47d1158df34c625879a8cc3
Kunal Mehta [Sun, 14 Apr 2019 10:19:12 +0000 (03:19 -0700)]
Add checkDependencies.php
Checks to see whether the specified MediaWiki extensions/skins have all of
their dependencies. Each thing will get a status of:
* 'loaded' (it's already activated in LocalSettings.php, and therefore all
the dependencies are present)
* 'present' (it exists in the filesystem, but not yet activated)
* 'missing' (does not exist in the filesystem)
* 'incompatible-*' (some version requirement is incompatible)
JSON output is available with --json for use in scripts.
Development dependencies will be checked if --dev is provided.
This is roughly based on the logic already existing in the Installer. It may
be worth deduplicating that code in the future.
Bug: T193824
Change-Id: Iae9178225c10b6374484274d8848bbea6621c8c2
jenkins-bot [Fri, 24 May 2019 18:17:21 +0000 (18:17 +0000)]
Merge "languages: Hard deprecate Language::getExtraUserToggles() method"
Derick Alangi [Sat, 23 Feb 2019 17:38:51 +0000 (18:38 +0100)]
languages: Hard deprecate Language::getExtraUserToggles() method
This seems to be still used internally in core but in no extension. Also,
this function really doesn't do anything so hard deprecating in preparation
for removal.
Bug: T62260
Change-Id: I568789483084a97e5b3b462235f3d00c3cb87cf9
jenkins-bot [Fri, 24 May 2019 14:56:29 +0000 (14:56 +0000)]
Merge "Correct typo in Block::chooseBlock documentation"
jenkins-bot [Fri, 24 May 2019 14:51:59 +0000 (14:51 +0000)]
Merge "SpecialBlockList: Merge stylesheet in into 'mediawiki.special' bundle"
Timo Tijhof [Fri, 24 May 2019 14:10:27 +0000 (15:10 +0100)]
SpecialBlockList: Merge stylesheet in into 'mediawiki.special' bundle
Follows-up
d87220349536 and (before that)
15eac4c27939c.
Bug: T191549
Change-Id: I60f227283526cf7e45b2e8e2be17d25bb73d9a27
Thalia [Fri, 24 May 2019 13:52:16 +0000 (14:52 +0100)]
Correct typo in Block::chooseBlock documentation
Change-Id: Ie7cf0a833b38aac71b217f97d4934461acd249fd
jenkins-bot [Fri, 24 May 2019 13:37:43 +0000 (13:37 +0000)]
Merge "resourceloader: Use AND instead of OR for upsert conds in saveFileDependencies()"
Timo Tijhof [Fri, 24 May 2019 13:09:51 +0000 (14:09 +0100)]
changes: Remove unused FeedUtils::checkPurge method
This introduced for use by ChangesFeed::execute(), which in turn
has also been unused for many years – and removed in
6f4d15e385807.
Change-Id: I5ba7ea2b6ff86e4d210b77bf05971c183352424c
Reedy [Thu, 23 May 2019 23:16:42 +0000 (00:16 +0100)]
resourceloader: Use AND instead of OR for upsert conds in saveFileDependencies()
Follows-up
e7b57d881a, which changed it from replace() to upsert()
but lost one of the wrapping arrays in doing so.
Previously updated many more rows than expected on Postgresql, when it
should only be updating individual rows, not all rows that match either
criteria.
SQL query before:
WHERE ((md_module = 'jquery.makeCollapsible.styles') OR (md_skin = 'vector|en-gb'))
SQL query after:
WHERE ((md_module = 'jquery.makeCollapsible.styles' AND md_skin = 'vector|en-gb'))
Not a problem on MySQL as upsert() is implemented differently there.
Bug: T222385
Change-Id: If8a458bf4543b297b3a06f31e09c0e77666bf7e6
Eugene Gvozdetsky [Fri, 24 May 2019 10:37:27 +0000 (12:37 +0200)]
change phabricator URL
bugs.mediawiki.org was changed to phabricator.mediawiki.org because now it is the correct address
Change-Id: Ic7a728ce627ee7e6ef715d4144eb81aaf6f831dc
jenkins-bot [Fri, 24 May 2019 00:24:48 +0000 (00:24 +0000)]
Merge "jquery.suggestions: Trigger keypress on initializing"
jenkins-bot [Thu, 23 May 2019 23:42:36 +0000 (23:42 +0000)]
Merge "Pass in __METHOD__ to upsert() in ResourceLoaderModule::saveFileDependencies()"