jenkins-bot [Thu, 19 Apr 2018 19:01:10 +0000 (19:01 +0000)]
Merge "resourceloader: Support loading group=user modules with addModules()"
jenkins-bot [Thu, 19 Apr 2018 18:48:35 +0000 (18:48 +0000)]
Merge "Deprecate $wgUseAjax in 1.31"
jenkins-bot [Thu, 19 Apr 2018 18:41:13 +0000 (18:41 +0000)]
Merge "Fix handling of ar_length and ar_sha1 in RevisionArchiveRecord."
jenkins-bot [Thu, 19 Apr 2018 18:41:10 +0000 (18:41 +0000)]
Merge "Fix and improve PHPDoc type hints in FileBackend and FileRepo"
Kunal Mehta [Mon, 16 Apr 2018 23:26:48 +0000 (16:26 -0700)]
Deprecate $wgUseAjax in 1.31
This setting was intended to control the legacy AJAX framework, but some
extensions mistakenly used it to control any AJAX functionality at all.
But keeping this around when we're deprecating things like $wgEnableAPI
makes no sense.
[Retro-back-ported after
bf61efd87 had landed in 1.32.]
Change-Id: I7b767478f9fb44236e6514b0e83228d9fb8e856f
jenkins-bot [Thu, 19 Apr 2018 18:22:54 +0000 (18:22 +0000)]
Merge "Remove language as string for DateFormatter::getInstance"
jenkins-bot [Thu, 19 Apr 2018 18:13:21 +0000 (18:13 +0000)]
Merge "API: Fix PHP Warning for "count(): Parameter must be an array""
Fomafix [Wed, 13 Sep 2017 13:47:01 +0000 (15:47 +0200)]
Remove language as string for DateFormatter::getInstance
Change-Id: I677ab561d67b63f0c86f65fadf9319e41444a22a
Timo Tijhof [Thu, 19 Apr 2018 01:39:23 +0000 (02:39 +0100)]
API: Fix PHP Warning for "count(): Parameter must be an array"
Found by the new ApiUserrights test introduced in
5ab1bee6bcf:
> includes/specials/SpecialUserrights.php:462
> includes/specials/SpecialUserrights.php:405
> includes/api/ApiUserrights.php:116
The $tags parameter of the UserrightsPage::doSaveUserGroups()
method must be an array and is not nullable. Fix the caller
to not pass null, but an empty array.
Bug: T182377
Change-Id: Ic9be6a0bddfac023de765c810c07a64d651c33b4
jenkins-bot [Thu, 19 Apr 2018 17:53:45 +0000 (17:53 +0000)]
Merge "Introduce SqlBlobStore::makeAddressFromTextId"
daniel [Wed, 11 Apr 2018 17:07:03 +0000 (19:07 +0200)]
Introduce SqlBlobStore::makeAddressFromTextId
This introduces a convenience method for constructing a blob address
from a text ID. It's the inverse of SqlBlobStore::getTextIdFromAddress
Change-Id: I31b3ee5e40185c754fb2c119eb5edc50b903f5dc
jenkins-bot [Thu, 19 Apr 2018 10:03:52 +0000 (10:03 +0000)]
Merge "Avoid warnings in ObjectCache::newWANCacheFromParams if "channels" is not set""
Thiemo Kreuz [Thu, 19 Apr 2018 08:30:33 +0000 (10:30 +0200)]
Fix and improve PHPDoc type hints in FileBackend and FileRepo
Change-Id: I311b4a6777946b451d70c6fdb2133dbbd73f159f
Aaron Schulz [Thu, 19 Apr 2018 04:38:47 +0000 (21:38 -0700)]
Avoid warnings in ObjectCache::newWANCacheFromParams if "channels" is not set"
Bug: T192473
Change-Id: I150eef62285e99fc1269a58fee3827e5fbb0537b
jenkins-bot [Thu, 19 Apr 2018 05:48:05 +0000 (05:48 +0000)]
Merge "Special:PrefixIndex: Convert to HTMLForm"
jenkins-bot [Thu, 19 Apr 2018 02:25:03 +0000 (02:25 +0000)]
Merge "Remove deprecated function wfShellExecDisabled()"
jenkins-bot [Thu, 19 Apr 2018 02:07:02 +0000 (02:07 +0000)]
Merge "Remove deprecated function wfInitShellLocale()"
jenkins-bot [Thu, 19 Apr 2018 02:03:08 +0000 (02:03 +0000)]
Merge "Follow-up
2c74b043568e: Restore use of 'clearyourcache' message"
Max Semenik [Thu, 19 Apr 2018 01:41:00 +0000 (18:41 -0700)]
Remove deprecated function wfShellExecDisabled()
Deprecated in 1.30, never had many callers.
Change-Id: Ie77c3df696313f691a68f21b15804539ffcc7f88
Max Semenik [Thu, 19 Apr 2018 01:35:41 +0000 (18:35 -0700)]
Remove deprecated function wfInitShellLocale()
Deprecated in 1.30, never had more than 2-3 callers.
Change-Id: Ia023ede41affaf8e1b5fd1fed77cdbcefc9dc243
jenkins-bot [Thu, 19 Apr 2018 01:18:09 +0000 (01:18 +0000)]
Merge "API: Remove 1e3>1 test case from ApiBaseTest"
jenkins-bot [Thu, 19 Apr 2018 00:42:17 +0000 (00:42 +0000)]
Merge "skins: Remove MediaWikiI18N class and QuickTemplate::setTranslator"
jenkins-bot [Thu, 19 Apr 2018 00:25:17 +0000 (00:25 +0000)]
Merge "Remove $wgScriptExtension (deprecated and ignored since 1.25)"
James D. Forrester [Fri, 16 Feb 2018 22:03:44 +0000 (14:03 -0800)]
Remove $wgScriptExtension (deprecated and ignored since 1.25)
* Remove left-over mention of the .php5 entry points in docs.
* Remove dead logic in NoLocalSettings for php5 entry points.
* Remove dead match in WebRequest for php5 entry points (they'd
redirect since 1.25, and not seen by PHP).
Change-Id: Ia0ee8588591860b8fe34030c8503f38e9bce31f3
jenkins-bot [Wed, 18 Apr 2018 23:32:38 +0000 (23:32 +0000)]
Merge "jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles"
jenkins-bot [Wed, 18 Apr 2018 23:32:34 +0000 (23:32 +0000)]
Merge "Remove $wgSiteSupportPage"
mainframe98 [Wed, 18 Apr 2018 16:05:52 +0000 (18:05 +0200)]
Remove $wgSiteSupportPage
This configuration global is not used anywhere in MediaWiki,
and no extensions or skins use this.
The documentation on mediawiki.org states that the functionality
has been replaced by MediaWiki:Sidebar, and $wgNavigationLinks,
which was removed over a decade ago.
Bug: T192467
Change-Id: Iea1f8a688feb1c7aa8d0005f207a13956bddfd4e
Timo Tijhof [Wed, 18 Apr 2018 23:09:53 +0000 (00:09 +0100)]
API: Remove 1e3>1 test case from ApiBaseTest
Follows-up
d3da5e08d35f, which broke PHP 7.1 and PHP 7.2 test jobs.
This isn't about logic in ApiBase, but about PHP's str-to-int
logic which actually varies between PHP5 and PHP7.
One maps it to 1000, the other as strict int 1 (with non-numerical
text chopped off, the same as it would for 1foo).
If we want to support 1e3 as part of the API itself, then we'd
need to parse it ourselves and then add the test back.
Bug: T192425
Change-Id: I6fc43f29425749a1abe785fefa312db6a98ea7cd
Reedy [Wed, 18 Apr 2018 21:23:27 +0000 (22:23 +0100)]
Fix supported mysql version in RELEASE-NOTES
Change-Id: I7e8dd036a7a8403f71208fd4c1302d4e241c6378
Bartosz Dziewoński [Wed, 18 Apr 2018 20:02:49 +0000 (22:02 +0200)]
jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles
These should not be added if a pre-generated toggle was provided in
page HTML.
Follow-up to
46a7aa7e3e8ea98b69ae4bd0aff51465da57bcd3.
Bug: T192140
Change-Id: I4b7a7091c1db3559a474de94f8286c0df0af8a67
Translation updater bot [Wed, 18 Apr 2018 19:55:41 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I61420aa859aeb1ab6ee2f62b5260e0b0dac0685f
jenkins-bot [Wed, 18 Apr 2018 19:52:44 +0000 (19:52 +0000)]
Merge "ImportStreamSource: Replace magic numbers with constants"
daniel [Tue, 17 Apr 2018 16:51:38 +0000 (18:51 +0200)]
Fix handling of ar_length and ar_sha1 in RevisionArchiveRecord.
This makes sure that length and hash are calculated if not known.
This patch also adds missing unit tests for RevisionArchiveRecord,
and consolidates unit tests for the different RevisionRecord
subclasses using a trait.
Bug: T192189
Change-Id: I5e1d17ba96e61e068b6aa5ac9c45ac0f657905a6
jenkins-bot [Wed, 18 Apr 2018 19:33:04 +0000 (19:33 +0000)]
Merge "Reduce some nesting in CryptRand.php"
jenkins-bot [Wed, 18 Apr 2018 18:56:32 +0000 (18:56 +0000)]
Merge "Replace recently introduced mediawiki/at-ease calls"
jenkins-bot [Wed, 18 Apr 2018 18:47:13 +0000 (18:47 +0000)]
Merge "Test ApiMove"
Reedy [Wed, 18 Apr 2018 15:58:02 +0000 (15:58 +0000)]
Follow-up
2c74b043568e: Restore use of 'clearyourcache' message
Bug: T191800
Change-Id: I632fff6489e929847e7abc1d944277e3b0358314
Max Semenik [Wed, 18 Apr 2018 17:43:51 +0000 (10:43 -0700)]
Sync PG version in INSTALL
Change-Id: I31f65bba28e8b600aa275bf287cd73dec98d96dc
jenkins-bot [Wed, 18 Apr 2018 16:22:16 +0000 (16:22 +0000)]
Merge "Setup: Move mbstring.func_overload from WebStart to Setup"
jenkins-bot [Wed, 18 Apr 2018 16:02:08 +0000 (16:02 +0000)]
Merge "Swap mediawiki/at-ease for wikimedia/at-ease"
jenkins-bot [Wed, 18 Apr 2018 15:21:25 +0000 (15:21 +0000)]
Merge "Fix PHPDoc type hints in CacheTime, ParserOptions, and related"
Thiemo Kreuz [Wed, 18 Apr 2018 12:31:13 +0000 (14:31 +0200)]
Fix PHPDoc type hints in CacheTime, ParserOptions, and related
I'm intentionally not touching any code in this patch, only
documentation.
Change-Id: I6975194c218760031789d5335dfbb330017dc6fc
Reedy [Wed, 18 Apr 2018 14:10:42 +0000 (14:10 +0000)]
Replace recently introduced mediawiki/at-ease calls
Change-Id: I1f6b7ed199faf4c8f3a3932731507c18413ad6e6
Reedy [Wed, 18 Apr 2018 12:35:14 +0000 (13:35 +0100)]
Swap mediawiki/at-ease for wikimedia/at-ease
Bump wikimedia/php-session-serializer to v1.0.6
Change-Id: I9ed96a29d6db39206377b45e3d46cb2082587f75
Depends-On: I963a61135d66b8baa4638979fd21077d925276b9
Reedy [Wed, 18 Apr 2018 11:59:13 +0000 (11:59 +0000)]
Reduce some nesting in CryptRand.php
Change-Id: Ic0b7307d66f877a5b1df974f34846857084dc23a
jenkins-bot [Wed, 18 Apr 2018 11:43:22 +0000 (11:43 +0000)]
Merge "mw.widgets.visibleLengthLimit: Apply number conversion to the limit"
jenkins-bot [Wed, 18 Apr 2018 10:53:24 +0000 (10:53 +0000)]
Merge "Fix bad archive file names in ImportableUploadRevisionImporter"
jenkins-bot [Wed, 18 Apr 2018 10:22:11 +0000 (10:22 +0000)]
Merge "Special:ProtectedPages: Use MultiSelectField instead of checks"
Timo Tijhof [Wed, 18 Apr 2018 02:14:30 +0000 (03:14 +0100)]
installer: Clean up ext-dependency jQuery code
Follows-up
c8833d8e8ecc.
* Select the input elements by class to avoid accidentally trigging
on unrelated elements elsewhere on the page in the future, given
the generic selector.
* Use on('change') instead of deprecated change() alias.
* Set properties directly instead of via prop() indirection.
* Get attribute directly instead of via data() indirection.
Change-Id: I5158aa26b5fd7327d6795f0a31bbffbe99043fbf
Prateek Saxena [Mon, 16 Apr 2018 04:33:44 +0000 (10:03 +0530)]
Special:PrefixIndex: Convert to HTMLForm
Most of the code here is from
I98cdfb69d11dee0dd1ac2d0d862235f2e53d85d9.
This is also an updated revert of the revert
I99f75b5cb12913236a43b17970ea1752261ace9b.
Bug: T117726
Change-Id: Ieb9713f8346316e9c3cf1e83eae00848f3921b43
Timo Tijhof [Wed, 18 Apr 2018 01:59:36 +0000 (02:59 +0100)]
installer: Open skin screenshot in new window
By default the plain links hijack the current window, thus
causing the user to lose their current changes to the installer
form. It may also cause confusion as to how to get back.
Absence a modal way to view the image, at least it should default
to opening the image in a new tab.
Change-Id: I4a25f1f51e04a33f1f359f12af25b8e1db5fbd20
jenkins-bot [Wed, 18 Apr 2018 01:37:35 +0000 (01:37 +0000)]
Merge "build: Drop PHP 5 from Travis matrix"
jenkins-bot [Wed, 18 Apr 2018 01:24:01 +0000 (01:24 +0000)]
Merge "Update CREDITS and .mailmap"
Timo Tijhof [Wed, 18 Apr 2018 01:05:33 +0000 (02:05 +0100)]
Update CREDITS and .mailmap
Before this change, running the script would add the following:
* Cicalese: Duplicate. Fixed by adding another address to mailmap.
Follows-up
3b55b0b3b8.
* gopavasanth: Added.
* Guycn2: Added.
* Zoranzoki21: Duplicate. Fixed by normalising their name via mailmap.
Also, remove the following added by
19ccff96086b70b:
* GeoffreyT2000: Duplicate. Already normalised by mailmap.
Change-Id: I5b11444a74dad090e484c2e256d32de5f6792943
jenkins-bot [Wed, 18 Apr 2018 01:02:18 +0000 (01:02 +0000)]
Merge "Deprecate $wgUseAjax, act as always-true"
Timo Tijhof [Wed, 18 Apr 2018 00:58:50 +0000 (01:58 +0100)]
build: Drop PHP 5 from Travis matrix
We already cover this in our own Jenkins CI, and apparently
the PHP 5.5+mysql build recently started failing with a
segmentation fault for unknown reasons.
Change-Id: Ie041d5378155bb9ddcbf413f546a3a04efcb4b4f
jenkins-bot [Wed, 18 Apr 2018 00:53:12 +0000 (00:53 +0000)]
Merge "Drop deprecated EnableAPI and EnableWriteAPI settings"
James D. Forrester [Thu, 22 Mar 2018 21:27:45 +0000 (14:27 -0700)]
Deprecate $wgUseAjax, act as always-true
Change-Id: Ia224c7ea1f902714e2c11bdebb9dadcd1ddfe43f
jenkins-bot [Wed, 18 Apr 2018 00:45:42 +0000 (00:45 +0000)]
Merge "Update OOUI to v0.26.4"
James D. Forrester [Mon, 20 Nov 2017 23:50:22 +0000 (15:50 -0800)]
Drop deprecated EnableAPI and EnableWriteAPI settings
The siteinfo API response's 'writeapi' value is now hard-set to true,
as are the ResourceLoader variables wgEnableAPI and wgEnableWriteAPI,
to be deprecated later.
Bug: T115414
Change-Id: I54ff9428b247ba203d67aba079149393f323d5a9
jenkins-bot [Wed, 18 Apr 2018 00:25:42 +0000 (00:25 +0000)]
Merge "CREDITS bump"
Chad Horohoe [Tue, 3 Apr 2018 20:21:44 +0000 (13:21 -0700)]
CREDITS bump
Bug: T191090
Change-Id: I8f751e09b1f1429d1c3d98782ff75bb09adc566c
James D. Forrester [Wed, 18 Apr 2018 00:05:33 +0000 (17:05 -0700)]
Update OOUI to v0.26.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.26.4
Depends-On: I41080edad6079b0ab792f65965f0c49753070d35
Change-Id: I41080edad6079b0ab792f65965f0c49753070d36
Timo Tijhof [Fri, 2 Feb 2018 20:39:57 +0000 (12:39 -0800)]
skins: Remove MediaWikiI18N class and QuickTemplate::setTranslator
Deprecated in 1.31.
Bug: T186090
Change-Id: I2ff268868bf6f112add6fc3a5718e83467781b13
jenkins-bot [Tue, 17 Apr 2018 23:12:44 +0000 (23:12 +0000)]
Merge "Migrate PurgeJobUtils callback to AutoCommitUpdate"
Timo Tijhof [Tue, 17 Apr 2018 22:17:39 +0000 (23:17 +0100)]
WebStart: Remove deprecated $wgRequestTime
This variable is not read anywhere in Wikimedia Git.
Follows-up
06ba5ca383e2.
Bug: T189966
Change-Id: Ib86ebc44b12fee3a986838c5a302540b97066e5a
Timo Tijhof [Tue, 17 Apr 2018 22:07:48 +0000 (23:07 +0100)]
Setup: Move mbstring.func_overload from WebStart to Setup
Follows-up
26c2d03c17,
41d1fa1c3a and r11547 (
c7f363f886).
Also add references to the relevant tasks about why the check
exists.
Bug: T189966
Change-Id: Ic1f0c79a1b5638bb30351a0cab55699931d1fded
jenkins-bot [Tue, 17 Apr 2018 21:54:32 +0000 (21:54 +0000)]
Merge "WebStart: Remove redundant unset() for $IP"
jenkins-bot [Tue, 17 Apr 2018 21:48:29 +0000 (21:48 +0000)]
Merge "RELEASE-NOTES: Add note for StartProfiler deprecation"
Timo Tijhof [Tue, 17 Apr 2018 21:33:41 +0000 (22:33 +0100)]
WebStart: Remove redundant unset() for $IP
This seems redundant given it is unconditionally being set
two statements later. Probably a left-over from r36353 (
c6b902f180),
which did an unset() because there was another variable called
$preIP, and the original would no longer be needed.
However, we currently only use one variable ($IP) and there's no
need to unset() it before setting.
Bug: T189966
Change-Id: I17d516709beabeb80bd72b37f70ac9b666a501d4
jenkins-bot [Tue, 17 Apr 2018 21:36:45 +0000 (21:36 +0000)]
Merge "Special:Statistics: Be consistent in having ' (list of members)' after each row"
jenkins-bot [Tue, 17 Apr 2018 21:33:25 +0000 (21:33 +0000)]
Merge "resourceloader: Disable a flaky MessageBlobStoreTest case"
Timo Tijhof [Tue, 17 Apr 2018 21:29:36 +0000 (22:29 +0100)]
RELEASE-NOTES: Add note for StartProfiler deprecation
Follows-up
5209adff6c which just missed the 1.31 boat.
Change-Id: Ia7501e07ccd6498c24ff02f407be1c39414ab97e
jenkins-bot [Tue, 17 Apr 2018 21:28:04 +0000 (21:28 +0000)]
Merge "Prepare for REL1_31 cut, labelling master as 1.32-alpha"
James D. Forrester [Mon, 26 Feb 2018 22:06:01 +0000 (14:06 -0800)]
Special:Statistics: Be consistent in having ' (list of members)' after each row
Change-Id: I7736c5fb6032f1b7e8a60b49d422435a8c8e4962
Timo Tijhof [Tue, 17 Apr 2018 21:19:36 +0000 (22:19 +0100)]
resourceloader: Disable a flaky MessageBlobStoreTest case
Sometimes fails on the mediawiki-phpunit-php70-jessie job.
Bug: T176097
Change-Id: Id8c142954d597e1efaa326795f419d48b7af8bdf
James D. Forrester [Tue, 17 Apr 2018 18:24:01 +0000 (11:24 -0700)]
Prepare for REL1_31 cut, labelling master as 1.32-alpha
Change-Id: Id0aaad5a06cb90c4b2b81fa233a0a622aaf91a1e
jenkins-bot [Tue, 17 Apr 2018 20:22:23 +0000 (20:22 +0000)]
Merge "Setup: Deprecate StartProfiler, move default to DefaultSettings"
Translation updater bot [Tue, 17 Apr 2018 20:01:19 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ief0643ed5d9b0480f61cd380103e425e986eaa23
jenkins-bot [Tue, 17 Apr 2018 19:30:47 +0000 (19:30 +0000)]
Merge "Do not start explicit transaction rounds for RecentChangesUpdateJob"
jenkins-bot [Tue, 17 Apr 2018 18:35:10 +0000 (18:35 +0000)]
Merge "rdbms: remove "m" prefix from LoadBalancer comments"
jenkins-bot [Tue, 17 Apr 2018 18:34:19 +0000 (18:34 +0000)]
Merge "mediawiki.loader: Clean up unit tests"
jenkins-bot [Tue, 17 Apr 2018 15:55:08 +0000 (15:55 +0000)]
Merge "mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClose"
jenkins-bot [Tue, 17 Apr 2018 15:50:38 +0000 (15:50 +0000)]
Merge "mw.special.preferences.confirmClose: Handle textareas"
jenkins-bot [Tue, 17 Apr 2018 15:44:56 +0000 (15:44 +0000)]
Merge "RCFilters: Prevent trigger element movement"
jenkins-bot [Tue, 17 Apr 2018 15:18:39 +0000 (15:18 +0000)]
Merge "Handle extension dependencies in the installer"
jenkins-bot [Tue, 17 Apr 2018 14:55:19 +0000 (14:55 +0000)]
Merge "resourceloader: Remove getHashMtime() and getDefinitionMtime() methods"
Bartosz Dziewoński [Tue, 17 Apr 2018 13:05:05 +0000 (15:05 +0200)]
mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClose
Replace `<input type="hidden">` with a `<textarea>` hidden using
`display: none`, because the former does not have separate 'value'
and 'defaultValue' properties, and the Special:Preferences script to
enable/disable the "Save" button depends on them to work correctly.
We use a similar approach in OOUI (RadioSelectInputWidget).
Also correct a code comment (we need to trigger a 'change' event for
any kind of input, not just `<input type="hidden">`).
Bug: T192147
Change-Id: I2351bc752f9cf25a607f4b197c132062d52ecb1e
Bartosz Dziewoński [Tue, 17 Apr 2018 13:11:59 +0000 (15:11 +0200)]
mw.special.preferences.confirmClose: Handle textareas
Bug: T192147
Change-Id: Ie02c5d8cab7db091054f7d66633c6ec34354ee19
Aaron Schulz [Mon, 16 Apr 2018 20:38:01 +0000 (13:38 -0700)]
Do not start explicit transaction rounds for RecentChangesUpdateJob
The replaces the hacky use of onTransactionIdle(), which no longer runs
immediately in explicit transaction rounds since
d4c31cf841.
Also clarified TransactionRoundDefiningUpdate comment about rounds.
Change-Id: Ie17eacdcaea4e47019cc94e1c7beed9d7fec5cf2
Aaron Schulz [Tue, 17 Apr 2018 04:20:58 +0000 (21:20 -0700)]
rdbms: remove "m" prefix from LoadBalancer comments
Change-Id: Ie239157eb6ee8b7991c45ef5c5c06a1caaba52c9
Volker E [Tue, 17 Apr 2018 04:20:39 +0000 (21:20 -0700)]
RCFilters: Prevent trigger element movement
Change-Id: Ic04229ade53a42a47ccbd909640b848cf9979eb1
Fomafix [Fri, 16 Feb 2018 10:36:59 +0000 (11:36 +0100)]
Use module.exports for mediawiki.libs.jpegmeta
Deprecate mw.libs.jpegmeta. Use
mw.loader.require( 'mediawiki.libs.jpegmeta' )
instead.
Change-Id: I8a7fb7377248a2ce1cf9c6d3c888ca9835cadaad
Timo Tijhof [Tue, 17 Apr 2018 00:42:00 +0000 (01:42 +0100)]
resourceloader: Remove getHashMtime() and getDefinitionMtime() methods
Deprecated since 1.26, no callers or implementors in Wikimedia Git.
Change-Id: Ie44b4be47db7a4799fe39d66294c41238c62f51f
Timo Tijhof [Tue, 17 Apr 2018 00:40:48 +0000 (01:40 +0100)]
resourceloader: Add @covers for covered deprecated methods
These are deprecated for extensions to implement, but still
supported and already triggered by the test cases. Previously
not mentioned because they were ignored by PHPUnit, but not anymore.
Change-Id: I594788e322bfd83be1e7847d3272d57c549f3e8b
Aaron Schulz [Tue, 17 Apr 2018 00:11:42 +0000 (17:11 -0700)]
Migrate PurgeJobUtils callback to AutoCommitUpdate
Since it calls LBFactory::commitAndWaitForReplication, blocking for
an unknown amount of time, it is a bit "heavyweight" to be the sort
of quick update that uses onTransactionIdle().
Change-Id: Ic3476de5b61a7cd5f31ba487b186f9605a3b2774
jenkins-bot [Mon, 16 Apr 2018 22:58:47 +0000 (22:58 +0000)]
Merge "resourceloader: Clean up CSSMinTest"
Timo Tijhof [Mon, 16 Apr 2018 22:05:46 +0000 (23:05 +0100)]
resourceloader: Clean up CSSMinTest
* Consistently name data providers as "provide.." and make them
static.
* Document why wgServer is being mocked.
* Use TestingAccessWrapper instead of ad-hoc sub class for
accessing protected methods.
Change-Id: Ife2d98091200bbc8fb16b7ac6eafd3f2c22c1463
Aaron Schulz [Thu, 5 Apr 2018 02:44:21 +0000 (19:44 -0700)]
rdbms: add $flags argument to ILoadBalancer::getAnyOpenConnection
Make LoadMonitor use this flag for getting a connection.
Change-Id: I32ea9aadc0223c86db5979d6579d781a6af0ff53
Translation updater bot [Mon, 16 Apr 2018 19:55:08 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id2377abe03165cfbdf22d0417471efa18af02cde