jenkins-bot [Tue, 26 Mar 2019 21:59:55 +0000 (21:59 +0000)]
Merge "Prune old edit stash entries from users as they create more"
Aaron Schulz [Mon, 25 Mar 2019 14:51:45 +0000 (07:51 -0700)]
rdbms: codify DatabaseDomain table "_" prefix convention
Alos simplify isCompatible() slightly and make the string
case in convertToString() explicit.
Change-Id: Ifb61bb5fb012491520525bbebfbde2269fa55b52
jenkins-bot [Tue, 26 Mar 2019 20:18:42 +0000 (20:18 +0000)]
Merge "Make MWLBFactory sanity check that postgres is not used with a table prefix"
jenkins-bot [Tue, 26 Mar 2019 19:20:10 +0000 (19:20 +0000)]
Merge "Avoid using calls to freeResults() and allow object go out of scope"
jenkins-bot [Tue, 26 Mar 2019 19:19:51 +0000 (19:19 +0000)]
Merge "rdbms: use a direct "USE" query for doSelectDomain() for mysql"
jenkins-bot [Tue, 26 Mar 2019 19:19:38 +0000 (19:19 +0000)]
Merge "rdbms: remove $wgDBprefix reference from DatabaseOracle"
jenkins-bot [Tue, 26 Mar 2019 18:51:26 +0000 (18:51 +0000)]
Merge "rdbms: Use correct value for 'sslmode' in DatabasePostgres"
Aaron Schulz [Fri, 22 Mar 2019 01:12:44 +0000 (18:12 -0700)]
rdbms: use a direct "USE" query for doSelectDomain() for mysql
This should give better error messages on failure.
Bug: T212284
Change-Id: I55260c6e3db1770f01e3d6a6a363b917a57265be
Aaron Schulz [Tue, 26 Mar 2019 18:44:17 +0000 (11:44 -0700)]
rdbms: remove $wgDBprefix reference from DatabaseOracle
Rely on MWLBFactory as other DB classes do
Change-Id: I33d535c659626dd42c9cb8d20c1a0fc90a885c8c
jenkins-bot [Tue, 26 Mar 2019 18:41:05 +0000 (18:41 +0000)]
Merge "rdbms: Fix incomplete doc for DatabaseMssql::tableName()"
Aaron Schulz [Tue, 26 Mar 2019 05:26:13 +0000 (22:26 -0700)]
Prune old edit stash entries from users as they create more
This should reduce pressure on certain medium-large sized memcached
slabs. Pre-1.5 memcached versions have a harder time pruning expired
entries in time to avoid evictions, so it will be most useful that
scenario.
Bug: T203786
Change-Id: Ic357dbfcd9abd525b02e8d631d1344db3745d24c
Mark A. Hershberger [Thu, 9 Aug 2018 20:18:34 +0000 (16:18 -0400)]
rdbms: Use correct value for 'sslmode' in DatabasePostgres
Fix Postgres support by using ‘sslmode=require' instead of ‘sslmode=1'.
See https://www.postgresql.org/docs/current/static/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS
Change-Id: I424b0e3e144bbe9f0a2bde9a3b4a674dde10c729
Thiemo Kreuz [Tue, 26 Mar 2019 11:01:31 +0000 (12:01 +0100)]
rdbms: Fix incomplete doc for DatabaseMssql::tableName()
I'm also replacing a loop with an array_pad() call. When the count given
to array_pad() is negative, the padding is done to the left instead of
the right. This is exactly what the loop did before.
I'm also adding the missing limit to the explode() call.
Change-Id: I6737fcf6b60b822269b855f1405607be7fc23754
jenkins-bot [Tue, 26 Mar 2019 17:38:03 +0000 (17:38 +0000)]
Merge "Supress ChangeTags::addTags() exceptions for ManualLogEntry objects"
jenkins-bot [Tue, 26 Mar 2019 17:30:46 +0000 (17:30 +0000)]
Merge "OOUI forms: Remove infusable = false"
jenkins-bot [Tue, 26 Mar 2019 17:30:33 +0000 (17:30 +0000)]
Merge "HISTORY: Add MediaWiki 1.32.1 release change notes"
Nikita Rana [Mon, 25 Mar 2019 19:19:08 +0000 (00:49 +0530)]
HISTORY: Add MediaWiki 1.32.1 release change notes
Add MediaWiki 1.32 release change notes, sourced from https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_32/RELEASE-NOTES-1.32
Bug: T213714
Change-Id: I307ee0373021639835a6f3a3c4d3d6b7c6c3dbc8
Piotr Miazga [Tue, 26 Mar 2019 15:17:05 +0000 (16:17 +0100)]
Supress ChangeTags::addTags() exceptions for ManualLogEntry objects
Looks like some parts of the code try to publish log event when
$newId is 0 or null. This cause ChangeTags::addTags to throw
an exception as at least one of rc_id, rev_id, or log_id must be
specified.
When ChangeTags::addTags() fails (because both $rev_id and $log_id
are not present), just ignore the exception and continue with
the execution.
Also, if one of those is set to 0, we need to pass null instead
(do not insert 0's in to DB as both log_id and rev_id are foreign
keys).
Additionally log all places where ManualLogEntry::publish() is
called with incorrect arguments so later we can fix all occurencie
and remove that try{}catch around ChangeTags::addTags() call.
Bug: T218940
Change-Id: I495f79f2b7a7ef1503d229a689babdc12deb353c
jenkins-bot [Tue, 26 Mar 2019 15:39:47 +0000 (15:39 +0000)]
Merge "HISTORY: Add MediaWiki 1.13 post-release change notes"
jenkins-bot [Tue, 26 Mar 2019 15:35:17 +0000 (15:35 +0000)]
Merge "HISTORY: Add MediaWiki 1.9 post-release change notes"
jenkins-bot [Tue, 26 Mar 2019 15:34:54 +0000 (15:34 +0000)]
Merge "HISTORY: Add MediaWiki 1.10 post-release change notes"
jenkins-bot [Tue, 26 Mar 2019 15:31:49 +0000 (15:31 +0000)]
Merge "Fix invalid HTMLForm::setValidationErrorMessage doc"
Nikita Rana [Tue, 26 Mar 2019 11:28:18 +0000 (16:58 +0530)]
HISTORY: Add MediaWiki 1.13 post-release change notes
Add MediaWiki 1.13 post-release change notes, sourced from
https://www.mediawiki.org/wiki/Release_notes/1.13
Bug: T213714
Change-Id: Id1030ccb01e15538ba563cabbc283a90cf1e6992
jenkins-bot [Tue, 26 Mar 2019 14:26:54 +0000 (14:26 +0000)]
Merge "Stop gap to shut up log spam due to T212428."
Lucas Werkmeister [Tue, 26 Mar 2019 13:13:51 +0000 (14:13 +0100)]
Use finally instead of try-catch-throw
When this exception handler was introduced in change Ifbc1db4b82 (commit
9636d44448), MediaWiki still supported PHP 5.3.2, where finally was not
available. It was added in PHP 5.5, though, which we’ve required for a
while now, so we can simplify this a bit.
Change-Id: I7c967fb713de7495739e18ff6c6058a630129fda
Nikita Rana [Tue, 26 Mar 2019 12:54:48 +0000 (18:24 +0530)]
HISTORY: Add MediaWiki 1.9 post-release change notes
Add MediaWiki 1.9 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.9
Bug:T213714
Change-Id: Idbb105e332afeec1daafaf275da6ae432a698371
Nikita Rana [Tue, 26 Mar 2019 12:09:52 +0000 (17:39 +0530)]
HISTORY: Add MediaWiki 1.10 post-release change notes
Add MediaWiki 1.10 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.10
Bug:T213714
Change-Id: Ib313692a359d249ede38c51e823042a9f6f2b0e6
jenkins-bot [Tue, 26 Mar 2019 08:37:33 +0000 (08:37 +0000)]
Merge "OutputPage: Fix typo in escaped"
Kunal Mehta [Tue, 26 Mar 2019 08:12:04 +0000 (01:12 -0700)]
OutputPage: Fix typo in escaped
Spotted by phan.
Change-Id: Iba372755869c602990ea063f3bfde36e19561adb
Translation updater bot [Tue, 26 Mar 2019 07:29:03 +0000 (08:29 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I7090f89a59d6688c2e196d972f016785871cd89a
Aaron Schulz [Tue, 26 Mar 2019 06:09:32 +0000 (23:09 -0700)]
Make MWLBFactory sanity check that postgres is not used with a table prefix
Change-Id: If0c75a042c0e85d4f124be2204cdd52fcd602932
jenkins-bot [Tue, 26 Mar 2019 05:41:52 +0000 (05:41 +0000)]
Merge "db: Use variable functions/callbacks instead of call_user_func()"
MaxSem [Tue, 26 Mar 2019 05:26:38 +0000 (05:26 +0000)]
Merge "block: Use correct function wfGetDB() as defined"
jenkins-bot [Tue, 26 Mar 2019 02:34:11 +0000 (02:34 +0000)]
Merge "specialpage: Remove unused QueryPage::doFeed()"
jenkins-bot [Tue, 26 Mar 2019 02:24:04 +0000 (02:24 +0000)]
Merge "Update some minor type hints"
daniel [Tue, 19 Mar 2019 22:16:49 +0000 (23:16 +0100)]
Stop gap to shut up log spam due to T212428.
Bug: T212428
Change-Id: I442bbe9837e73167cfdaabb0451bf974dc5039f3
jdlrobson [Wed, 13 Feb 2019 22:18:31 +0000 (14:18 -0800)]
History page is now using pseudo elements for presentation
|, ( and ) separators are now added via CSS rather than being
made part of the HTML.
Bug: T205581
Change-Id: I272770418ee544b22f8f94312daf07010b7a2273
Timo Tijhof [Mon, 25 Mar 2019 23:44:58 +0000 (23:44 +0000)]
dictionary: Remove "mobilelanding"
Bug: T187716
Change-Id: Ia3a77245fe0daacc39c42fd83e18bf9e59f7c74b
jenkins-bot [Mon, 25 Mar 2019 22:21:05 +0000 (22:21 +0000)]
Merge "Simplify Block::getBy and Block::getByName"
jenkins-bot [Mon, 25 Mar 2019 21:52:36 +0000 (21:52 +0000)]
Merge "Use Block::setTimestamp to set the timestamp on a block"
jenkins-bot [Mon, 25 Mar 2019 21:07:11 +0000 (21:07 +0000)]
Merge "GlobalFunctions: Document the usage of wfUrlencode( null )"
jenkins-bot [Mon, 25 Mar 2019 20:37:48 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.23 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:35 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.19 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:23 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.18 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:37:13 +0000 (20:37 +0000)]
Merge "HISTORY: Add MediaWiki 1.12 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:23:18 +0000 (20:23 +0000)]
Merge "fix up new text address handling in page content dumps"
jenkins-bot [Mon, 25 Mar 2019 20:14:36 +0000 (20:14 +0000)]
Merge "HISTORY: Add MediaWiki 1.11 post-release change notes"
jenkins-bot [Mon, 25 Mar 2019 20:12:55 +0000 (20:12 +0000)]
Merge "resources: Add caching for faster runs and offline use"
jenkins-bot [Mon, 25 Mar 2019 20:11:33 +0000 (20:11 +0000)]
Merge "resources: Improve foreign-resources docs and error messages"
jenkins-bot [Mon, 25 Mar 2019 20:04:08 +0000 (20:04 +0000)]
Merge "resources: Make manageForeignResources a regular maint script"
Ed Sanders [Mon, 25 Mar 2019 18:58:52 +0000 (18:58 +0000)]
OOUI forms: Remove infusable = false
False is already the default value for infusable.
Change-Id: Ie0e9b7467b7f3f13c45372b38b7b80ba78852e55
Nikita Rana [Mon, 25 Mar 2019 18:38:56 +0000 (00:08 +0530)]
HISTORY: Add MediaWiki 1.23 post-release change notes
Add MediaWiki 1.23 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.23
Bug:T213714
Change-Id: I20ad7615a2d9b0d3eb99abb41b125b30fc5d1ece
jenkins-bot [Mon, 25 Mar 2019 17:45:04 +0000 (17:45 +0000)]
Merge "Provide direct deprecation message for jquery.ui.spinner"
jenkins-bot [Mon, 25 Mar 2019 17:44:54 +0000 (17:44 +0000)]
Merge "mw.feedback: Remove unused custom spinner"
Fomafix [Sat, 9 Mar 2019 13:04:28 +0000 (14:04 +0100)]
GlobalFunctions: Document the usage of wfUrlencode( null )
This was introduced for testing in
53b0052df.
Change-Id: I318d6d6c04334ea75fbc9ac1771fab9a9db8cb83
jenkins-bot [Mon, 25 Mar 2019 17:18:54 +0000 (17:18 +0000)]
Merge "registration: Follow-up on I54e8065c63f81016425c7dd40ce87e"
Ariel T. Glenn [Mon, 25 Mar 2019 16:50:27 +0000 (18:50 +0200)]
fix up new text address handling in page content dumps
Broken in I979b6c8f0a72bc1f5ecce1d499d3fdfa0f671588
Bug: T174031
Change-Id: Ia31fc7b559f59d53bb503a59abf9110f0e65178c
Derick Alangi [Mon, 25 Mar 2019 15:56:14 +0000 (16:56 +0100)]
registration: Follow-up on I54e8065c63f81016425c7dd40ce87e
Change-Id: I610dfafcd180f89ee0e786f4516f9eb9c63a42b4
jenkins-bot [Mon, 25 Mar 2019 15:47:44 +0000 (15:47 +0000)]
Merge "objectcache: Remove unused variable $cache which is overriden"
jenkins-bot [Mon, 25 Mar 2019 15:47:29 +0000 (15:47 +0000)]
Merge "Fix MessagecacheTest::testLoadFromDB_fetchLatestRevision"
jenkins-bot [Mon, 25 Mar 2019 15:38:54 +0000 (15:38 +0000)]
Merge "changetags: Remove unnecessary semicolon after catch block"
Thalia [Mon, 25 Mar 2019 15:11:26 +0000 (15:11 +0000)]
Use Block::setTimestamp to set the timestamp on a block
Follow-up to I767ed44ce4c2e, where the setter was added.
Change-Id: I888e758aef44a101068bd52e89636e2656899f62
Ed Sanders [Mon, 25 Mar 2019 14:41:05 +0000 (14:41 +0000)]
mw.feedback: Remove unused custom spinner
Change-Id: I6d34006b943366045a69a89aa574c77be609440f
jenkins-bot [Mon, 25 Mar 2019 14:59:25 +0000 (14:59 +0000)]
Merge "Rename PoolCounter_Stub to PoolCounterNull"
jenkins-bot [Mon, 25 Mar 2019 14:59:11 +0000 (14:59 +0000)]
Merge "rdbms: Drop unused constructor property and default method arg"
jenkins-bot [Mon, 25 Mar 2019 14:45:20 +0000 (14:45 +0000)]
Merge "DefaultSettings: Remove deprecated $wgDBmysql5 from core"
Derick Alangi [Mon, 25 Mar 2019 14:37:47 +0000 (15:37 +0100)]
changetags: Remove unnecessary semicolon after catch block
Change-Id: I89cc05dbbb8c0cf2382e251a3c144353af0906e5
Ed Sanders [Mon, 25 Mar 2019 14:35:40 +0000 (14:35 +0000)]
Provide direct deprecation message for jquery.ui.spinner
The whole of jquery.ui is deprecated, but this provides
a more direct replacement suggestion for this module.
Change-Id: I1c09ca48765f3c82f2318fd53d679e4168e5d565
Derick Alangi [Mon, 25 Mar 2019 14:20:19 +0000 (15:20 +0100)]
objectcache: Remove unused variable $cache which is overriden
This variable was defined to false and immediately overriden in the
if condition below it which makes the assignment above useless.
Change-Id: Ie72ec7a8860d2a38f59f38b3d861217d39da3e29
jenkins-bot [Mon, 25 Mar 2019 14:10:21 +0000 (14:10 +0000)]
Merge "rcfeed: Avoid extending/inheriting from a deprecated class"
Derick Alangi [Mon, 25 Mar 2019 13:27:22 +0000 (14:27 +0100)]
rcfeed: Avoid extending/inheriting from a deprecated class
Also, fix if...else syntax with return statement in the if block.
Change-Id: If14f0835731f264622cf90fcfd5c7cc850f63050
Derick Alangi [Mon, 25 Mar 2019 13:17:47 +0000 (14:17 +0100)]
registration: Remove wrong `@return` PHPDoc comments
$this->attributes is an array class property that gets set by the
method extractInfo(). This method really doesn't return an array
though in a sense $this->attributes gets set which can be used but
it's not returned.
Change-Id: I54e8065c63f81016425c7dd40ce87e1eb8ba0830
jenkins-bot [Mon, 25 Mar 2019 12:42:29 +0000 (12:42 +0000)]
Merge "Add filterFunction to visible{Byte,CodePoint}Limit"
daniel [Mon, 25 Mar 2019 10:47:53 +0000 (11:47 +0100)]
Fix MessagecacheTest::testLoadFromDB_fetchLatestRevision
This re-enables the "flaky" testLoadFromDB_fetchLatestRevision which
was disabled because it failed on random patches for no apparent
reason, as documented in T219042.
The reason was an invalid timestamp in the test data, which caused
the timestamp to default to "now", which was "sometimes" newer than
the timestamp of the revision immediately created before.
Bug: T219042
Bug: T218918
Change-Id: I38f4816b2dc735a7698626c7e3fe4a93ec95a9d1
Nikita Rana [Sat, 23 Mar 2019 05:12:20 +0000 (10:42 +0530)]
HISTORY: Add MediaWiki 1.19 post-release change notes
Add MediaWiki 1.19 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.19
Bug:T213714
Change-Id: Ia3295c12938750337cfd42371a0ae72abfceff2c
Nikita Rana [Sat, 23 Mar 2019 04:31:53 +0000 (10:01 +0530)]
HISTORY: Add MediaWiki 1.18 post-release change notes
Add MediaWiki 1.18 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.18
Bug:T213714
Change-Id: I2bea0ca7cb02d32fd24392fa167351851062ccb1
Nikita Rana [Thu, 21 Mar 2019 07:06:20 +0000 (12:36 +0530)]
HISTORY: Add MediaWiki 1.12 post-release change notes
Add MediaWiki 1.12 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.12
Bug:T213714
Change-Id: Ib2d34bbb31525e4157d062bc4d89072098e106ce
jenkins-bot [Mon, 25 Mar 2019 09:35:22 +0000 (09:35 +0000)]
Merge "db: Drop child methods as they're same as parent methods"
Thiemo Kreuz [Mon, 25 Mar 2019 08:17:06 +0000 (09:17 +0100)]
specialpage: Remove unused QueryPage::doFeed()
This code was written in 2004, and pretty much untouched since then.
The last non-trivial update to this code was done in 2014 via I1de6301.
But as far as I can tell this was just maintenance, not motivated by
somebody actually using this code.
I suspect this is unused for a long time already, long before 2014.
Possibly even unused in 2004. Really: I tried to dig into the revision
history of the core codebase to find when and where this was used, and
when it became unused. I could not find anything. I also used
https://codesearch.wmflabs.org to make sure there are no known callers
or subclasses hidden anywhere. I could not find anything either.
In conclusion I suggest to skip any deprecation phase.
Change-Id: I5f52c44760b903bcb348bebf8c6a0f6faf8180b7
Derick Alangi [Sun, 24 Mar 2019 23:45:00 +0000 (00:45 +0100)]
rdbms: Drop unused constructor property and default method arg
Change-Id: Id83efd8f68b241ca0d7c5340cc2fd93379578fac
Thiemo Kreuz [Sun, 24 Mar 2019 14:07:01 +0000 (15:07 +0100)]
Update some minor type hints
Change-Id: If5a6372e79038d3750d30a931badd0c110da2fe5
jenkins-bot [Mon, 25 Mar 2019 06:40:12 +0000 (06:40 +0000)]
Merge "docs: Update outdated PageContentSave hook documentation"
jenkins-bot [Mon, 25 Mar 2019 06:33:58 +0000 (06:33 +0000)]
Merge "upload: Simplify file extension extraction in UploadBase"
Nikita Rana [Wed, 20 Mar 2019 18:03:42 +0000 (23:33 +0530)]
HISTORY: Add MediaWiki 1.11 post-release change notes
Add MediaWiki 1.11 post-release change notes, sourced from https://www.mediawiki.org/wiki/Release_notes/1.11
Bug:T213714
Change-Id: I3d0894a3f04b4d03b1a354c28025dc78a1b2e27b
jenkins-bot [Mon, 25 Mar 2019 04:34:10 +0000 (04:34 +0000)]
Merge "Use the ?? feature instead of isset() where it makes sense"
jenkins-bot [Sun, 24 Mar 2019 23:55:59 +0000 (23:55 +0000)]
Merge "objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff"
Derick Alangi [Sun, 24 Mar 2019 23:29:22 +0000 (00:29 +0100)]
db: Drop child methods as they're same as parent methods
Change-Id: I8b3827a57782f02497da2ab8191d1dad11e92bca
Derick Alangi [Sun, 24 Mar 2019 23:14:49 +0000 (00:14 +0100)]
db: Use variable functions/callbacks instead of call_user_func()
Performance-wise, this gives a little boost in performance and also
it's more readable I think. But I could be wrong so please someone
let me know.
See: https://www.php.net/manual/en/function.call-user-func.php
Change-Id: I2f0a00408c29549a786b56792411f88998a5f003
Derick Alangi [Sun, 24 Mar 2019 23:02:21 +0000 (00:02 +0100)]
block: Use correct function wfGetDB() as defined
Change-Id: I92ff76a9b62dec0f1e3253230676d4b5c0a877f0
Umherirrender [Sun, 24 Mar 2019 21:44:46 +0000 (22:44 +0100)]
Rename PoolCounter_Stub to PoolCounterNull
Also move to own file
Remove "Stub", because it refers a php concept,
which is not used here
Change-Id: Ife952901b5ad8e4a408d229ee72de953a9acc220
Thiemo Kreuz [Sun, 24 Mar 2019 21:40:49 +0000 (22:40 +0100)]
Use the ?? feature instead of isset() where it makes sense
Change-Id: I3a54f36b33d99ef3ff4c63e32e7dfcbcfc296135
Timo Tijhof [Sun, 24 Mar 2019 20:28:25 +0000 (20:28 +0000)]
resources: Add caching for faster runs and offline use
Also honour any XDG variables if set (such as Wikimedia CI does)
so that gate jobs can automatically persist the cache.
Bug: T203694
Change-Id: I156af1c5097b8a87be228345fc0a0b80bb3ae338
Timo Tijhof [Sun, 24 Mar 2019 19:29:46 +0000 (19:29 +0000)]
resources: Improve foreign-resources docs and error messages
Previously, the help message was only shown when invoking the script
without parameters. Now, if invoking it with incorrect or mispelled
parameters, it shows what you can do instead (and no more exception trace,
which it did before).
Also document clearly but briefly how to use it, and with examples.
Change-Id: Ib5ba3dc02c54039495a33d6e0cc4d026ca708ba1
Timo Tijhof [Fri, 22 Mar 2019 20:34:37 +0000 (20:34 +0000)]
resources: Make manageForeignResources a regular maint script
The maintenance script was previously in a subdirectory which
is a bit unusual. It's now a regular maintenance script,
with the YAML file in a more discoverable place as well.
Change-Id: I38690f23dbe89839bee0e1d43ecfd68adeb19c0f
Reedy [Sun, 24 Mar 2019 20:47:24 +0000 (20:47 +0000)]
Fix off by 1 error when displaying the number of a line with an error
Change-Id: I876ba04f6903127a9d5adedfe0a5e2598a90068c
jenkins-bot [Sun, 24 Mar 2019 20:56:49 +0000 (20:56 +0000)]
Merge "Use foreach for readability"
jenkins-bot [Sun, 24 Mar 2019 20:36:56 +0000 (20:36 +0000)]
Merge "make xml abstracts, stubs and page log dumps work again"
Reedy [Sun, 24 Mar 2019 20:14:07 +0000 (20:14 +0000)]
Use foreach for readability
Change-Id: Ia4701bc50d8c57b9dcafe2da3bb399d59f4c8d0e
Thiemo Kreuz [Sun, 24 Mar 2019 14:04:32 +0000 (15:04 +0100)]
Make use of the list() feature where it makes sense
This code is functionally identical, but less error prone (not so easy
to forget or mix these numerical indexes).
This patch happens to touch the Parser, which might be a bit scary. We
can remove this file from this patch if you prefer.
Change-Id: I8cbe3a9a6725d1c42b86e67678c1af15fbc5961a
Ariel T. Glenn [Sun, 24 Mar 2019 11:43:37 +0000 (13:43 +0200)]
make xml abstracts, stubs and page log dumps work again
Broken in I979b6c8f0a72bc1f5ecce1d499d3fdfa0f671588
Bug: T174031
Change-Id: I494fe7578f936a2316c27f9c419e981055c38ed4