jenkins-bot [Tue, 3 Apr 2018 15:37:05 +0000 (15:37 +0000)]
Merge "Populate ar_rev_id and make it non-nullable"
Antoine Musso [Tue, 3 Apr 2018 08:31:09 +0000 (10:31 +0200)]
tests: fix PHPUnit @requires for APCU
@requires is an annotation used by PHPUnit to flag a test as requiring a
PHP function or extension.
c214c9a95 changed it to list two functions
separated by a slash:
@requires function apc_store/apcu_store
However that is not recognized by PHPUnit and the test is always
skipped.
Change the @requires to require the APCU extension.
Repro case:
phpunit.php --verbose includes/libs/MemoizedCallableTest.php
Follow-up
c214c9a95255abf1032d389d0fe8bcbde38b55db
Bug: T140587
Change-Id: I1fdd52c8fc8ca1c7c0c7f914e6da8774799ba5d8
jenkins-bot [Tue, 3 Apr 2018 09:09:46 +0000 (09:09 +0000)]
Merge "LanguageConverter tweaks to Pig Latin converter"
Translation updater bot [Tue, 3 Apr 2018 07:00:01 +0000 (09:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I23379ec2eb8320618f5be56618ed5c45587c8825
Sam Wilson [Tue, 3 Apr 2018 03:56:18 +0000 (11:56 +0800)]
Add DeleteUnknownPreferences hook
This makes it possible for extensions to add to the WHERE clause
with which unknown preferences are deleted.
Bug: T188966
Change-Id: Ifb22ca42207956f2b07333da026ff0b215a83930
jenkins-bot [Tue, 3 Apr 2018 06:13:32 +0000 (06:13 +0000)]
Merge "Add further test cases to deleteAutoPatrolLogsTest"
Marius Hoch [Tue, 3 Apr 2018 05:15:43 +0000 (07:15 +0200)]
Add further test cases to deleteAutoPatrolLogsTest
Also make --batch-size work and make an if check nicer
(makes no functional difference AFAICT).
Bug: T189594
Change-Id: I3ce63386cb35441acfa226f313ec8aac1aa417a6
jenkins-bot [Tue, 3 Apr 2018 05:25:52 +0000 (05:25 +0000)]
Merge "Introduce deleteAutoPatrolLogs maintenance script"
Amir Sarabadani [Sat, 17 Mar 2018 23:34:32 +0000 (00:34 +0100)]
Introduce deleteAutoPatrolLogs maintenance script
It's useful to delete old patrol logs that are not useful
Bug: T189594
Change-Id: I605bb85f172eb25df45ed83ce50a3d1044f1c281
jenkins-bot [Tue, 3 Apr 2018 01:18:42 +0000 (01:18 +0000)]
Merge "DB: Add img_description_id column"
jenkins-bot [Mon, 2 Apr 2018 21:48:21 +0000 (21:48 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 17.0.0"
Aaron Schulz [Mon, 2 Apr 2018 21:39:33 +0000 (14:39 -0700)]
rdbms: rename and clarify getTransactionLagStatus method regarding begin()
Make sure any value from the last transaction is cleared and not used.
For sanity, make getLagFromPtHeartbeat() use this regardless of the age of
the transaction unless it returns null.
Change-Id: I52df6147f99736ad1a389ae70d347ae968e50c7f
Aaron Schulz [Mon, 2 Apr 2018 21:02:47 +0000 (14:02 -0700)]
Revert "rdbms: make getMasterPos() ignore GTIDs outside of gtid_domain_id"
This had a noticeable increase in LoadBalancer::doWait timeouts.
This reverts commit
ceb7d61ee7ef3edc6705abd41ec86b3afcd9c491.
Change-Id: I7004d55a05c20f646f70d778d7b6496123e270a4
Aaron Schulz [Mon, 2 Apr 2018 19:56:11 +0000 (12:56 -0700)]
rdbms: avoid incorrect warnings in getLagFromPtHeartbeat()
Change-Id: I4c0d42be0ee0c518d7bacdae0f76feb53007861e
jenkins-bot [Mon, 2 Apr 2018 18:02:28 +0000 (18:02 +0000)]
Merge "Make LanguageConverter roman-numeral cases consistent"
Brad Jorsch [Thu, 4 Jan 2018 19:35:13 +0000 (14:35 -0500)]
Populate ar_rev_id and make it non-nullable
Revisions deleted before MediaWiki 1.5 do not have a value in this
field. This is going to be a problem for migration to the MCR schema, so
provide a maintenance script to clean this up.
Then, for good measure, change the schema to make the field
non-nullable.
Bug: T182678
Change-Id: Ie2e11f12a30f379db32c3e074658012c6f93adb0
jenkins-bot [Mon, 2 Apr 2018 12:15:44 +0000 (12:15 +0000)]
Merge "Selenium: update WebdriverIO configuration"
Translation updater bot [Mon, 2 Apr 2018 07:27:16 +0000 (09:27 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I35703b36f31021e7ba272c3b1869808cb95b580f
Prateek Saxena [Mon, 2 Apr 2018 05:08:22 +0000 (10:38 +0530)]
Special:Preference: Check for changes before enabling Save button
* Changing mousedown and keydown to mouseup and keyup
…so that isPrefsChanged gets the updated value and can return
something useful
* Changing one to on
…so that if a value is updated and then changed back to the
original, the button can be disabled again
Bug: T180538
Change-Id: I7146f8d3166e09e13b26321e7a6a7c8ac74f9aaf
C. Scott Ananian [Mon, 2 Apr 2018 03:50:58 +0000 (23:50 -0400)]
LanguageConverter tweaks to Pig Latin converter
Add apostrophe to the set of valid word characters for the en-x-piglatin
converter, so that "don't" and "can't" are properly converted to Pig
Latin (eg, to "on'tday" and "an'tcay").
Add an optional `s` before `qu` so that "squish" is properly converted
to "ishsquay".
Change-Id: Ibc5cf2c007a42d9447688b857aa75f9a3d8ae152
C. Scott Ananian [Mon, 2 Apr 2018 03:49:19 +0000 (23:49 -0400)]
Make LanguageConverter roman-numeral cases consistent
Add a look-ahead to ensure that the regex intended to match roman numerals
doesn't also match the empty string. Tweak the regular expressions slightly
to ensure that Sr/Ku/Crh all have identical regular expressions.
Change-Id: If43bf99a21c42c6c5050f814c0bc99edec353228
Ed Sanders [Fri, 30 Mar 2018 19:56:59 +0000 (20:56 +0100)]
Use fallback languages in ResourceLoaderImage
Bug: T191120
Change-Id: Ic72aead466c12d344bac359654e6dcc7f0e5c8cb
Guycn2 [Sun, 1 Apr 2018 19:26:35 +0000 (19:26 +0000)]
Add Hebrew alias for special page ApiSandbox
Change-Id: I09bf2951b5bc18bf9f7080d178ea74466d14e97e
Translation updater bot [Sun, 1 Apr 2018 06:23:30 +0000 (08:23 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I20bbb93b56df4246c31344f3929742af581c3118
jenkins-bot [Sat, 31 Mar 2018 19:48:27 +0000 (19:48 +0000)]
Merge "MessagesBs.php: Update namespaces names"
jenkins-bot [Sat, 31 Mar 2018 08:31:10 +0000 (08:31 +0000)]
Merge "rdbms: avoid lag estimates in getLagFromPtHeartbeat ruined by snapshots"
Translation updater bot [Sat, 31 Mar 2018 06:46:05 +0000 (08:46 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id315b02132af92cc2d4b61a28da34be32e333e54
Aaron Schulz [Thu, 29 Mar 2018 23:30:38 +0000 (16:30 -0700)]
rdbms: avoid lag estimates in getLagFromPtHeartbeat ruined by snapshots
Bug: T190960
Change-Id: I57dd8d3d0ca96d6fb2f9e83f062f29b1d53224dd
jenkins-bot [Sat, 31 Mar 2018 00:52:09 +0000 (00:52 +0000)]
Merge "rdbms: update IDatabase::getLag comments"
jenkins-bot [Sat, 31 Mar 2018 00:47:27 +0000 (00:47 +0000)]
Merge "rdbms: add more error logging to DatabaseMysqlBase::masterPosWait"
zoranzoki21 [Tue, 20 Feb 2018 17:47:45 +0000 (18:47 +0100)]
MessagesBs.php: Update namespaces names
Bug: T172050
Change-Id: I3eb31ef0785138b14342c27a4232bec2b782c0bf
Željko Filipin [Thu, 29 Mar 2018 14:12:35 +0000 (16:12 +0200)]
Selenium: update WebdriverIO configuration
No changes are made to the configuration file. It has just been
regenerated with the latest WebdriverIO version. Minor whitespace
cleanup has been made to the file after it has been generated so it
conforms to our ESLint configuration.
This is the first step in updating configuration so videos of failed
tests are recorded.
Bug: T179188
Change-Id: Id0db3743ae7d828357b1527770bb7dcd2e02f99b
jenkins-bot [Fri, 30 Mar 2018 15:15:38 +0000 (15:15 +0000)]
Merge "mediawiki.action.view.rightClickEdit: Remove redundanat dom-ready handler"
Aaron Schulz [Fri, 30 Mar 2018 11:39:05 +0000 (04:39 -0700)]
rdbms: add more error logging to DatabaseMysqlBase::masterPosWait
Change-Id: Ia687ddeffc9c9427c6126d8ed831fb52b38e8260
jenkins-bot [Fri, 30 Mar 2018 11:27:11 +0000 (11:27 +0000)]
Merge "Improve docs for revision, archive, and slots schemas in tables.sql"
Translation updater bot [Fri, 30 Mar 2018 06:54:37 +0000 (08:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0c57d6f3f632ddd06f36f833c53f97d96e7dd645
Aaron Schulz [Thu, 29 Mar 2018 23:14:37 +0000 (16:14 -0700)]
rdbms: update IDatabase::getLag comments
Also add missing __METHOD__ to getLagFromPtHeartbeat()
Change-Id: I4257b1d47a88779b47d807a881561c331ff3aa30
jenkins-bot [Thu, 29 Mar 2018 23:02:39 +0000 (23:02 +0000)]
Merge "rdbms: remove some dead code from Database::begin"
Aaron Schulz [Thu, 29 Mar 2018 21:51:47 +0000 (14:51 -0700)]
rdbms: remove some dead code from Database::begin
The "since" filed is computed after getLag(), so this was useless
Change-Id: I252602e85709b1cfc191d4783bd1c53d5b3e8fe8
jenkins-bot [Thu, 29 Mar 2018 22:26:29 +0000 (22:26 +0000)]
Merge "Improve docs for archive schema in tables.sql"
Brad Jorsch [Thu, 29 Mar 2018 22:14:12 +0000 (18:14 -0400)]
Improve docs for revision, archive, and slots schemas in tables.sql
Follows up Id2257827.
Change-Id: Ifd61eaa51a6f7781522cecdbf8c563465e97e885
Timo Tijhof [Thu, 29 Mar 2018 21:33:25 +0000 (14:33 -0700)]
mediawiki.action.view.rightClickEdit: Remove redundanat dom-ready handler
This file was wrapped in a jQuery() dom-ready callback, but it doesn't
and shouldn't have that because it needlessly delays execution.
I probably added because back then, using the first parameter of jQuery()
was a common way for aliasing it to '$', but we use closures for that
nowadays.
Change-Id: I65768564ed556828fd193dfe99d11370fa745112
Aaron Schulz [Tue, 20 Mar 2018 11:16:41 +0000 (04:16 -0700)]
rdbms: clean up session/transaction loss logic in Database
* Refactor the code to be less cluttered, moving some logic
to reconnect(), which is now named replaceLostConnection()
* Handle the case of a second connection loss on query retry
* Make canRecoverFromDisconnect() check for temporary tables
* Do not clear session-level variables on deadlock errors
since only the transaction is lost, not the whole session
* Make sure any empty transaction is destroyed on deadlock
* Attempt reconnection *before* triggering the transaction
callbacks since some of them might want to use the database
* Define wasConnectionError() for postgres
* Remove unused return value from handleSessionLoss()
Change-Id: Ic1dcab03f087ce310637210e8e9bc0771e44f045
jenkins-bot [Thu, 29 Mar 2018 20:07:43 +0000 (20:07 +0000)]
Merge "Allow schema overrides to drop tables."
Umherirrender [Thu, 29 Mar 2018 19:53:10 +0000 (21:53 +0200)]
build: Updating mediawiki/mediawiki-codesniffer to 17.0.0
Change-Id: Ib494b47c54fe6354d166055b1e1b31d3583bb992
daniel [Wed, 28 Mar 2018 20:02:42 +0000 (22:02 +0200)]
Allow schema overrides to drop tables.
This allows unit tests to use schema overrides that drop tables,
in addition to overrides that create or modify tables.
Change-Id: I59761c7db7f83698749324ca6b9ffced86ab1249
jenkins-bot [Thu, 29 Mar 2018 19:30:06 +0000 (19:30 +0000)]
Merge "Bump avro to 1.8"
jenkins-bot [Thu, 29 Mar 2018 18:46:41 +0000 (18:46 +0000)]
Merge "Fix MockMessageLocalizer"
Roan Kattouw [Thu, 29 Mar 2018 15:57:08 +0000 (17:57 +0200)]
RCFilters UI: Remove CSS customization for help icon
This fixes most of the misalignment after the OOUI v0.26 upgrade.
Bug: T191014
Change-Id: I4623836d134fa52fb6b562e671a5da104b787b7d
jenkins-bot [Thu, 29 Mar 2018 14:49:25 +0000 (14:49 +0000)]
Merge "Add protection for User: JSON pages in the same manner as JS & CSS ones"
James D. Forrester [Tue, 13 Feb 2018 00:20:05 +0000 (16:20 -0800)]
Add protection for User: JSON pages in the same manner as JS & CSS ones
Also recognise MediaWiki: JSON pages (with the existing protection of
the editinterface right).
Bug: T76554
Change-Id: Idba166d82ee6dd507d7345c9bdbefc8ca78ed7b4
Lucas Werkmeister [Thu, 29 Mar 2018 10:32:00 +0000 (12:32 +0200)]
Fix MockMessageLocalizer
Add it to the autoloader for the tests, and remove the unneeded use
statements which cause test failures.
Change-Id: I7092525eae440c6969fc84e8979572957733cf03
jenkins-bot [Thu, 29 Mar 2018 04:07:42 +0000 (04:07 +0000)]
Merge "Make SpecialWhatLinkshere::showIndirectLinks use buildSelectSubquery()"
Timo Tijhof [Tue, 27 Mar 2018 01:18:19 +0000 (18:18 -0700)]
Improve docs for archive schema in tables.sql
Also fix typo in migrateArchiveText.php from
295b055ea33d.
Change-Id: Id225782783007c4674c5b25860172c07273d1045
Max Semenik [Thu, 29 Mar 2018 00:58:33 +0000 (17:58 -0700)]
Bump avro to 1.8
Adss PHP7 support.
Bug: T177273
Change-Id: I38cf66d6602170cec3a307bfe44656db103c321f
Volker E [Wed, 28 Mar 2018 22:50:04 +0000 (15:50 -0700)]
RCFilters: Rename deprecated 'unClip' icon to 'bookmark'
'unClip' got deprecated in OOUI v0.26.1 and 'bookmark' is the new,
more appropriate name.
Bug: T183601
Change-Id: I797071327987a8032b9d7d1d9bcfa27f4fd9db2f
jenkins-bot [Wed, 28 Mar 2018 21:48:52 +0000 (21:48 +0000)]
Merge "Normalize and lower the default DB lag wait timeout"
Aaron Schulz [Wed, 28 Mar 2018 21:36:18 +0000 (14:36 -0700)]
Make SpecialWhatLinkshere::showIndirectLinks use buildSelectSubquery()
This avoids the SPI log warning from
d395dfb039
Change-Id: I193418a224a8c6c0cc919e29c66686947d5969bf
Aaron Schulz [Wed, 28 Mar 2018 20:49:21 +0000 (13:49 -0700)]
Normalize and lower the default DB lag wait timeout
Bug: T190960
Change-Id: I49aca118583b20314e6bf82f196f3413571f5bd9
Timo Tijhof [Wed, 28 Mar 2018 20:18:14 +0000 (13:18 -0700)]
RawAction: Remove unused $gen variable
Follows-up
697c423259 (MW 1.27), which removed use of these variables.
The '$this->gen' member is never used, and neither is local $gen.
Change-Id: I663d343d0255d5e13d7d87b1d4e565a7df667449
jenkins-bot [Wed, 28 Mar 2018 19:25:40 +0000 (19:25 +0000)]
Merge "BaseTemplate: Remove code for unused 'ispermalink' toolbox item"
jenkins-bot [Wed, 28 Mar 2018 17:25:54 +0000 (17:25 +0000)]
Merge "Add MockMessageLocalizer"
jenkins-bot [Wed, 28 Mar 2018 16:27:39 +0000 (16:27 +0000)]
Merge "resourceloader: Replace ClientHtml 'target' param with 'options' array"
jenkins-bot [Wed, 28 Mar 2018 16:26:02 +0000 (16:26 +0000)]
Merge "resourceloader: Add test for ClientHtml passing down 'target'"
jenkins-bot [Wed, 28 Mar 2018 15:41:54 +0000 (15:41 +0000)]
Merge "Get ~100% test coverage for ApiEditPage.php and fix a couple of bugs"
jenkins-bot [Wed, 28 Mar 2018 13:51:10 +0000 (13:51 +0000)]
Merge "Selenium: install bluebird, mwbot dependency"
jenkins-bot [Wed, 28 Mar 2018 13:43:48 +0000 (13:43 +0000)]
Merge "Let built-in web server handle .php requests"
Antoine Musso [Fri, 23 Mar 2018 10:38:26 +0000 (11:38 +0100)]
Let built-in web server handle .php requests
When using the PHP built-in webserver with maintenance/dev/start.sh,
requests made to regular files do show in the console output but
requests to .php files do not log anything in the console. It is a bit
annoying since one is left wondering whether the requests are actually
honored.
The reason is the request router maintenance/dev/includes/router.php
does a require of the PHP file and abort the router (return true). That
causes the built-in php server to not produce the access log requests.
Based on the comment note, some earlier PHP version had POST data
stripped preventing login. The related upstream bug is
https://bugs.php.net/bug.php?id=60159:
"Router returns false, but POST is not passed to requested resource"
750eac7e41d introduced the workaround on Nov 24th 2011. PHP 5.4.0 got
released in March 2012 and refers to that bug. The development of our
router thus must have used a development/beta version of PHP 5.4.
Since the fix made it to the PHP final release, there is no need for
workaround anymore.
Bug: T190503
Change-Id: Ia8c4f1610ea0ef5b04ea30d6e91199b8e597065b
Aryeh Gregor [Tue, 20 Mar 2018 13:25:26 +0000 (15:25 +0200)]
Get ~100% test coverage for ApiEditPage.php and fix a couple of bugs
Bugs fixed:
* The major one was that appendtext and prependtext seemingly didn't
work at all on empty pages in the MediaWiki namespace, because
$this->getTitle() was being used in place of $titleObj.
* Negative undo/undoafter were not rejected in a correct fashion.
* If a logged-in user who was not allowed to upload images tried to
create an image redirect, the error message used a nonexistent key.
I also replaced assertEquals with assertSame.
I also removed a bit of clearly dead code. This includes a "break"
following dieStatus(). If we actually want this break so that nobody
adds a case after the default and then removes the dieStatus() so the
switch incorrectly falls through, it could be re-added with
@codeCoverageIgnore.
I put the fixes in the same commit as the test changes because I like to
keep fixes together with the tests for those fixes.
All code now shows up as covered locally, except for one line that seems
to be a PHPUnit bug.
Change-Id: I9375bc5f40268fd681a2d447c66a03f40b23390a
jenkins-bot [Wed, 28 Mar 2018 12:30:07 +0000 (12:30 +0000)]
Merge "RCFilters: Bidi isolate tag names and descriptions"
Željko Filipin [Wed, 28 Mar 2018 11:15:57 +0000 (13:15 +0200)]
Selenium: install bluebird, mwbot dependency
Bluebird is implicitly installed on my machine, probably because I have a recent npm version. It needs to be explicitly installed in MediaWiki-Vagrant, probably because of an older npm version.
Bug: T190914
Change-Id: I9c704502fb5e20abf9b21d483723eb55b6fb3875
Lucas Werkmeister [Wed, 28 Mar 2018 11:00:27 +0000 (13:00 +0200)]
Add MockMessageLocalizer
This MessageLocalizer may be used in tests. By default, it sets the
language for all messages to 'qqx', to make the tests independent of the
$wgLanguageCode of the wiki the tests are running in.
Change-Id: I7412ec49b6c0fab8146e09bb8aa599b35d88fc97
Prateek Saxena [Wed, 28 Mar 2018 06:14:04 +0000 (11:44 +0530)]
SizeFilterWidget: Reduce width
Change-Id: Ib4fd667ce6bfcd0dd86a19619a7610c6c92b0619
Brian Wolff [Wed, 28 Mar 2018 01:20:07 +0000 (01:20 +0000)]
Fix --memory-limit option to maintenance scripts
Follow up
2f293bd0. Previously this option was marked as not
taking an argument, thus if present it would have the value of
true (aka 1). Setting memory limit to 1 results in setting to
256kb, which is way too small.
Change-Id: I2a6e512e384c5ef882f7ba2877091ecb8fe01e35
Timo Tijhof [Tue, 27 Mar 2018 21:28:03 +0000 (14:28 -0700)]
resourceloader: Replace ClientHtml 'target' param with 'options' array
In preparation for passing down 'safemode' from OutputPage.
Only used in one place in Wikimedia Git: OutputPage::getRlClient().
Bug: T185303
Change-Id: If01eca96986ff8d7dcdaab6910bf183ba7c7311f
jenkins-bot [Tue, 27 Mar 2018 22:38:24 +0000 (22:38 +0000)]
Merge "This patch reduces the edit summary length to 500 characters"
Timo Tijhof [Tue, 27 Mar 2018 21:23:38 +0000 (14:23 -0700)]
resourceloader: Add test for ClientHtml passing down 'target'
This was not previously tested.
Change-Id: I25d9ec28b712b0b699f1369b284faf337b8af5aa
Raimond Spekking [Tue, 27 Mar 2018 19:56:36 +0000 (19:56 +0000)]
Revert "Localisation updates from https://translatewiki.net."
Overwrites new messages
This reverts commit
a7c30ad5d91dee12958c2a29ff6ffdc06a65d6e3.
Change-Id: I40b6aae837f2d4c06e860d47a8255d6f7ab2cf59
Translation updater bot [Tue, 27 Mar 2018 19:54:05 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idf22ae14a5fb2d2a0e5615720e047c63f32cdfff
Bartosz Dziewoński [Tue, 27 Mar 2018 19:43:28 +0000 (21:43 +0200)]
BaseTemplate: Remove code for unused 'ispermalink' toolbox item
This code path is never used.
When introduced in 2005 (
bf0d92d5 / rSVN10709), the "Permanent link"
item in the MonoBook sidebar was a link to an oldid only when viewing
the latest version of an article (using the ID 't-permalink'), and
otherwise it was a greyed out link to nowhere to indicate you're
already viewing a permanent link (using the ID 't-ispermalink').
Later, in 2007, when the behavior of "Cite this page" item (now part
of the CiteThisPage extension) was corrected for old revisions
(
1a60bd4c / rSVN21819), the "greying out" of the permalink was removed
to be consistent with the new item. Only half of the feature was
removed though: permalink was no longer a link to nowhere, but the
code in MonoBook to make permalinks that are links to nowhere greyed
out (by using different ID) stayed.
This code was then dutifully preserved when BaseTemplate, MonoBook was
rewritten, and then through several refactorings.
I think we can safely remove it. Leftover styles in MonoBook are being
removed in I58aca1f4255df14d6289e167e180dad31b546a8c.
Change-Id: I2fb3d7e0ecb3bbbd0c09774e2d86f86502a48bf1
jenkins-bot [Tue, 27 Mar 2018 14:23:20 +0000 (14:23 +0000)]
Merge "Revert "Pass revision being reverted to edit code""
jenkins-bot [Tue, 27 Mar 2018 14:15:47 +0000 (14:15 +0000)]
Merge "mediawiki.user: Implement mw.user.stickyRandomId"
jenkins-bot [Tue, 27 Mar 2018 00:25:42 +0000 (00:25 +0000)]
Merge "Make WikiPage::doViewUpdates use a PRESEND deferred update"
jenkins-bot [Tue, 27 Mar 2018 00:02:58 +0000 (00:02 +0000)]
Merge "Overhaul site_stats table"
Eddie Greiner-Petter [Mon, 8 May 2017 19:31:54 +0000 (21:31 +0200)]
Overhaul site_stats table
The site stats table holds a bunch of metric fields, two of which are of
data type "bigint unsigned", 3 are "bigint" (signed) and one is int
(signed). Also the default values differ widely: It is 0 on the
"unsigned" fields and the "int" field, but -1 on the three others. This
patch makes all of this more consistent:
Set all fields (except the ss_row_id, which isn't changed) data type to
"bigint unsigned". Also set NULL as the default value for all those
fields. Obviously -1 isn't a possible default value any more. Also, 0
can easily be mistaken for a real value (e.g. ss_active_users=0 -->
"there is nobody active on this wiki"). NULL, by it's definition, is the
value of choice for a value to insert into fields of which we don't know
a correct value.
The respective patch files were tested locally against MySql, Sqlite,
Postgres and SQL Server 2016. Neither oracle nor the upgrade with
update.php was tested.
Bug: T56888
Change-Id: I7d42aae434852a56b6f8dd559d8a5f3bce416021
Subramanya Sastry [Mon, 26 Mar 2018 23:42:20 +0000 (16:42 -0700)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
ad7c4322d4dd7903065f066d8d96ead875b5126b
Change-Id: Ica20c20ce8f40786f9b2b8ec4c3021f49843354f
jenkins-bot [Mon, 26 Mar 2018 23:12:31 +0000 (23:12 +0000)]
Merge "Fix whitespace trimming in headings"
jenkins-bot [Mon, 26 Mar 2018 22:59:06 +0000 (22:59 +0000)]
Merge "tests: Remove some unused stuff in phpunit tests"
Max Semenik [Sat, 17 Mar 2018 07:49:07 +0000 (00:49 -0700)]
tests: Remove some unused stuff in phpunit tests
Change-Id: Ica20e4f4ac0887b7cac12700ffcd15f587b3ba01
jenkins-bot [Mon, 26 Mar 2018 22:45:28 +0000 (22:45 +0000)]
Merge "Cleanup ProfilerOutputDb try/catch logic for DBErrors"
jenkins-bot [Mon, 26 Mar 2018 22:40:46 +0000 (22:40 +0000)]
Merge "mediawiki.api.upload: Fix test assumption about <iframe>"
MaxSem [Mon, 26 Mar 2018 22:28:46 +0000 (22:28 +0000)]
Revert "Pass revision being reverted to edit code"
Too many regressions, doing it the different way.
This reverts commit
b7737ebed1e8940df4dfd4c50c1224d0edc8639d.
Bug: T190374
Change-Id: I12cb7470aeb7852ddea319c7e499ca3a7b45c84c
jenkins-bot [Mon, 26 Mar 2018 21:51:52 +0000 (21:51 +0000)]
Merge "rdbms: ignore DBO_IGNORE if passed into Database::__construct()"
jenkins-bot [Mon, 26 Mar 2018 21:51:50 +0000 (21:51 +0000)]
Merge "rdbms: add "use" statement for UnexpectedValueExcetion in Database"
jenkins-bot [Mon, 26 Mar 2018 21:05:35 +0000 (21:05 +0000)]
Merge "Create save/publish buttons labels with ellipses"
jenkins-bot [Mon, 26 Mar 2018 20:20:48 +0000 (20:20 +0000)]
Merge "Bump required Postgres version to 9.2"
Max Semenik [Mon, 26 Mar 2018 18:47:02 +0000 (11:47 -0700)]
Bump required Postgres version to 9.2
This was approved by TechCom in the "PostgreSQL schema change for
consistency with MySQL" RfC (T164898).
Bug: T164898
Bug: T190539
Change-Id: I1b17c18c513e4edcd9219e36e873c55dd7f33034
Moriel Schottlender [Mon, 26 Mar 2018 20:00:25 +0000 (23:00 +0300)]
RCFilters: Bidi isolate tag names and descriptions
Tags can be untranslated in wikis; most often remain in English
even in an RTL wiki. Since that text is inserted by external
input that can be outside normal translation, we should expect
any directional string in there, and these should be bidi isolated.
Bug: T190718
Change-Id: Iebc3176c5d0f5097badd0dde565a5a6cbfa3a3c2
jenkins-bot [Mon, 26 Mar 2018 19:59:46 +0000 (19:59 +0000)]
Merge "RCFilters: Hide 'reload watchlist automatically' setting if RCFilters is enabled"
Aaron Schulz [Mon, 26 Mar 2018 04:04:11 +0000 (21:04 -0700)]
Make WikiPage::doViewUpdates use a PRESEND deferred update
This is better than a dubious try/catch which had the off chance
of letting partial implicit transactions be committed.
Change-Id: Ied4870df166dc5a8224866284ea6e1958e65f499