From: Thalia <thalia.e.chan@googlemail.com>
Date: Wed, 17 May 2017 17:13:17 +0000 (+0200)
Subject: MediaSearchWidget: Only resize new results
X-Git-Tag: 1.31.0-rc.0~3224^2
X-Git-Url: http://git.cyclocoop.org//%22%22.str_replace%28%27%22%27%2C?a=commitdiff_plain;h=6547ac19a564774cb8c9beb879bbf21b30c78c2d;p=lhc%2Fweb%2Fwiklou.git

MediaSearchWidget: Only resize new results

When repositioning images based on the "change" event,
ignore images that have already been assigned to a row.

Bug: T163727
Change-Id: Ida7556d8848f98d97d82aef9caf5c1d43bb47d7b
---

diff --git a/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js b/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js
index 5cbd2ec98f..1cc168abaf 100644
--- a/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js
+++ b/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js
@@ -351,7 +351,7 @@
 	};
 
 	/**
-	 * Respond to add results event in the results widget.
+	 * Respond to change results event in the results widget.
 	 * Override the way SelectWidget and GroupElement append the items
 	 * into the group so we can append them in groups of rows.
 	 *
@@ -374,6 +374,12 @@
 			// Go over the added items
 			row = search.getAvailableRow();
 			for ( i = 0, ilen = items.length; i < ilen; i++ ) {
+
+				// Check item has just been added
+				if ( items[ i ].row !== null ) {
+					continue;
+				}
+
 				itemWidth = items[ i ].$element.outerWidth( true );
 
 				// Add items to row until it is full
@@ -408,6 +414,7 @@
 
 				// Append the item
 				search.rows[ row ].$element.append( items[ i ].$element );
+
 			}
 
 			// If we have less than 4 rows, call for more images