From 8b074987c95b5240212cbd96c8e8a41c4cff8315 Mon Sep 17 00:00:00 2001 From: Kevin Israel Date: Mon, 16 Dec 2013 20:13:48 -0500 Subject: [PATCH] update.php: Fix PHP4 syntax error PHP4 does not support method chaining, so I broke the line into two so we can continue to show a more helpful error message in that version of PHP, which reached EOL just about six years ago. Also changed "Done. The job took [...]" to "Done in [...]"; "job" has a specific meaning in MediaWiki that is irrelevant here. Follows-up fae8daa658c1. Change-Id: If2480aa24f18d36f33462d874b2a1dd13abb641a --- maintenance/update.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/maintenance/update.php b/maintenance/update.php index e01406d07c..beed72089d 100644 --- a/maintenance/update.php +++ b/maintenance/update.php @@ -170,8 +170,8 @@ class UpdateMediaWiki extends Maintenance { } $time2 = new MWTimestamp(); - $this->output( "\nDone.\n" ); - $this->output( "\nThe job took " . $time2->diff( $time1 )->format( "%i:%S" ) . ".\n" ); + $timeDiff = $time2->diff( $time1 ); + $this->output( "\nDone in " . $timeDiff->format( "%i:%S" ) . ".\n" ); } function afterFinalSetup() { -- 2.20.1