From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Fri, 27 Dec 2013 12:57:02 +0000 (+0100)
Subject: Return void for LogPager::limitPerformer and limitTitle
X-Git-Tag: 1.31.0-rc.0~17423^2
X-Git-Url: http://git.cyclocoop.org//%22%22._DIR_PLUGIN_FULLCALENDAR.%22prive/themes/spip/images/event_edit.png/%22?a=commitdiff_plain;h=142017ca9799ead6e8be2af65df87968fa88ebfe;p=lhc%2Fweb%2Fwiklou.git

Return void for LogPager::limitPerformer and limitTitle

Previously, return values were inconsistent, and according to Chad,
no callers are interested in a return value.

Change-Id: Ib55e7a1c775953f8e90af4b4dedca403c33ac42d
---

diff --git a/includes/logging/LogPager.php b/includes/logging/LogPager.php
index 7efb23d7dd..900ece9789 100644
--- a/includes/logging/LogPager.php
+++ b/includes/logging/LogPager.php
@@ -154,15 +154,15 @@ class LogPager extends ReverseChronologicalPager {
 	 * Set the log reader to return only entries by the given user.
 	 *
 	 * @param string $name (In)valid user name
-	 * @return bool
+	 * @return void
 	 */
 	private function limitPerformer( $name ) {
 		if ( $name == '' ) {
-			return false;
+			return;
 		}
 		$usertitle = Title::makeTitleSafe( NS_USER, $name );
 		if ( is_null( $usertitle ) ) {
-			return false;
+			return;
 		}
 		/* Fetch userid at first, if known, provides awesome query plan afterwards */
 		$userid = User::idFromName( $name );
@@ -179,6 +179,7 @@ class LogPager extends ReverseChronologicalPager {
 			$this->mConds[] = $this->mDb->bitAnd( 'log_deleted', LogPage::SUPPRESSED_USER ) .
 				' != ' . LogPage::SUPPRESSED_USER;
 		}
+
 		$this->performer = $usertitle->getText();
 	}
 
@@ -188,7 +189,7 @@ class LogPager extends ReverseChronologicalPager {
 	 *
 	 * @param string|Title $page Title name
 	 * @param string $pattern
-	 * @return bool
+	 * @return void
 	 */
 	private function limitTitle( $page, $pattern ) {
 		global $wgMiserMode;
@@ -198,7 +199,7 @@ class LogPager extends ReverseChronologicalPager {
 		} else {
 			$title = Title::newFromText( $page );
 			if ( strlen( $page ) == 0 || !$title instanceof Title ) {
-				return false;
+				return;
 			}
 		}